- Git - lists.phpmyadmin.net

[phpmyadmin/sql-parser] 1db81e: Use PHP 7.4 for phpstan analysis
by William Desportes 27 Aug '20

27 Aug '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/sql-parser Commit: 1db81ef03e8e1420555511b7bb74829ac22a1ba5 https://github.com/phpmyadmin/sql-parser/commit/1db81ef03e8e1420555511b7bb7… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M .travis.yml Log Message: ----------- Use PHP 7.4 for phpstan analysis Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/sql-parser] 541948: Fix #309 - Use stream_select instead of non-blocking STDIN
by Sergio Durigan Junior 27 Aug '20

27 Aug '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/sql-parser Commit: 5419487eb14c96e729bc6b3cda1c6e215b5097af https://github.com/phpmyadmin/sql-parser/commit/5419487eb14c96e729bc6b3cda1… Author: Sergio Durigan Junior <sergio.durigan(a)canonical.com> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M src/Utils/CLI.php Log Message: ----------- Fix #309 - Use stream_select instead of non-blocking STDIN The idiom used in the readStdin function from src/Utils/CLI.php is not entirely error-prone: marking stdin as non-blocking and then reading from it can lead to racy scenarios where we are not able to catch what's being fed to the program. This can be seen very frequently on s390x, where a loop like this: $ while echo "invalid query" | /usr/bin/php7.4 /path/to//highlight-query; do sleep 1; done; will lead to failures once on every few runs (as can be seen in the description of issue #309). This commit implements the more robust method which uses stream_select to wait for stdin to become available, but resorts to a sensible timeout value (0.2 seconds) which will prevent the blocking from happening. I tested this patch extensively on s390x and amd64, and noticed that the non-determinism is gone. Signed-off-by: Sergio Durigan Junior <sergio.durigan(a)canonical.com> Commit: c862a108b363c40fcc9d3ae03c0e0983f1a7d8ae https://github.com/phpmyadmin/sql-parser/commit/c862a108b363c40fcc9d3ae03c0… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M src/Utils/CLI.php Log Message: ----------- #309 - Set back PHP compatibility Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 0770895be14d06f3ee9df912e947d7774eb11872 https://github.com/phpmyadmin/sql-parser/commit/0770895be14d06f3ee9df912e94… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M src/Utils/CLI.php Log Message: ----------- Merge #312 - Fix #309 - Use stream_select instead of non-blocking STDIN Pull-request: #312 Fixes: #309 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: e0da85e69f9eb3571982f161c831b68d6d537eb4 https://github.com/phpmyadmin/sql-parser/commit/e0da85e69f9eb3571982f161c83… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M CHANGELOG.md Log Message: ----------- Add a ChangeLog entry for #309 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 29ce64ec4421015fc0bd2f08a343786967cb5f5c https://github.com/phpmyadmin/sql-parser/commit/29ce64ec4421015fc0bd2f08a34… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M CHANGELOG.md M src/Utils/CLI.php Log Message: ----------- Merge branch 'QA' Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 9ce26b93198e13c4505af6e50511865123e62db7 https://github.com/phpmyadmin/sql-parser/commit/9ce26b93198e13c4505af6e5051… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M composer.json M phpstan-baseline.neon Log Message: ----------- Upgrade phpstan Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 39e1a300c876a6de3c6e447a621e6068bc2edce6 https://github.com/phpmyadmin/sql-parser/commit/39e1a300c876a6de3c6e447a621… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M .travis.yml Log Message: ----------- Allow "Backward compatibility check" to fail because of the repeated false positives Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/sql-parser] 541948: Fix #309 - Use stream_select instead of non-blocking STDIN
by Sergio Durigan Junior 27 Aug '20

27 Aug '20

Branch: refs/heads/QA Home: https://github.com/phpmyadmin/sql-parser Commit: 5419487eb14c96e729bc6b3cda1c6e215b5097af https://github.com/phpmyadmin/sql-parser/commit/5419487eb14c96e729bc6b3cda1… Author: Sergio Durigan Junior <sergio.durigan(a)canonical.com> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M src/Utils/CLI.php Log Message: ----------- Fix #309 - Use stream_select instead of non-blocking STDIN The idiom used in the readStdin function from src/Utils/CLI.php is not entirely error-prone: marking stdin as non-blocking and then reading from it can lead to racy scenarios where we are not able to catch what's being fed to the program. This can be seen very frequently on s390x, where a loop like this: $ while echo "invalid query" | /usr/bin/php7.4 /path/to//highlight-query; do sleep 1; done; will lead to failures once on every few runs (as can be seen in the description of issue #309). This commit implements the more robust method which uses stream_select to wait for stdin to become available, but resorts to a sensible timeout value (0.2 seconds) which will prevent the blocking from happening. I tested this patch extensively on s390x and amd64, and noticed that the non-determinism is gone. Signed-off-by: Sergio Durigan Junior <sergio.durigan(a)canonical.com> Commit: c862a108b363c40fcc9d3ae03c0e0983f1a7d8ae https://github.com/phpmyadmin/sql-parser/commit/c862a108b363c40fcc9d3ae03c0… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M src/Utils/CLI.php Log Message: ----------- #309 - Set back PHP compatibility Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 0770895be14d06f3ee9df912e947d7774eb11872 https://github.com/phpmyadmin/sql-parser/commit/0770895be14d06f3ee9df912e94… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M src/Utils/CLI.php Log Message: ----------- Merge #312 - Fix #309 - Use stream_select instead of non-blocking STDIN Pull-request: #312 Fixes: #309 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: e0da85e69f9eb3571982f161c831b68d6d537eb4 https://github.com/phpmyadmin/sql-parser/commit/e0da85e69f9eb3571982f161c83… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-08-27 (Thu, 08 August 2020) +02:00 Changed paths: M CHANGELOG.md Log Message: ----------- Add a ChangeLog entry for #309 Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] 94b3fe: Update PHPstan
by Maurício Meneghini Fauth 26 Aug '20

26 Aug '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 94b3fea4a73333a240b7eff3bc4fd1aa202f3bc7 https://github.com/phpmyadmin/phpmyadmin/commit/94b3fea4a73333a240b7eff3bc4… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-08-26 (Wed, 08 August 2020) -03:00 Changed paths: M composer.json M phpstan-baseline.neon Log Message: ----------- Update PHPstan Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 03d831: Create the PhpMyAdmin\Profiling class
by Maurício Meneghini Fauth 26 Aug '20

26 Aug '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 03d8314bba3de610ac2809c18864677f2b4caac1 https://github.com/phpmyadmin/phpmyadmin/commit/03d8314bba3de610ac2809c1886… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-08-26 (Wed, 08 August 2020) -03:00 Changed paths: A libraries/classes/Profiling.php A test/classes/ProfilingTest.php M libraries/classes/Core.php M libraries/classes/Html/Generator.php M libraries/classes/Server/Status/Monitor.php M libraries/classes/Sql.php M libraries/classes/Util.php M libraries/common.inc.php Log Message: ----------- Create the PhpMyAdmin\Profiling class Extracts Profiling related methods to the Profiling class. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 3e7169: Extract profiling methods from Sql::executeTheQuery
by Maurício Meneghini Fauth 26 Aug '20

26 Aug '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 3e71690a0b55a6bfebd6d731d7d773a1a2b112db https://github.com/phpmyadmin/phpmyadmin/commit/3e71690a0b55a6bfebd6d731d7d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-08-25 (Tue, 08 August 2020) -03:00 Changed paths: M libraries/classes/Sql.php Log Message: ----------- Extract profiling methods from Sql::executeTheQuery Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 84db19: Translated using Weblate (French)
by Olivier Humbert 25 Aug '20

25 Aug '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 84db19a66095a83eb5eda99b1548b83d293b4777 https://github.com/phpmyadmin/phpmyadmin/commit/84db19a66095a83eb5eda99b154… Author: Olivier Humbert <trebmuh(a)tuxfamily.org> Date: 2020-08-18 (Tue, 08 August 2020) +02:00 Changed paths: M po/fr.po Log Message: ----------- Translated using Weblate (French) Currently translated at 100.0% (3334 of 3334 strings) [CI skip] Translation: phpMyAdmin/5.0 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/fr/ Signed-off-by: Olivier Humbert <trebmuh(a)tuxfamily.org> Commit: fcc51f0cde53b2dfbf9956bfe00bfdfac43e0dd0 https://github.com/phpmyadmin/phpmyadmin/commit/fcc51f0cde53b2dfbf9956bfe00… Author: Burak Yavuz <hitowerdigit(a)hotmail.com> Date: 2020-08-18 (Tue, 08 August 2020) +02:00 Changed paths: M po/tr.po Log Message: ----------- Translated using Weblate (Turkish) Currently translated at 100.0% (3334 of 3334 strings) [CI skip] Translation: phpMyAdmin/5.0 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/tr/ Signed-off-by: Burak Yavuz <hitowerdigit(a)hotmail.com> Commit: 7712fc2fc2cc188d682fbb1f90312be52772dfdd https://github.com/phpmyadmin/phpmyadmin/commit/7712fc2fc2cc188d682fbb1f903… Author: Annlix <Annlix(a)outlook.com> Date: 2020-08-19 (Wed, 08 August 2020) +02:00 Changed paths: M po/zh_CN.po Log Message: ----------- Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (3334 of 3334 strings) [CI skip] Translation: phpMyAdmin/5.0 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/zh_Hans/ Signed-off-by: Annlix <Annlix(a)outlook.com> Commit: 3212b911369690a7b177115116d08f96cc75d223 https://github.com/phpmyadmin/phpmyadmin/commit/3212b911369690a7b177115116d… Author: dingo thirteen <dingo13(a)d404.nl> Date: 2020-08-21 (Fri, 08 August 2020) +02:00 Changed paths: M po/nl.po Log Message: ----------- Translated using Weblate (Dutch) Currently translated at 100.0% (3334 of 3334 strings) [CI skip] Translation: phpMyAdmin/5.0 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-0/nl/ Signed-off-by: dingo thirteen <dingo13(a)d404.nl> Commit: 622241c15f5054facffb9c3015d6d594557af0d2 https://github.com/phpmyadmin/phpmyadmin/commit/622241c15f5054facffb9c3015d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-08-25 (Tue, 08 August 2020) -03:00 Changed paths: M ChangeLog M libraries/classes/Sql.php Log Message: ----------- Fix profiling table not incrementing calls Fixes #16318 Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 919a25a849fc65fdf5abd704b201a8d180119ceb https://github.com/phpmyadmin/phpmyadmin/commit/919a25a849fc65fdf5abd704b20… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-08-25 (Tue, 08 August 2020) -03:00 Changed paths: M ChangeLog Log Message: ----------- Merge branch 'QA_5_0' Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 622241: Fix profiling table not incrementing calls
by Maurício Meneghini Fauth 25 Aug '20

25 Aug '20

Branch: refs/heads/QA_5_0 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 622241c15f5054facffb9c3015d6d594557af0d2 https://github.com/phpmyadmin/phpmyadmin/commit/622241c15f5054facffb9c3015d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-08-25 (Tue, 08 August 2020) -03:00 Changed paths: M ChangeLog M libraries/classes/Sql.php Log Message: ----------- Fix profiling table not incrementing calls Fixes #16318 Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] e7e9bd: Remove the Sql::getHtmlForProfilingChart method
by Maurício Meneghini Fauth 25 Aug '20

25 Aug '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: e7e9bd770fde55ff610ad2a3c61d48d02ec10e46 https://github.com/phpmyadmin/phpmyadmin/commit/e7e9bd770fde55ff610ad2a3c61… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-08-25 (Tue, 08 August 2020) -03:00 Changed paths: M libraries/classes/Sql.php M templates/sql/profiling_chart.twig D templates/sql/detailed_table.twig Log Message: ----------- Remove the Sql::getHtmlForProfilingChart method Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 99abf3: Remove the Sql::getHtmlForSetColumn method
by Maurício Meneghini Fauth 25 Aug '20

25 Aug '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 99abf3ab3cfa19a3d1c9bc7b1c1c793f8b0c8b0f https://github.com/phpmyadmin/phpmyadmin/commit/99abf3ab3cfa19a3d1c9bc7b1c1… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-08-24 (Mon, 08 August 2020) -03:00 Changed paths: M libraries/classes/Controllers/SqlController.php M libraries/classes/Sql.php M templates/sql/set_column.twig Log Message: ----------- Remove the Sql::getHtmlForSetColumn method Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0