- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] 8ec420: Fix some coding standard issues
by Maurício Meneghini Fauth 20 Jan '20

20 Jan '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 8ec42090028d7a945af43ce078d73d99568249e3 https://github.com/phpmyadmin/phpmyadmin/commit/8ec42090028d7a945af43ce078d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-01-20 (Mon, 01 January 2020) -03:00 Changed paths: M libraries/classes/Advisor.php M libraries/classes/Bookmark.php M libraries/classes/CentralColumns.php M libraries/classes/Config.php M libraries/classes/Controllers/Database/QueryByExampleController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/ImportController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/RelationController.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Database/DatabaseList.php M libraries/classes/Database/Designer.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Database/Qbe.php M libraries/classes/DatabaseInterface.php M libraries/classes/Dbal/DbiMysqli.php M libraries/classes/Di/Migration.php M libraries/classes/Display/Export.php M libraries/classes/Display/ImportAjax.php M libraries/classes/Display/Results.php M libraries/classes/Engines/Innodb.php M libraries/classes/ErrorHandler.php M libraries/classes/Export.php M libraries/classes/File.php M libraries/classes/FileListing.php M libraries/classes/Html/ActionLinksModes/Factory.php M libraries/classes/Html/Generator.php M libraries/classes/Import.php M libraries/classes/Index.php M libraries/classes/InsertEdit.php M libraries/classes/LanguageManager.php M libraries/classes/ListAbstract.php M libraries/classes/ListDatabase.php M libraries/classes/Message.php M libraries/classes/Operations.php M libraries/classes/Plugins.php M libraries/classes/Plugins/Export/ExportOds.php M libraries/classes/Plugins/Export/ExportOdt.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Export/ExportXml.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/ExportPlugin.php M libraries/classes/Plugins/Import/ImportCsv.php M libraries/classes/Plugins/Import/ImportSql.php M libraries/classes/Plugins/Transformations/Output/Text_Plain_Binarytoip.php M libraries/classes/Relation.php M libraries/classes/Replication.php M libraries/classes/Rte/Routines.php M libraries/classes/SavedSearches.php M libraries/classes/Server/Privileges.php M libraries/classes/Server/UserGroups.php M libraries/classes/Sql.php M libraries/classes/SqlQueryForm.php M libraries/classes/StorageEngine.php M libraries/classes/Table.php M libraries/classes/Table/Search.php M libraries/classes/ThemeManager.php M libraries/classes/Transformations.php M libraries/classes/Twig/I18n/NodeTrans.php M libraries/classes/Twig/I18n/TokenParserTrans.php M libraries/classes/Url.php M libraries/classes/Util.php M libraries/tbl_columns_definition_form.inc.php M phpstan-baseline.neon M show_config_errors.php M test/classes/TableTest.php M url.php Log Message: ----------- Fix some coding standard issues - Inverts yoda comparisons - Removes parentheses from return - Removes useless ternary operators - Adds paretheses to new instances - Adds trailing array comma Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] efcc16: Use null coalescing when setting MySQLi SSL
by Maurício Meneghini Fauth 19 Jan '20

19 Jan '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: efcc167cbb4ab67cce2faef6e4de22e6d2a57b84 https://github.com/phpmyadmin/phpmyadmin/commit/efcc167cbb4ab67cce2faef6e4d… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-01-19 (Sun, 01 January 2020) -03:00 Changed paths: M libraries/classes/Dbal/DbiMysqli.php Log Message: ----------- Use null coalescing when setting MySQLi SSL Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 3f7204beb7f07610da1da55067c8cf6e7697fd15 https://github.com/phpmyadmin/phpmyadmin/commit/3f7204beb7f07610da1da55067c… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-01-19 (Sun, 01 January 2020) -03:00 Changed paths: M libraries/classes/DatabaseInterface.php M libraries/classes/Gis/GisPolygon.php M libraries/classes/Index.php M libraries/classes/Message.php M libraries/classes/Navigation/NavigationTree.php M libraries/classes/Navigation/Nodes/Node.php M libraries/classes/OpenDocument.php M libraries/classes/OutputBuffering.php M libraries/classes/Partition.php M libraries/classes/Pdf.php M libraries/classes/Plugins/Export/ExportCodegen.php M libraries/classes/Plugins/Import/Upload/UploadApc.php M libraries/classes/Plugins/Import/Upload/UploadNoplugin.php M libraries/classes/Plugins/Import/Upload/UploadProgress.php M libraries/classes/Plugins/Import/Upload/UploadSession.php M libraries/classes/Url.php M phpcs.xml.dist Log Message: ----------- Add coding standard rule for self reference Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 3c22f5: Add conding standard rule for useless method overrides
by Maurício Meneghini Fauth 19 Jan '20

19 Jan '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 3c22f5e7b204ee6a578bcb60babaf8bacd7ee8fa https://github.com/phpmyadmin/phpmyadmin/commit/3c22f5e7b204ee6a578bcb60bab… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-01-19 (Sun, 01 January 2020) -03:00 Changed paths: M libraries/classes/Controllers/Table/GisVisualizationController.php M libraries/classes/Controllers/Table/IndexesController.php M phpcs.xml.dist Log Message: ----------- Add conding standard rule for useless method overrides Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 555d07: Add coding standard rule for unnecessary string concat
by Maurício Meneghini Fauth 19 Jan '20

19 Jan '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 555d07bc305adc9d14d6c3ee4f5bf10b79078840 https://github.com/phpmyadmin/phpmyadmin/commit/555d07bc305adc9d14d6c3ee4f5… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-01-19 (Sun, 01 January 2020) -03:00 Changed paths: M libraries/classes/Rte/General.php M phpcs.xml.dist Log Message: ----------- Add coding standard rule for unnecessary string concat Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 285907: Add coding standard rules for whitespace
by Maurício Meneghini Fauth 19 Jan '20

19 Jan '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 285907991e61f47fe605b5b239526a05473e242e https://github.com/phpmyadmin/phpmyadmin/commit/285907991e61f47fe605b5b2395… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-01-19 (Sun, 01 January 2020) -03:00 Changed paths: M examples/openid.php M libraries/classes/Config.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Config/Validator.php M libraries/classes/Controllers/HomeController.php M libraries/classes/Controllers/Table/RelationController.php M libraries/classes/Core.php M libraries/classes/Database/Designer.php M libraries/classes/Database/Qbe.php M libraries/classes/DatabaseInterface.php M libraries/classes/Display/Export.php M libraries/classes/Display/Results.php M libraries/classes/Encoding.php M libraries/classes/Engines/Pbxt.php M libraries/classes/Error.php M libraries/classes/ErrorHandler.php M libraries/classes/File.php M libraries/classes/Gis/GisPolygon.php M libraries/classes/Html/Forms/Fields/BrowseUploadFileBlock.php M libraries/classes/Html/Forms/Fields/DropDown.php M libraries/classes/Html/Forms/Fields/DropDownUploadFileBlock.php M libraries/classes/Html/Forms/Fields/FKCheckbox.php M libraries/classes/Html/Forms/Fields/MaxFileSize.php M libraries/classes/Html/Forms/Fields/RadioList.php M libraries/classes/Html/Generator.php M libraries/classes/Import.php M libraries/classes/LanguageManager.php M libraries/classes/Message.php M libraries/classes/Navigation/NodeFactory.php M libraries/classes/Plugins/Export/ExportCodegen.php M libraries/classes/Plugins/Export/ExportPdf.php M libraries/classes/Plugins/Export/ExportPhparray.php M libraries/classes/Plugins/Export/ExportXml.php M libraries/classes/Plugins/Import/ImportCsv.php M libraries/classes/Plugins/Import/ImportMediawiki.php M libraries/classes/Plugins/ImportPlugin.php M libraries/classes/Plugins/Schema/Pdf/Pdf.php M libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/FormattedTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/InlineTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/SQLTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/SubstringTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextImageLinkTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextLinkTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Output/Text_Plain_Binarytoip.php M libraries/classes/Properties/Options/OptionsPropertyGroup.php M libraries/classes/Properties/Plugins/SchemaPluginProperties.php M libraries/classes/Relation.php M libraries/classes/Sanitize.php M libraries/classes/Server/Privileges.php M libraries/classes/Sql.php M libraries/classes/Table.php M libraries/classes/Tracker.php M libraries/classes/Tracking.php M libraries/classes/Transformations.php M libraries/classes/Twig/I18n/NodeTrans.php M libraries/classes/Util.php M phpcs.xml.dist M test/classes/ConfigTest.php M test/classes/CoreTest.php M test/classes/Display/ResultsTest.php M test/classes/EncodingTest.php M test/classes/Engines/BinlogTest.php M test/classes/ErrorHandlerTest.php M test/classes/FooterTest.php M test/classes/Gis/GisFactoryTest.php M test/classes/Gis/GisMultiLineStringTest.php M test/classes/Gis/GisMultiPointTest.php M test/classes/Gis/GisMultiPolygonTest.php M test/classes/Html/Forms/Fields/DropDownTest.php M test/classes/Html/Forms/Fields/RadioListTest.php M test/classes/MenuTest.php M test/classes/MimeTest.php M test/classes/Navigation/Nodes/NodeTableContainerTest.php M test/classes/Navigation/Nodes/NodeTableTest.php M test/classes/Navigation/Nodes/NodeTriggerContainerTest.php M test/classes/Navigation/Nodes/NodeTriggerTest.php M test/classes/Navigation/Nodes/NodeViewContainerTest.php M test/classes/OperationsTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M test/classes/Plugins/Auth/AuthenticationHttpTest.php M test/classes/Plugins/Export/ExportCodegenTest.php M test/classes/Plugins/Export/ExportHtmlwordTest.php M test/classes/Plugins/Export/ExportMediawikiTest.php M test/classes/Plugins/Export/ExportOdtTest.php M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Plugins/Export/ExportTexytextTest.php M test/classes/Plugins/Import/ImportShpTest.php M test/classes/Server/PrivilegesTest.php M test/classes/StorageEngineTest.php M test/classes/TableTest.php M test/classes/TrackerTest.php M test/classes/TrackingTest.php M test/classes/UrlTest.php M test/classes/Utils/HttpRequestTest.php M test/classes/VersionInformationTest.php M test/selenium/ExportTest.php M test/selenium/LoginTest.php M test/selenium/TestBase.php Log Message: ----------- Add coding standard rules for whitespace Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 63dbcd: Remove or ignore side effects in PHP files
by Maurício Meneghini Fauth 19 Jan '20

19 Jan '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 63dbcd01d9565679cb3bf20a53e1f6b5f3bb412a https://github.com/phpmyadmin/phpmyadmin/commit/63dbcd01d9565679cb3bf20a53e… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-01-19 (Sun, 01 January 2020) -03:00 Changed paths: M examples/openid.php M index.php M js/messages.php M libraries/classes/Plugins/Export/ExportPdf.php M libraries/classes/Plugins/Export/ExportXml.php M libraries/classes/Plugins/Import/ImportLdi.php M libraries/classes/Plugins/Schema/Pdf/Pdf.php M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php M libraries/common.inc.php M libraries/mult_submits.inc.php M libraries/vendor_config.php M phpcs.xml.dist M setup/config.php M setup/index.php M setup/lib/common.inc.php M setup/validate.php M show_config_errors.php M test/bootstrap-dist.php M test/bootstrap-phpstan.php M test/classes/CentralColumnsTest.php M test/classes/Display/ChangePasswordTest.php M test/classes/Display/ErrorTest.php M test/classes/ListDatabaseTest.php M test/classes/Plugins/Auth/AuthenticationCookieTest.php M url.php Log Message: ----------- Remove or ignore side effects in PHP files Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 33477f: Remove side effects from Config class
by Maurício Meneghini Fauth 19 Jan '20

19 Jan '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 33477fe024608de2e4b4b3e55e377cf362737746 https://github.com/phpmyadmin/phpmyadmin/commit/33477fe024608de2e4b4b3e55e3… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2020-01-19 (Sun, 01 January 2020) -03:00 Changed paths: M libraries/classes/Config.php M libraries/common.inc.php Log Message: ----------- Remove side effects from Config class Moves the side effects to the common.inc.php file. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 5a0341: fixes url.
by Jayati Shrivastava 19 Jan '20

19 Jan '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 5a03410cfac02fca9c95f53537ba8485dc2e2fc6 https://github.com/phpmyadmin/phpmyadmin/commit/5a03410cfac02fca9c95f53537b… Author: Jayati Shrivastava <gaurijove(a)gmail.com> Date: 2020-01-19 (Sun, 01 January 2020) +05:30 Changed paths: M libraries/classes/Controllers/Table/StructureController.php M templates/table/page_with_secondary_tabs.twig M test/selenium/Table/CreateTest.php Log Message: ----------- fixes url. fixes #15797 Signed-off-by: Jayati Shrivastava <gaurijove(a)gmail.com> Commit: ae0577ab1e4607539e53e11a747618a2d0b0dc98 https://github.com/phpmyadmin/phpmyadmin/commit/ae0577ab1e4607539e53e11a747… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M libraries/classes/Controllers/Table/StructureController.php M templates/table/page_with_secondary_tabs.twig M test/selenium/Table/CreateTest.php Log Message: ----------- Merge #15820 - Fix #15797 - Relation view broken Fixes: #15797 Pull-request: #15820 Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] e7d47e: Fix #13864 - prevent resetting of enum fields
by Jayati Shrivastava 19 Jan '20

19 Jan '20

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: e7d47e840e3ca22204227c12301371f5ad830bdb https://github.com/phpmyadmin/phpmyadmin/commit/e7d47e840e3ca22204227c12301… Author: Jayati Shrivastava <gaurijove(a)gmail.com> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M js/table/change.js Log Message: ----------- Fix #13864 - prevent resetting of enum fields Fixes: #13864 Signed-off-by: Jayati Shrivastava <gaurijove(a)gmail.com> Commit: d0ae286b9d9e8ea1d8224914fe4c34d28cc62a61 https://github.com/phpmyadmin/phpmyadmin/commit/d0ae286b9d9e8ea1d8224914fe4… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M js/table/change.js Log Message: ----------- Merge #15657 - Fix #13864 - prevent resetting of enum fields Fixes: #13864 Pull-request: #15657 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 6812f54ce32e1ded21b25c544b5e294147d10b13 https://github.com/phpmyadmin/phpmyadmin/commit/6812f54ce32e1ded21b25c544b5… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M ChangeLog Log Message: ----------- Add ChangeLog entry for #13864 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 67f6f2b69c162a27ab2531b50d9b433892c69f83 https://github.com/phpmyadmin/phpmyadmin/commit/67f6f2b69c162a27ab2531b50d9… Author: Rahul Gurung <gurungrahul2(a)gmail.com> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M templates/sql/relational_column_dropdown.twig Log Message: ----------- fixed browse foreign values modal with grid edit Signed-off-by: Rahul Gurung <gurungrahul2(a)gmail.com> Commit: 448e6557a0b7f6e693a1352dc451038ba66c96af https://github.com/phpmyadmin/phpmyadmin/commit/448e6557a0b7f6e693a1352dc45… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M templates/sql/relational_column_dropdown.twig Log Message: ----------- Merge #15819 - Fix #15811 - Browse foreign values doesn't work with grid edit Fixes: #15811 Pull-request: #15819 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 899a63d2ceb193e1b84a287ea91ffa04edc10b91 https://github.com/phpmyadmin/phpmyadmin/commit/899a63d2ceb193e1b84a287ea91… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M ChangeLog Log Message: ----------- Add ChangeLog entry for #15811 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 3a947706bff84ca054a679acd4e060e3def32399 https://github.com/phpmyadmin/phpmyadmin/commit/3a947706bff84ca054a679acd4e… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M ChangeLog M js/table/change.js M templates/sql/relational_column_dropdown.twig Log Message: ----------- Merge branch 'QA_5_0' Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0

[phpmyadmin/phpmyadmin] e7d47e: Fix #13864 - prevent resetting of enum fields
by Jayati Shrivastava 19 Jan '20

19 Jan '20

Branch: refs/heads/QA_5_0 Home: https://github.com/phpmyadmin/phpmyadmin Commit: e7d47e840e3ca22204227c12301371f5ad830bdb https://github.com/phpmyadmin/phpmyadmin/commit/e7d47e840e3ca22204227c12301… Author: Jayati Shrivastava <gaurijove(a)gmail.com> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M js/table/change.js Log Message: ----------- Fix #13864 - prevent resetting of enum fields Fixes: #13864 Signed-off-by: Jayati Shrivastava <gaurijove(a)gmail.com> Commit: d0ae286b9d9e8ea1d8224914fe4c34d28cc62a61 https://github.com/phpmyadmin/phpmyadmin/commit/d0ae286b9d9e8ea1d8224914fe4… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M js/table/change.js Log Message: ----------- Merge #15657 - Fix #13864 - prevent resetting of enum fields Fixes: #13864 Pull-request: #15657 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 6812f54ce32e1ded21b25c544b5e294147d10b13 https://github.com/phpmyadmin/phpmyadmin/commit/6812f54ce32e1ded21b25c544b5… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M ChangeLog Log Message: ----------- Add ChangeLog entry for #13864 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 67f6f2b69c162a27ab2531b50d9b433892c69f83 https://github.com/phpmyadmin/phpmyadmin/commit/67f6f2b69c162a27ab2531b50d9… Author: Rahul Gurung <gurungrahul2(a)gmail.com> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M templates/sql/relational_column_dropdown.twig Log Message: ----------- fixed browse foreign values modal with grid edit Signed-off-by: Rahul Gurung <gurungrahul2(a)gmail.com> Commit: 448e6557a0b7f6e693a1352dc451038ba66c96af https://github.com/phpmyadmin/phpmyadmin/commit/448e6557a0b7f6e693a1352dc45… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M templates/sql/relational_column_dropdown.twig Log Message: ----------- Merge #15819 - Fix #15811 - Browse foreign values doesn't work with grid edit Fixes: #15811 Pull-request: #15819 Signed-off-by: William Desportes <williamdes(a)wdes.fr> Commit: 899a63d2ceb193e1b84a287ea91ffa04edc10b91 https://github.com/phpmyadmin/phpmyadmin/commit/899a63d2ceb193e1b84a287ea91… Author: William Desportes <williamdes(a)wdes.fr> Date: 2020-01-19 (Sun, 01 January 2020) +01:00 Changed paths: M ChangeLog Log Message: ----------- Add ChangeLog entry for #15811 Signed-off-by: William Desportes <williamdes(a)wdes.fr>

1 0