January 2016 - Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] 750af6: Function was used before it was defined
by Marc Delisle 05 Jan '16

05 Jan '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 750af61ad52566153921544e23eb9213d944fc6a https://github.com/phpmyadmin/phpmyadmin/commit/750af61ad52566153921544e23e… Author: Marc Delisle <marc(a)infomarc.info> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M js/navigation.js Log Message: ----------- Function was used before it was defined Signed-off-by: Marc Delisle <marc(a)infomarc.info>

1 0

[phpmyadmin/phpmyadmin] c660ed: Simplify code by removing parallel if statements
by Michal Čihař 05 Jan '16

05 Jan '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c660edd057d49d7de2a089ba27ea8cf1bd44dc57 https://github.com/phpmyadmin/phpmyadmin/commit/c660edd057d49d7de2a089ba27e… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/plugins/export/ExportSql.php Log Message: ----------- Simplify code by removing parallel if statements Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 1168ed61b4ab652946afec1b6dc90ffe55ead39a https://github.com/phpmyadmin/phpmyadmin/commit/1168ed61b4ab652946afec1b6dc… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/plugins/export/ExportSql.php Log Message: ----------- Share code for routines export The exporting of functions and procedures is almost same. Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/063392e66485...1168ed61b4ab

1 0

[phpmyadmin/phpmyadmin] fdcf30: Fix operator placements and indentation
by Michal Čihař 05 Jan '16

05 Jan '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: fdcf305834edcbdfeee8c0832862207c5275cee0 https://github.com/phpmyadmin/phpmyadmin/commit/fdcf305834edcbdfeee8c083286… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M js/tbl_change.js Log Message: ----------- Fix operator placements and indentation Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 063392e664854bc9a827b640d8902c17ef978667 https://github.com/phpmyadmin/phpmyadmin/commit/063392e664854bc9a827b640d89… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M js/tbl_change.js Log Message: ----------- Merge branch 'QA_4_5' Compare: https://github.com/phpmyadmin/phpmyadmin/compare/a74efb0c3057...063392e66485

1 0

[phpmyadmin/phpmyadmin] fdcf30: Fix operator placements and indentation
by Michal Čihař 05 Jan '16

05 Jan '16

Branch: refs/heads/QA_4_5 Home: https://github.com/phpmyadmin/phpmyadmin Commit: fdcf305834edcbdfeee8c0832862207c5275cee0 https://github.com/phpmyadmin/phpmyadmin/commit/fdcf305834edcbdfeee8c083286… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M js/tbl_change.js Log Message: ----------- Fix operator placements and indentation Signed-off-by: Michal Čihař <michal(a)cihar.com>

1 0

[phpmyadmin/phpmyadmin] 03f2e3: Simplify code to get largest table
by Michal Čihař 05 Jan '16

05 Jan '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 03f2e37ef4c56729b3e622ba489d541472551724 https://github.com/phpmyadmin/phpmyadmin/commit/03f2e37ef4c56729b3e622ba489… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/DbQbe.php Log Message: ----------- Simplify code to get largest table We really do not have to sort the array, we just need the maximal value. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 2bdd046b06b3af9c03981e057d8eb5048788edde https://github.com/phpmyadmin/phpmyadmin/commit/2bdd046b06b3af9c03981e057d8… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/mysql_charsets.inc.php Log Message: ----------- Remove not needed reset() The variable is used only with foreach(), which does reset internally (or uses different pointer with PHP 7). Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: a74efb0c30572af23f1d3de71de335a448951a73 https://github.com/phpmyadmin/phpmyadmin/commit/a74efb0c30572af23f1d3de71de… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/DatabaseInterface.php M libraries/DbQbe.php M libraries/controllers/server/ServerDatabasesController.php Log Message: ----------- Simplify getting first element of an array Calling current() after reset() is duplicate as reset() already returns current index value. Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/c9b0935e7dea...a74efb0c3057

1 0

[phpmyadmin/phpmyadmin] 65555e: Ensure test can be executed separately
by Michal Čihař 05 Jan '16

05 Jan '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 65555e51d5ece50b7e05a87cf806c598fd871b41 https://github.com/phpmyadmin/phpmyadmin/commit/65555e51d5ece50b7e05a87cf80… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M test/classes/plugin/import/ImportShpTest.php Log Message: ----------- Ensure test can be executed separately Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 941325eb1875aa32b4b34b077e1dea68a76e60e2 https://github.com/phpmyadmin/phpmyadmin/commit/941325eb1875aa32b4b34b077e1… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/zip_extension.lib.php Log Message: ----------- Close file only if it is opened Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 7f9333c3e17e21b712d7560df6a2d34b42564ed2 https://github.com/phpmyadmin/phpmyadmin/commit/7f9333c3e17e21b712d7560df6a… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M test/classes/plugin/import/ImportShpTest.php A test/test_data/dresden_osm.shp.zip Log Message: ----------- Add second test for shape file import This one contains multipolygons to test more complex things. The data is based on OpenStreetMap, licensed under ODbL 1.0. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 3c90f450209f89c788f4a61e91226fe0dbcb7741 https://github.com/phpmyadmin/phpmyadmin/commit/3c90f450209f89c788f4a61e912… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/plugins/import/ShapeRecord.php Log Message: ----------- Simplify shape record loading We can use foreach with reference to simplify the code. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: c9b0935e7dea95a87dc2465cf567e11bb0e2492d https://github.com/phpmyadmin/phpmyadmin/commit/c9b0935e7dea95a87dc2465cf56… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/gis/GISVisualization.php Log Message: ----------- Fix typo Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/5ba197dc70f7...c9b0935e7dea

1 0

[phpmyadmin/phpmyadmin] e4c194: Fix #11821 TypeError: $this_function.val(...) is n...
by Atul Pratap Singh 05 Jan '16

05 Jan '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: e4c194ccded61fa123504e3edd95a48160eec452 https://github.com/phpmyadmin/phpmyadmin/commit/e4c194ccded61fa123504e3edd9… Author: Atul Pratap Singh <atulpratapsingh05(a)gmail.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M js/functions.js M js/tbl_change.js Log Message: ----------- Fix #11821 TypeError: $this_function.val(...) is null Signed-off-by: Atul Pratap Singh <atulpratapsingh05(a)gmail.com> Commit: 5ba197dc70f728ccccd114e38d118bf47870b8ce https://github.com/phpmyadmin/phpmyadmin/commit/5ba197dc70f728ccccd114e38d1… Author: Atul Pratap Singh <atulpratapsingh05(a)gmail.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M js/functions.js M js/tbl_change.js Log Message: ----------- Merge branch 'QA_4_5' Compare: https://github.com/phpmyadmin/phpmyadmin/compare/f4eb1a9b4f7d...5ba197dc70f7

1 0

[phpmyadmin/phpmyadmin] e4c194: Fix #11821 TypeError: $this_function.val(...) is n...
by Atul Pratap Singh 05 Jan '16

05 Jan '16

Branch: refs/heads/QA_4_5 Home: https://github.com/phpmyadmin/phpmyadmin Commit: e4c194ccded61fa123504e3edd95a48160eec452 https://github.com/phpmyadmin/phpmyadmin/commit/e4c194ccded61fa123504e3edd9… Author: Atul Pratap Singh <atulpratapsingh05(a)gmail.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M js/functions.js M js/tbl_change.js Log Message: ----------- Fix #11821 TypeError: $this_function.val(...) is null Signed-off-by: Atul Pratap Singh <atulpratapsingh05(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] c2ea3b: Build output in less steps
by Michal Čihař 05 Jan '16

05 Jan '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c2ea3bcc7de14773e7a211f98ad8373ff4251984 https://github.com/phpmyadmin/phpmyadmin/commit/c2ea3bcc7de14773e7a211f98ad… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/gis/GISVisualization.php Log Message: ----------- Build output in less steps Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: a37273c5ba957ed60609194047c64a562afcab35 https://github.com/phpmyadmin/phpmyadmin/commit/a37273c5ba957ed60609194047c… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/controllers/table/TableChartController.php M libraries/controllers/table/TableStructureController.php M test/classes/controllers/DatabaseStructureControllerTest.php Log Message: ----------- Initialize array variables Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: f4eb1a9b4f7ddb1a91a4452c435f360bf5bed45f https://github.com/phpmyadmin/phpmyadmin/commit/f4eb1a9b4f7ddb1a91a4452c435… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/SysInfoWINNT.php M libraries/bfShapeFiles/ShapeFile.lib.php M libraries/controllers/table/TableSearchController.php M libraries/display_export.lib.php M libraries/display_import.lib.php M libraries/plugins/export/ExportSql.php Log Message: ----------- There is no need to reset() before foreach() The code is there since past when PHP 4 was still supported reset was necessary. Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/4a3f055527ca...f4eb1a9b4f7d

1 0

[phpmyadmin/phpmyadmin] a7d247: Avoid ignoring error
by Michal Čihař 05 Jan '16

05 Jan '16

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a7d24730257cd3a93b0b0d1e2735755dbc99353b https://github.com/phpmyadmin/phpmyadmin/commit/a7d24730257cd3a93b0b0d1e273… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/DisplayResults.php Log Message: ----------- Avoid ignoring error There should be no error here as we've queried the result few lines ago. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: b66c189cafff92e4ae68a8420834063a96d7e436 https://github.com/phpmyadmin/phpmyadmin/commit/b66c189cafff92e4ae68a842083… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/gis/GISVisualization.php Log Message: ----------- Document todo Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: e0b1c1643ed8e92ec9f1947d6432eaae477d2cf2 https://github.com/phpmyadmin/phpmyadmin/commit/e0b1c1643ed8e92ec9f1947d643… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/Config.php M libraries/file_listing.lib.php Log Message: ----------- Close should not fail if open didn't Hiding error on close is not needed, this should not happen unless the system is really in a bad shape. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 05b264564e3e29a2abece8a399ddc4ddca93675a https://github.com/phpmyadmin/phpmyadmin/commit/05b264564e3e29a2abece8a399d… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/gis/GISVisualization.php Log Message: ----------- Simplify indentation Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 7973c2986ea33a39617667fe542d3d2e87397b2b https://github.com/phpmyadmin/phpmyadmin/commit/7973c2986ea33a39617667fe542… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/gis/GISGeometrycollection.php M libraries/gis/GISVisualization.php Log Message: ----------- Better handle parse errors in GIS The mb_stripos can return false and we should handle it. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: ea8382efcd92acf52f4f42992873d64330e54598 https://github.com/phpmyadmin/phpmyadmin/commit/ea8382efcd92acf52f4f4299287… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/gis/GISGeometrycollection.php M libraries/gis/GISVisualization.php Log Message: ----------- Do not use case insensitive char for symbols lookup These only add performance penatly at no benefit. Signed-off-by: Michal Čihař <michal(a)cihar.com> Commit: 4a3f055527caf22cb34edda398a0e59506ad762d https://github.com/phpmyadmin/phpmyadmin/commit/4a3f055527caf22cb34edda398a… Author: Michal Čihař <michal(a)cihar.com> Date: 2016-01-05 (Tue, 05 Jan 2016) Changed paths: M libraries/insert_edit.lib.php Log Message: ----------- Free result only if it exists Signed-off-by: Michal Čihař <michal(a)cihar.com> Compare: https://github.com/phpmyadmin/phpmyadmin/compare/592207946ecd...4a3f055527ca

1 0