- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] 56926e: Move Config::loadDefaults() to constructor
by Maurício Meneghini Fauth 28 Apr '23

28 Apr '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 56926e807f93cadff52ea3f8371a340894e9ea4c https://github.com/phpmyadmin/phpmyadmin/commit/56926e807f93cadff52ea3f8371… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-27 (Thu, 04 April 2023) -03:00 Changed paths: M libraries/classes/Config.php M test/classes/BrowseForeignersTest.php M test/classes/ConfigTest.php Log Message: ----------- Move Config::loadDefaults() to constructor Makes sure that Config's properties are always initialized and that the config property is in sync with the settings property. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 42d01ccd47160c1fa271885002583d4890972c98 https://github.com/phpmyadmin/phpmyadmin/commit/42d01ccd47160c1fa2718850025… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-28 (Fri, 04 April 2023) -03:00 Changed paths: M libraries/classes/Config.php M test/classes/BrowseForeignersTest.php M test/classes/ConfigTest.php Log Message: ----------- Merge pull request #18370 from MauricioFauth/config-load-defaults Move Config::loadDefaults() to constructor

1 0

[phpmyadmin/phpmyadmin] fd8845: Update request URI scheme with config value
by Maurício Meneghini Fauth 27 Apr '23

27 Apr '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: fd88454d087b92c5d386200a0449b0b79318c878 https://github.com/phpmyadmin/phpmyadmin/commit/fd88454d087b92c5d386200a044… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-27 (Thu, 04 April 2023) -03:00 Changed paths: M libraries/classes/Common.php M libraries/classes/Config.php Log Message: ----------- Update request URI scheme with config value Removes the Config::isHttps() call from constructor as PmaAbsoluteUri is not available yet. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 74ba4f: Remove config global var from Logging class
by Maurício Meneghini Fauth 27 Apr '23

27 Apr '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 74ba4f17b0fe07200639cfd26b4c16648ed33400 https://github.com/phpmyadmin/phpmyadmin/commit/74ba4f17b0fe07200639cfd26b4… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-27 (Thu, 04 April 2023) -03:00 Changed paths: M libraries/classes/Common.php M libraries/classes/Config/Settings.php M libraries/classes/Logging.php M libraries/classes/Plugins/AuthenticationPlugin.php M psalm-baseline.xml M test/classes/Config/SettingsTest.php Log Message: ----------- Remove config global var from Logging class Uses the Settings class to access the log settings. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] df4acc: Refactor Config\SettingsTest tests
by Maurício Meneghini Fauth 26 Apr '23

26 Apr '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: df4acc931b03c7f42d117c0be9821095b6b2a689 https://github.com/phpmyadmin/phpmyadmin/commit/df4acc931b03c7f42d117c0be98… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-26 (Wed, 04 April 2023) -03:00 Changed paths: M test/classes/Config/SettingsTest.php Log Message: ----------- Refactor Config\SettingsTest tests Tests properties individually. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 6c88a0: Translated using Weblate (Arabic)
by Meno25 26 Apr '23

26 Apr '23

Branch: refs/heads/QA_5_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 6c88a0b94b4facfb6c5d84545002bd4947a5a347 https://github.com/phpmyadmin/phpmyadmin/commit/6c88a0b94b4facfb6c5d8454500… Author: Meno25 <meno25mail(a)gmail.com> Date: 2023-04-26 (Wed, 04 April 2023) +02:00 Changed paths: M po/ar.po Log Message: ----------- Translated using Weblate (Arabic) Currently translated at 56.6% (1942 of 3427 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/ar/ Signed-off-by: Meno25 <meno25mail(a)gmail.com> Commit: c5783557f475b994a0f7dd09ff7cf7ef9d69aeb0 https://github.com/phpmyadmin/phpmyadmin/commit/c5783557f475b994a0f7dd09ff7… Author: Kristjan Räts <kristjanrats(a)gmail.com> Date: 2023-04-26 (Wed, 04 April 2023) +02:00 Changed paths: M po/et.po Log Message: ----------- Translated using Weblate (Estonian) Currently translated at 100.0% (3427 of 3427 strings) [ci skip] Translation: phpMyAdmin/5.2 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/5-2/et/ Signed-off-by: Kristjan Räts <kristjanrats(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] 581643: Translated using Weblate (Arabic)
by Meno25 26 Apr '23

26 Apr '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 581643b913a1fd67c5e5204af969dc04e4430689 https://github.com/phpmyadmin/phpmyadmin/commit/581643b913a1fd67c5e5204af96… Author: Meno25 <meno25mail(a)gmail.com> Date: 2023-04-26 (Wed, 04 April 2023) +02:00 Changed paths: M po/ar.po Log Message: ----------- Translated using Weblate (Arabic) Currently translated at 54.9% (1896 of 3448 strings) [ci skip] Translation: phpMyAdmin/Development Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ar/ Signed-off-by: Meno25 <meno25mail(a)gmail.com> Commit: 0fed9036887e06a44bf8a8edbed5d2274f2b3760 https://github.com/phpmyadmin/phpmyadmin/commit/0fed9036887e06a44bf8a8edbed… Author: Kristjan Räts <kristjanrats(a)gmail.com> Date: 2023-04-26 (Wed, 04 April 2023) +02:00 Changed paths: M po/et.po Log Message: ----------- Translated using Weblate (Estonian) Currently translated at 98.2% (3388 of 3448 strings) [ci skip] Translation: phpMyAdmin/Development Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/et/ Signed-off-by: Kristjan Räts <kristjanrats(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] e39ad3: Translated using Weblate (Arabic)
by Meno25 26 Apr '23

26 Apr '23

Branch: refs/heads/QA_4_9 Home: https://github.com/phpmyadmin/phpmyadmin Commit: e39ad398050cb47dcad6ff4472a978c552b10016 https://github.com/phpmyadmin/phpmyadmin/commit/e39ad398050cb47dcad6ff4472a… Author: Meno25 <meno25mail(a)gmail.com> Date: 2023-04-26 (Wed, 04 April 2023) +02:00 Changed paths: M po/ar.po Log Message: ----------- Translated using Weblate (Arabic) Currently translated at 56.9% (1886 of 3309 strings) [CI skip] Translation: phpMyAdmin/4.9 Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-9/ar/ Signed-off-by: Meno25 <meno25mail(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] 747941: Move $returnToSqlQuery out of the method
by Kamil Tekiela 25 Apr '23

25 Apr '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 747941ece1437a1e7cf159017c02a1e1e4125ddf https://github.com/phpmyadmin/phpmyadmin/commit/747941ece1437a1e7cf159017c0… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Move $returnToSqlQuery out of the method Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 62459b33e5f89a9c502edd29974205276303b5b5 https://github.com/phpmyadmin/phpmyadmin/commit/62459b33e5f89a9c502edd29974… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Change RW param into a private property Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: a8070b5498994c994974cf0b3efee9b148aac272 https://github.com/phpmyadmin/phpmyadmin/commit/a8070b5498994c994974cf0b3ef… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php M test/classes/Plugins/Transformations/TransformationPluginsTest.php Log Message: ----------- $tabindexForValue was always 0 Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 7f05587905c97cc58e33d96a14a111c70cd1eba3 https://github.com/phpmyadmin/phpmyadmin/commit/7f05587905c97cc58e33d96a14a… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml Log Message: ----------- Remove method_exists Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 269535a7a57da4a1d16e5c04083ffa7d21fb1cf1 https://github.com/phpmyadmin/phpmyadmin/commit/269535a7a57da4a1d16e5c04083… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Change $tabindex into a private property Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0032b489f359b6107cd85b22f3de928807c4dc4c https://github.com/phpmyadmin/phpmyadmin/commit/0032b489f359b6107cd85b22f3d… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php M test/classes/InsertEditTest.php Log Message: ----------- Merge $tabindex and $idindex into $fieldIndex Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 1e14d588a7a62093387ee47397a4c10fb911c537 https://github.com/phpmyadmin/phpmyadmin/commit/1e14d588a7a62093387ee47397a… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php Log Message: ----------- Replace ternary with boolean condition Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: b2357568a1aead75f59909e4af25d1e1db773f36 https://github.com/phpmyadmin/phpmyadmin/commit/b2357568a1aead75f59909e4af2… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon Log Message: ----------- Use str_ends_with and str_starts_with Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: bfe1f4facf526f0baef23151c5f9526f82a4ab48 https://github.com/phpmyadmin/phpmyadmin/commit/bfe1f4facf526f0baef23151c5f… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php Log Message: ----------- Remove redundant argument Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9a8fec903f8d8995269a2801f0a651dcfdd89a8a https://github.com/phpmyadmin/phpmyadmin/commit/9a8fec903f8d8995269a2801f0a… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml Log Message: ----------- Replace escapeString with quoteString Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: c3701e3fea6d48e5383b71582c8eda93a10f92d1 https://github.com/phpmyadmin/phpmyadmin/commit/c3701e3fea6d48e5383b71582c8… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php Log Message: ----------- Remove no longer needed @psalm-suppress Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 39035f91f974b3980f0f25c75129f1657c7f6905 https://github.com/phpmyadmin/phpmyadmin/commit/39035f91f974b3980f0f25c7512… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php Log Message: ----------- Remove strlen Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9124c19539e448a2f9c212516178e97cc16f5d57 https://github.com/phpmyadmin/phpmyadmin/commit/9124c19539e448a2f9c21251617… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Remove $GLOBALS['columns_cnt'] Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: fbb185e7a912774319ae22a54dad6fe83f1b41bc https://github.com/phpmyadmin/phpmyadmin/commit/fbb185e7a912774319ae22a54da… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Remove globals Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: ae5b5a1a865d7d6f77806bc85cde46cdebdf93df https://github.com/phpmyadmin/phpmyadmin/commit/ae5b5a1a865d7d6f77806bc85cd… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php Log Message: ----------- Remove $jsvkey and $vkey Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 36481a0dcab96afed7f19efdc047cfa038f21582 https://github.com/phpmyadmin/phpmyadmin/commit/36481a0dcab96afed7f19efdc04… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php Log Message: ----------- Change if into its short form Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: a01eefc4c2103811b99e9ce0ca80031e5ea653a7 https://github.com/phpmyadmin/phpmyadmin/commit/a01eefc4c2103811b99e9ce0ca8… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-23 (Sun, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php Log Message: ----------- Remove $timestampSeen which was always false Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 103ada16b59c32a700957667851437b159d70d64 https://github.com/phpmyadmin/phpmyadmin/commit/103ada16b59c32a700957667851… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-24 (Mon, 04 April 2023) -03:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M libraries/classes/Plugins/IOTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/CodeMirrorEditorTransformationPlugin.php M libraries/classes/Plugins/Transformations/Abs/ImageUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Abs/TextFileUploadTransformationsPlugin.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptobinary.php M libraries/classes/Plugins/Transformations/Input/Text_Plain_Iptolong.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php M test/classes/Plugins/Transformations/TransformationPluginsTest.php Log Message: ----------- Merge pull request #18366 from kamil-tekiela/InsertEdit-refactoring2 InsertEdit refactoring - part 2

1 0

[phpmyadmin/website] 6fd39c: Bump jQuery version from 3.5.1 to 3.6.4
by Maurício Meneghini Fauth 24 Apr '23

24 Apr '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/website Commit: 6fd39c9f067fe1e4dacaca12b31bf9e187dc24bb https://github.com/phpmyadmin/website/commit/6fd39c9f067fe1e4dacaca12b31bf9… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-23 (Sun, 04 April 2023) -03:00 Changed paths: A pmaweb/static/bootstrap/js/jquery-3.6.4.min.js A pmaweb/static/bootstrap/js/jquery-3.6.4.min.map M pmaweb/templates/base.html D pmaweb/static/bootstrap/js/jquery-3.5.1.min.js D pmaweb/static/bootstrap/js/jquery-3.5.1.min.map Log Message: ----------- Bump jQuery version from 3.5.1 to 3.6.4 Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 644e8d07b72da545ff2e48cde8f60b4fb56ddec0 https://github.com/phpmyadmin/website/commit/644e8d07b72da545ff2e48cde8f60b… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-23 (Sun, 04 April 2023) -03:00 Changed paths: M pmaweb/static/bootstrap/css/bootstrap.min.css M pmaweb/static/bootstrap/css/bootstrap.min.css.map M pmaweb/static/bootstrap/js/bootstrap.bundle.min.js M pmaweb/static/bootstrap/js/bootstrap.bundle.min.js.map M pmaweb/templates/base.html M pmaweb/templates/security/_list.html Log Message: ----------- Bump Bootstrap version from 4.5.3 to 5.2.3 Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: 34ba66d18537f2c136139e1709b1c83adc3c13f5 https://github.com/phpmyadmin/website/commit/34ba66d18537f2c136139e1709b1c8… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-24 (Mon, 04 April 2023) -03:00 Changed paths: A pmaweb/static/bootstrap/js/jquery-3.6.4.min.js A pmaweb/static/bootstrap/js/jquery-3.6.4.min.map M pmaweb/static/bootstrap/css/bootstrap.min.css M pmaweb/static/bootstrap/css/bootstrap.min.css.map M pmaweb/static/bootstrap/js/bootstrap.bundle.min.js M pmaweb/static/bootstrap/js/bootstrap.bundle.min.js.map M pmaweb/templates/base.html M pmaweb/templates/security/_list.html D pmaweb/static/bootstrap/js/jquery-3.5.1.min.js D pmaweb/static/bootstrap/js/jquery-3.5.1.min.map Log Message: ----------- Merge pull request #158 from MauricioFauth/bootstrap-5.2 Bump jQuery and Bootstrap versions

1 0

[phpmyadmin/phpmyadmin] a2a35c: Split up loadFirstRow
by Kamil Tekiela 23 Apr '23

23 Apr '23

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: a2a35c19de86cbd15a0088fc58f5cc7533e78bae https://github.com/phpmyadmin/phpmyadmin/commit/a2a35c19de86cbd15a0088fc58f… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Split up loadFirstRow Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0bb63c997f7ec90fba6cd70c04ba64f4307c6d55 https://github.com/phpmyadmin/phpmyadmin/commit/0bb63c997f7ec90fba6cd70c04b… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Remove getWhereClauseArray() This weird array cast is not adding anything useful. The psalm type hint tells us that elements are strings, but that's not guaranteed in any way. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9800c3574fc4bd8be0aaa5cca021cc5b354fc269 https://github.com/phpmyadmin/phpmyadmin/commit/9800c3574fc4bd8be0aaa5cca02… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Table/ChangeControllerTest.php M test/classes/InsertEditTest.php Log Message: ----------- Move urlParamsInEditMode to ChangeController Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: aa689f04f33d3549f3087e84ce74a47247ad62e9 https://github.com/phpmyadmin/phpmyadmin/commit/aa689f04f33d3549f3087e84ce7… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php Log Message: ----------- Drop getEnumSetAndTimestampColumns() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 2d7617fe475633805187c472f02dd66d34444590 https://github.com/phpmyadmin/phpmyadmin/commit/2d7617fe475633805187c472f02… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M templates/table/insert/column_row.twig M test/classes/InsertEditTest.php Log Message: ----------- Drop getColumnEnumValues() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: fa7fe0da9716413992a90ea08e2dad1ea48f83e5 https://github.com/phpmyadmin/phpmyadmin/commit/fa7fe0da9716413992a90ea08e2… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M templates/table/insert/column_row.twig M test/classes/InsertEditTest.php Log Message: ----------- Drop getColumnSetValueAndSelectSize() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 3c6fbee97c731efab1e2cf8c7979e009f38ffdee https://github.com/phpmyadmin/phpmyadmin/commit/3c6fbee97c731efab1e2cf8c797… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M test/classes/InsertEditTest.php Log Message: ----------- getMaxUploadSize() should only return string Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 8367af19be95ddd5118fc63ddf08046692293b77 https://github.com/phpmyadmin/phpmyadmin/commit/8367af19be95ddd5118fc63ddf0… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Remove unused $biggestMaxFileSize param Not sure if it should have been a global, but judging by the rest of the code, I believe it's no longer needed. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 56d1eed3581d1d910e394e982ac493ee3c13dcb8 https://github.com/phpmyadmin/phpmyadmin/commit/56d1eed3581d1d910e394e982ac… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M js/src/drag_drop_import.ts M libraries/classes/Controllers/Import/ImportController.php M psalm-baseline.xml M templates/import.twig M templates/preferences/manage/main.twig Log Message: ----------- Remove MAX_FILE_SIZE This is not used anywhere in frontend or backend. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: d10d11bf8f68afac971c2351dcf86413eca3ad95 https://github.com/phpmyadmin/phpmyadmin/commit/d10d11bf8f68afac971c2351dcf… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Add missing @psalm-return Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9640a765560b337033dc0b52a23bc3559b16f90a https://github.com/phpmyadmin/phpmyadmin/commit/9640a765560b337033dc0b52a23… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php Log Message: ----------- Move $specialCharsEncoded out of getSpecialCharsAndBackupFieldForInsertingMode Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 15f1fc44e76e6b9255be2f16e39e11e468c69dd6 https://github.com/phpmyadmin/phpmyadmin/commit/15f1fc44e76e6b9255be2f16e39… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Unwind getSpecialCharsAndBackupFieldForInsertingMode() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: a852acb3e95a938d214982d8208484204457909a https://github.com/phpmyadmin/phpmyadmin/commit/a852acb3e95a938d214982d8208… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M test/classes/InsertEditTest.php Log Message: ----------- Move $isInsertignore out of getParamsForUpdateOrInsert Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 25b24966c11e2a2e8e7fe0f5b30bf003137ba581 https://github.com/phpmyadmin/phpmyadmin/commit/25b24966c11e2a2e8e7fe0f5b30… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/InsertEditTest.php Log Message: ----------- Move getParamsForUpdateOrInsert into controller Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 5cd6c166842d11ec6208ce5e2460d0d45d30074a https://github.com/phpmyadmin/phpmyadmin/commit/5cd6c166842d11ec6208ce5e246… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2023-04-20 (Thu, 04 April 2023) +01:00 Changed paths: M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M psalm-baseline.xml M test/classes/InsertEditTest.php Log Message: ----------- Instead of returning array, use array cast Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0d2432580b1c9144bbc839431929c3c07580dfef https://github.com/phpmyadmin/phpmyadmin/commit/0d2432580b1c9144bbc83943192… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2023-04-23 (Sun, 04 April 2023) -03:00 Changed paths: M js/src/drag_drop_import.ts M libraries/classes/Controllers/Import/ImportController.php M libraries/classes/Controllers/Table/ChangeController.php M libraries/classes/Controllers/Table/ReplaceController.php M libraries/classes/InsertEdit.php M phpstan-baseline.neon M psalm-baseline.xml M templates/import.twig M templates/preferences/manage/main.twig M templates/table/insert/column_row.twig M test/classes/Controllers/Table/ChangeControllerTest.php M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/InsertEditTest.php Log Message: ----------- Merge pull request #18359 from kamil-tekiela/InsertEdit-refactoring InsertEdit refactoring - part 1

1 0