- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] 51f401: Refactor destroy controller (#17194)
by Kamil Tekiela 19 Nov '21

19 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 51f4017b32ef686aeefd037cb9456705658d075a https://github.com/phpmyadmin/phpmyadmin/commit/51f4017b32ef686aeefd037cb94… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2021-11-19 (Fri, 11 November 2021) -03:00 Changed paths: M js/src/server/databases.js M libraries/classes/Controllers/Server/Databases/DestroyController.php M psalm-baseline.xml M test/classes/Controllers/Server/Databases/DestroyControllerTest.php Log Message: ----------- Refactor destroy controller (#17194) * Remove redundant conditions They were always true. First, the variable is set to -1. If the variable is -1, then set it to Message. If the variable is Message then set the JSON array. All of this is redundant. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * $sqlQuery is not used anywhere Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Enforce $selected to be an array I can't remove it as it is a global. Previously, it was set to a POST variable. Since we validate that the variable is set and is not null, we can use the value from $params. If we validate that it's also an array we can replace for loop with foreach. There is no passing by reference, so this change should be safe. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Replace $rebuildDatabaseList with input validation The validation message says 'No databases selected.' so I assume that we should check that we actually got at least one entry in the list. If that is true, then the $rebuildDatabaseList is not needed and the condition redundant. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * drop_selected_dbs is always set and is redundant I am not sure if this is necessary. The AJAX request sends a value of "1" but the code doesn't really do anything with it other than checking if it is actually set. Is there some other path possible? Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Flatten the array with a single element Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove redundant isset The variable is set, so !isset === is_null. Why check for null if we can check just for !is_array. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Update psalm-baseline.xml Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Adhere to the coding standard Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] e91d25: Add button to view all themes
by Maurício Meneghini Fauth 19 Nov '21

19 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: e91d25803590c50cafb672f48864fa76e0526d12 https://github.com/phpmyadmin/phpmyadmin/commit/e91d25803590c50cafb672f4886… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-19 (Fri, 11 November 2021) -03:00 Changed paths: M templates/home/index.twig Log Message: ----------- Add button to view all themes Related to 2cdce1d6fb0a4116e69bd5572d6ff912404c54ae Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] b86b70: Improve type definitions of Scripts class
by Maurício Meneghini Fauth 18 Nov '21

18 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: b86b70d63917691f9fe3849b4d000f82a6710c6b https://github.com/phpmyadmin/phpmyadmin/commit/b86b70d63917691f9fe3849b4d0… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-18 (Thu, 11 November 2021) -03:00 Changed paths: M libraries/classes/Console.php M libraries/classes/Scripts.php M psalm-baseline.xml Log Message: ----------- Improve type definitions of Scripts class Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 857a9d: Remove unnecessary `@var` annotations
by Maurício Meneghini Fauth 18 Nov '21

18 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 857a9d333731d9936f4f2d16819f4c35ad46f350 https://github.com/phpmyadmin/phpmyadmin/commit/857a9d333731d9936f4f2d16819… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-18 (Thu, 11 November 2021) -03:00 Changed paths: M libraries/classes/Config.php M libraries/classes/Config/FormDisplay.php M libraries/classes/DatabaseInterface.php M libraries/classes/Display/Results.php M libraries/classes/Html/Generator.php M libraries/classes/InsertEdit.php M libraries/classes/Linter.php M libraries/classes/Menu.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Import/ImportOds.php M libraries/classes/Plugins/Import/ImportXml.php M libraries/classes/Table.php M psalm-baseline.xml Log Message: ----------- Remove unnecessary `@var` annotations Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 090d2e: Fix some issues found by PHPStan
by Maurício Meneghini Fauth 16 Nov '21

16 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 090d2eece71ddd9b4bcdbc7a226947ae83899195 https://github.com/phpmyadmin/phpmyadmin/commit/090d2eece71ddd9b4bcdbc7a226… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-16 (Tue, 11 November 2021) -03:00 Changed paths: M libraries/classes/Dbal/DbiMysqli.php M libraries/classes/Table.php M libraries/classes/Tracker.php M psalm-baseline.xml M test/classes/AbstractTestCase.php M test/classes/TrackerTest.php Log Message: ----------- Fix some issues found by PHPStan Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 0d81b2: Add test for `Sql::executeQueryAndSendQueryResponse`
by Maurício Meneghini Fauth 15 Nov '21

15 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 0d81b2166adc01ad0d6f78bd28856eae2e8434b8 https://github.com/phpmyadmin/phpmyadmin/commit/0d81b2166adc01ad0d6f78bd288… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-15 (Mon, 11 November 2021) -03:00 Changed paths: M libraries/classes/Sql.php M test/classes/SqlTest.php Log Message: ----------- Add test for `Sql::executeQueryAndSendQueryResponse` Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 98e70c: Suppress some Psalm errors in ImportXml plugin class
by Maurício Meneghini Fauth 15 Nov '21

15 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 98e70c6ae6f561447fbe2fe76814f296cd1086df https://github.com/phpmyadmin/phpmyadmin/commit/98e70c6ae6f561447fbe2fe7681… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-15 (Mon, 11 November 2021) -03:00 Changed paths: M libraries/classes/Plugins/Import/ImportXml.php Log Message: ----------- Suppress some Psalm errors in ImportXml plugin class Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 7fc8c4: Remove `@var` annotation in Table::getColumnGenerationExpression
by Maurício Meneghini Fauth 15 Nov '21

15 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 7fc8c4bd151ca28867d648d7b220644725683bfe https://github.com/phpmyadmin/phpmyadmin/commit/7fc8c4bd151ca28867d648d7b22… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-15 (Mon, 11 November 2021) -03:00 Changed paths: M libraries/classes/Table.php Log Message: ----------- Remove `@var` annotation in Table::getColumnGenerationExpression Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] b2a51c: Create the `RelationParameters` value object
by Maurício Meneghini Fauth 14 Nov '21

14 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: b2a51c4d84112262170da878963ae6ce71a99ebf https://github.com/phpmyadmin/phpmyadmin/commit/b2a51c4d84112262170da878963… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-14 (Sun, 11 November 2021) -03:00 Changed paths: A libraries/classes/RelationParameters.php A test/classes/RelationParametersTest.php M libraries/classes/Bookmark.php M libraries/classes/Controllers/CheckRelationsController.php M libraries/classes/Controllers/Database/DataDictionaryController.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Database/QueryByExampleController.php M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Controllers/Export/Template/CreateController.php M libraries/classes/Controllers/Export/Template/DeleteController.php M libraries/classes/Controllers/Export/Template/LoadController.php M libraries/classes/Controllers/Export/Template/UpdateController.php M libraries/classes/Controllers/HomeController.php M libraries/classes/Controllers/NavigationController.php M libraries/classes/Controllers/Preferences/ExportController.php M libraries/classes/Controllers/Preferences/FeaturesController.php M libraries/classes/Controllers/Preferences/ImportController.php M libraries/classes/Controllers/Preferences/MainPanelController.php M libraries/classes/Controllers/Preferences/ManageController.php M libraries/classes/Controllers/Preferences/NavigationController.php M libraries/classes/Controllers/Preferences/SqlController.php M libraries/classes/Controllers/Preferences/TwoFactorController.php M libraries/classes/Controllers/SchemaExportController.php M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Controllers/Server/UserGroupsController.php M libraries/classes/Controllers/Server/UserGroupsFormController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/RelationController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Database/Designer.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Database/Qbe.php M libraries/classes/DatabaseInterface.php M libraries/classes/Display/Results.php M libraries/classes/ErrorReport.php M libraries/classes/Export/Options.php M libraries/classes/Menu.php M libraries/classes/Navigation/Navigation.php M libraries/classes/Navigation/Nodes/Node.php M libraries/classes/Navigation/Nodes/NodeDatabase.php M libraries/classes/Navigation/Nodes/NodeDatabaseChild.php M libraries/classes/Normalization.php M libraries/classes/Plugins/Export/ExportHtmlword.php M libraries/classes/Plugins/Export/ExportLatex.php M libraries/classes/Plugins/Export/ExportOdt.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Export/ExportTexytext.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/Plugins/Schema/Pdf/Pdf.php M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php M libraries/classes/RecentFavoriteTable.php M libraries/classes/Relation.php M libraries/classes/RelationCleanup.php M libraries/classes/SavedSearches.php M libraries/classes/Server/Privileges.php M libraries/classes/Server/UserGroups.php M libraries/classes/SystemDatabase.php M libraries/classes/Table.php M libraries/classes/Table/ColumnsDefinition.php M libraries/classes/Tracker.php M libraries/classes/Tracking.php M libraries/classes/Transformations.php M libraries/classes/UserPreferences.php M libraries/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M psalm.xml M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Navigation/NavigationTest.php M test/classes/Navigation/NavigationTreeTest.php M test/classes/Plugins/Export/ExportHtmlwordTest.php M test/classes/Plugins/Export/ExportLatexTest.php M test/classes/Plugins/Export/ExportOdtTest.php M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Plugins/Export/ExportTexytextTest.php M test/classes/Plugins/Export/ExportXmlTest.php M test/classes/Plugins/Export/ExportYamlTest.php M test/classes/PluginsTest.php M test/classes/RelationTest.php M test/classes/Server/PrivilegesTest.php M test/classes/SystemDatabaseTest.php M test/classes/TableTest.php M test/classes/UserPreferencesTest.php Log Message: ----------- Create the `RelationParameters` value object Replaces the $cfgRelation array with the RelationParameters value object. Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: f84b1fc39d6e4742455110faeda19add846cfac1 https://github.com/phpmyadmin/phpmyadmin/commit/f84b1fc39d6e4742455110faeda… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2021-11-14 (Sun, 11 November 2021) -03:00 Changed paths: A libraries/classes/RelationParameters.php A test/classes/RelationParametersTest.php M libraries/classes/Bookmark.php M libraries/classes/Controllers/CheckRelationsController.php M libraries/classes/Controllers/Database/DataDictionaryController.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Database/QueryByExampleController.php M libraries/classes/Controllers/Database/Structure/FavoriteTableController.php M libraries/classes/Controllers/Database/StructureController.php M libraries/classes/Controllers/Export/ExportController.php M libraries/classes/Controllers/Export/Template/CreateController.php M libraries/classes/Controllers/Export/Template/DeleteController.php M libraries/classes/Controllers/Export/Template/LoadController.php M libraries/classes/Controllers/Export/Template/UpdateController.php M libraries/classes/Controllers/HomeController.php M libraries/classes/Controllers/NavigationController.php M libraries/classes/Controllers/Preferences/ExportController.php M libraries/classes/Controllers/Preferences/FeaturesController.php M libraries/classes/Controllers/Preferences/ImportController.php M libraries/classes/Controllers/Preferences/MainPanelController.php M libraries/classes/Controllers/Preferences/ManageController.php M libraries/classes/Controllers/Preferences/NavigationController.php M libraries/classes/Controllers/Preferences/SqlController.php M libraries/classes/Controllers/Preferences/TwoFactorController.php M libraries/classes/Controllers/SchemaExportController.php M libraries/classes/Controllers/Server/PrivilegesController.php M libraries/classes/Controllers/Server/UserGroupsController.php M libraries/classes/Controllers/Server/UserGroupsFormController.php M libraries/classes/Controllers/Table/OperationsController.php M libraries/classes/Controllers/Table/RelationController.php M libraries/classes/Controllers/Table/StructureController.php M libraries/classes/Controllers/Transformation/WrapperController.php M libraries/classes/Database/CentralColumns.php M libraries/classes/Database/Designer.php M libraries/classes/Database/Designer/Common.php M libraries/classes/Database/Qbe.php M libraries/classes/DatabaseInterface.php M libraries/classes/Display/Results.php M libraries/classes/ErrorReport.php M libraries/classes/Export/Options.php M libraries/classes/Menu.php M libraries/classes/Navigation/Navigation.php M libraries/classes/Navigation/Nodes/Node.php M libraries/classes/Navigation/Nodes/NodeDatabase.php M libraries/classes/Navigation/Nodes/NodeDatabaseChild.php M libraries/classes/Normalization.php M libraries/classes/Plugins/Export/ExportHtmlword.php M libraries/classes/Plugins/Export/ExportLatex.php M libraries/classes/Plugins/Export/ExportOdt.php M libraries/classes/Plugins/Export/ExportSql.php M libraries/classes/Plugins/Export/ExportTexytext.php M libraries/classes/Plugins/Export/Helpers/Pdf.php M libraries/classes/Plugins/Schema/ExportRelationSchema.php M libraries/classes/Plugins/Schema/Pdf/Pdf.php M libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php M libraries/classes/RecentFavoriteTable.php M libraries/classes/Relation.php M libraries/classes/RelationCleanup.php M libraries/classes/SavedSearches.php M libraries/classes/Server/Privileges.php M libraries/classes/Server/UserGroups.php M libraries/classes/SystemDatabase.php M libraries/classes/Table.php M libraries/classes/Table/ColumnsDefinition.php M libraries/classes/Tracker.php M libraries/classes/Tracking.php M libraries/classes/Transformations.php M libraries/classes/UserPreferences.php M libraries/services_controllers.php M phpstan-baseline.neon M psalm-baseline.xml M psalm.xml M test/classes/Controllers/Table/ReplaceControllerTest.php M test/classes/Controllers/Table/SearchControllerTest.php M test/classes/Navigation/NavigationTest.php M test/classes/Navigation/NavigationTreeTest.php M test/classes/Plugins/Export/ExportHtmlwordTest.php M test/classes/Plugins/Export/ExportLatexTest.php M test/classes/Plugins/Export/ExportOdtTest.php M test/classes/Plugins/Export/ExportSqlTest.php M test/classes/Plugins/Export/ExportTexytextTest.php M test/classes/Plugins/Export/ExportXmlTest.php M test/classes/Plugins/Export/ExportYamlTest.php M test/classes/PluginsTest.php M test/classes/RelationTest.php M test/classes/Server/PrivilegesTest.php M test/classes/SystemDatabaseTest.php M test/classes/TableTest.php M test/classes/UserPreferencesTest.php Log Message: ----------- Merge pull request #17184 from mauriciofauth/relation-parameters-vo Create the `RelationParameters` value object

1 0

[phpmyadmin/localized_docs] 5bda34: Translated using Weblate (Turkish)
by Oğuz Ersen 14 Nov '21

14 Nov '21

Branch: refs/heads/master Home: https://github.com/phpmyadmin/localized_docs Commit: 5bda34b35a044c473be58100a1bb472cc82495b7 https://github.com/phpmyadmin/localized_docs/commit/5bda34b35a044c473be5810… Author: Oğuz Ersen <oguzersen(a)protonmail.com> Date: 2021-11-14 (Sun, 11 November 2021) +01:00 Changed paths: M po/tr.mo M po/tr.po Log Message: ----------- Translated using Weblate (Turkish) Currently translated at 100.0% (2607 of 2607 strings) [ci skip]

1 0