- Git - lists.phpmyadmin.net

[phpmyadmin/phpmyadmin] c8150f: Update PHPStan baseline
by Maurício Meneghini Fauth 17 Dec '22

17 Dec '22

Branch: refs/heads/QA_5_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: c8150fd81f6ea6c177a337b4ff8c049d352c6eca https://github.com/phpmyadmin/phpmyadmin/commit/c8150fd81f6ea6c177a337b4ff8… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-12-17 (Sat, 12 December 2022) -03:00 Changed paths: M phpstan-baseline.neon Log Message: ----------- Update PHPStan baseline [ci skip] Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/website] 361684: Add new sponsor gamerules.com
by Isaac Bennetch 16 Dec '22

16 Dec '22

Branch: refs/heads/master Home: https://github.com/phpmyadmin/website Commit: 361684dc232170a71cfc21db5763a16fb7cdfb78 https://github.com/phpmyadmin/website/commit/361684dc232170a71cfc21db5763a1… Author: Isaac Bennetch <bennetch(a)gmail.com> Date: 2022-12-16 (Fri, 12 December 2022) -05:00 Changed paths: M pmaweb/templates/sponsors.html Log Message: ----------- Add new sponsor gamerules.com Signed-off-by: Isaac Bennetch <bennetch(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] 90f9e7: Fix missing icon for collapse all button
by Maurício Meneghini Fauth 16 Dec '22

16 Dec '22

Branch: refs/heads/QA_5_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 90f9e708cc6faca16a27b0d87f49e70231b3766c https://github.com/phpmyadmin/phpmyadmin/commit/90f9e708cc6faca16a27b0d87f4… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-12-16 (Fri, 12 December 2022) -03:00 Changed paths: M ChangeLog M themes/bootstrap/scss/_icons.scss M themes/metro/scss/_icons.scss M themes/original/scss/_icons.scss M themes/pmahomme/scss/_icons.scss Log Message: ----------- Fix missing icon for collapse all button Fixes #17967 Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/localized_docs] 195949: Translated using Weblate (French)
by Marc Delisle 16 Dec '22

16 Dec '22

Branch: refs/heads/master Home: https://github.com/phpmyadmin/localized_docs Commit: 195949da6d94bd1ce7f08dcdd1923e452c07663e https://github.com/phpmyadmin/localized_docs/commit/195949da6d94bd1ce7f08dc… Author: Marc Delisle <marc(a)infomarc.info> Date: 2022-12-16 (Fri, 12 December 2022) +01:00 Changed paths: M po/fr.mo M po/fr.po Log Message: ----------- Translated using Weblate (French) Currently translated at 99.8% (2661 of 2665 strings) [ci skip]

1 0

[phpmyadmin/phpmyadmin] 63102c: Add unit test for Plugins\TwoFactor\Key::getRegistrations
by Maurício Meneghini Fauth 15 Dec '22

15 Dec '22

Branch: refs/heads/QA_5_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 63102c1253c57b49a00cca4c590529733598d445 https://github.com/phpmyadmin/phpmyadmin/commit/63102c1253c57b49a00cca4c590… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-12-15 (Thu, 12 December 2022) -03:00 Changed paths: A test/classes/Plugins/TwoFactor/KeyTest.php M libraries/classes/Plugins/TwoFactor/Key.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Add unit test for Plugins\TwoFactor\Key::getRegistrations Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] 3ff0dd: Remove invalid usages of htmlspecialchars()
by Kamil Tekiela 15 Dec '22

15 Dec '22

Branch: refs/heads/QA_5_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: 3ff0dd38d4c5c2e6b5b04c7290e71c97e46c5aec https://github.com/phpmyadmin/phpmyadmin/commit/3ff0dd38d4c5c2e6b5b04c7290e… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-15 (Thu, 12 December 2022) -03:00 Changed paths: M libraries/classes/Database/Qbe.php M psalm-baseline.xml Log Message: ----------- Remove invalid usages of htmlspecialchars() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> (cherry picked from commit 59ba203280be2299feebc304c60f08376e5850a0) Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] d57b95: Bump selenium/standalone-chrome docker image to latest v4
by Maurício Meneghini Fauth 15 Dec '22

15 Dec '22

Branch: refs/heads/QA_5_2 Home: https://github.com/phpmyadmin/phpmyadmin Commit: d57b955802b36a351eb2c4de369ac57fd110feb9 https://github.com/phpmyadmin/phpmyadmin/commit/d57b955802b36a351eb2c4de369… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-12-15 (Thu, 12 December 2022) -03:00 Changed paths: M .github/workflows/test-selenium.yml Log Message: ----------- Bump selenium/standalone-chrome docker image to latest v4 Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> (cherry picked from commit dc5450d4096ee06506cbcbcbf338cc97c0e82008) Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Commit: a5e81ad7d00e3da151ef32e173ba20ebfd933dae https://github.com/phpmyadmin/phpmyadmin/commit/a5e81ad7d00e3da151ef32e173b… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-12-15 (Thu, 12 December 2022) -03:00 Changed paths: M .gitignore Log Message: ----------- Ignore test/test_data/gis directory Related to 5116b0f0fe0ae6988123b02753b3d998e510d864. [ci skip] Signed-off-by: Maurício Meneghini Fauth <mauricio(a)fauth.dev>

1 0

[phpmyadmin/phpmyadmin] db5db2: Refactor Database Search (#17962)
by Kamil Tekiela 15 Dec '22

15 Dec '22

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: db5db26c60b14e5f36be73b8b93688a949b8778b https://github.com/phpmyadmin/phpmyadmin/commit/db5db26c60b14e5f36be73b8b93… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-15 (Thu, 12 December 2022) -03:00 Changed paths: M js/src/database/search.js M libraries/classes/Database/Search.php M phpstan-baseline.neon M psalm-baseline.xml M templates/database/search/main.twig M templates/database/search/results.twig M test/classes/Database/SearchTest.php Log Message: ----------- Refactor Database Search (#17962) * Refactor Search::getWhereClause() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Refactor Search::getSearchSqls() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Fix HTML escaping issues in Database search Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Change links to buttons More semantically correct, does not link to a separate page on middleclick, and looks better. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Refactor Search::getSearchResults() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Update psalm-baseline.xml Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Update phpstan-baseline.neon Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] 1e4af7: Refactor Plugins.php (#17960)
by Kamil Tekiela 14 Dec '22

14 Dec '22

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 1e4af774166adf7ce865163e563b0d0c6bc60022 https://github.com/phpmyadmin/phpmyadmin/commit/1e4af774166adf7ce865163e563… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) -03:00 Changed paths: M libraries/classes/Plugins.php M libraries/classes/Plugins/ExportPlugin.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Refactor Plugins.php (#17960) * Remove temporary variable Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Remove pass-by-ref Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Refactor getOneOption Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> * Refactor getOptions Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com>

1 0

[phpmyadmin/phpmyadmin] 47d9ad: Remove always false $_error
by Kamil Tekiela 14 Dec '22

14 Dec '22

Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: 47d9ad9b230029fa6de4d291701fc1f2e8a82807 https://github.com/phpmyadmin/phpmyadmin/commit/47d9ad9b230029fa6de4d291701… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Controllers/Database/OperationsController.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Remove always false $_error Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 99f37f4b7b3338b307e5272173baf75b6818adec https://github.com/phpmyadmin/phpmyadmin/commit/99f37f4b7b3338b307e5272173b… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Controllers/View/CreateController.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Remove redundant is_array check It's always array because of `if (empty($view['name']))` check Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 29a055b497ccf676bfc53170feef2a50e128f4d8 https://github.com/phpmyadmin/phpmyadmin/commit/29a055b497ccf676bfc53170fee… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Query/Utilities.php Log Message: ----------- Remove redundant cast during concat Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 8d06fda694e906b7dd263bf92ae7e28eb01a515b https://github.com/phpmyadmin/phpmyadmin/commit/8d06fda694e906b7dd263bf92ae… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/VersionInformation.php Log Message: ----------- Remove redundant operations These are noop anyway. Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 8d7e3e2229a20afbb4ff3ebb5d4eec8bb5e9565e https://github.com/phpmyadmin/phpmyadmin/commit/8d7e3e2229a20afbb4ff3ebb5d4… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Plugins/Export/ExportCsv.php Log Message: ----------- Simplified switch Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 9e795e27a137ddf983c32da2032d35ab88750084 https://github.com/phpmyadmin/phpmyadmin/commit/9e795e27a137ddf983c32da2032… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Config/Form.php M libraries/classes/Config/FormDisplay.php Log Message: ----------- Remove temporary variable $cf Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 1c51769b322ed8fbf86c0273c49faf2e5199b059 https://github.com/phpmyadmin/phpmyadmin/commit/1c51769b322ed8fbf86c0273c49… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Controllers/Table/FindReplaceController.php M psalm-baseline.xml Log Message: ----------- Simplify for statement into foreach Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: f1742824424de887b880611b09cab741d3aaa4a2 https://github.com/phpmyadmin/phpmyadmin/commit/f1742824424de887b880611b09c… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Controllers/Table/ZoomSearchController.php Log Message: ----------- Remove temporary var $column_names Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 7cc0fbcf56eb59c97fcc72885ff762bdacd1c6dd https://github.com/phpmyadmin/phpmyadmin/commit/7cc0fbcf56eb59c97fcc72885ff… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Database/Qbe.php M psalm-baseline.xml Log Message: ----------- Fix nullable arrays that should not be nullable Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 59ba203280be2299feebc304c60f08376e5850a0 https://github.com/phpmyadmin/phpmyadmin/commit/59ba203280be2299feebc304c60… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Database/Qbe.php M psalm-baseline.xml Log Message: ----------- Remove invalid usages of htmlspecialchars() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: ce0ee04406a3ef306cdc17850e813bf2e89a5ec5 https://github.com/phpmyadmin/phpmyadmin/commit/ce0ee04406a3ef306cdc17850e8… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Navigation/Nodes/NodeDatabaseChild.php Log Message: ----------- Remove temporary variables Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: e64bbe292621363e637255b7846cd4c597d4c5ad https://github.com/phpmyadmin/phpmyadmin/commit/e64bbe292621363e637255b7846… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Setup/Index.php M psalm-baseline.xml Log Message: ----------- Remove temporary var $releases Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0ae05160844ea7a8b968567b594fb57a7c402f73 https://github.com/phpmyadmin/phpmyadmin/commit/0ae05160844ea7a8b968567b594… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Table.php M psalm-baseline.xml Log Message: ----------- Refactor Table::countRecords() Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 1bb0e830c04e76e0ec29806d3fe905a4eca610aa https://github.com/phpmyadmin/phpmyadmin/commit/1bb0e830c04e76e0ec29806d3fe… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/Table.php Log Message: ----------- Remove temporary variables from Table Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 0f1b6ec51d873b50a8c8624b9e7355d05e4faa55 https://github.com/phpmyadmin/phpmyadmin/commit/0f1b6ec51d873b50a8c8624b9e7… Author: Kamil Tekiela <tekiela246(a)gmail.com> Date: 2022-12-14 (Wed, 12 December 2022) +00:00 Changed paths: M libraries/classes/TwoFactor.php Log Message: ----------- Remove temporary $backend var Signed-off-by: Kamil Tekiela <tekiela246(a)gmail.com> Commit: 08a27b8b7e983a02650679216738ca2f7a85d285 https://github.com/phpmyadmin/phpmyadmin/commit/08a27b8b7e983a0265067921673… Author: Maurício Meneghini Fauth <mauricio(a)fauth.dev> Date: 2022-12-14 (Wed, 12 December 2022) -03:00 Changed paths: M libraries/classes/Config/Form.php M libraries/classes/Config/FormDisplay.php M libraries/classes/Controllers/Database/OperationsController.php M libraries/classes/Controllers/Table/FindReplaceController.php M libraries/classes/Controllers/Table/ZoomSearchController.php M libraries/classes/Controllers/View/CreateController.php M libraries/classes/Database/Qbe.php M libraries/classes/Navigation/Nodes/NodeDatabaseChild.php M libraries/classes/Plugins/Export/ExportCsv.php M libraries/classes/Query/Utilities.php M libraries/classes/Setup/Index.php M libraries/classes/Table.php M libraries/classes/TwoFactor.php M libraries/classes/VersionInformation.php M phpstan-baseline.neon M psalm-baseline.xml Log Message: ----------- Merge pull request #17959 from kamil-tekiela/various-refactorings Various refactorings

1 0