February 2002 - Developers - lists.phpmyadmin.net

Re: [Phpmyadmin-devel] Site management with phpMyAdmin
by Loïc 24 Feb '02

24 Feb '02

Well, indeed some nice feature are lacking: > Maybe also a control mecanism to specify: > > - which users can use site management > - maximum number of databases per user :) > > And because the user has grant access to his dbs, he could use some > features of > our user management panel to allow access to other users. Isn't it? Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

1 0

[Phpmyadmin-devel] Site management with phpMyAdmin
by Marc Delisle 24 Feb '02

24 Feb '02

Hi, I just saw what is being done by some ISPs, maybe we could add this to phpMyAdmin, please comment. 1. The user authenticates himself (http or cookie mode). 2. We check in config if $cfgSiteManagement (or whatever) is allowed. 3. If allowed, we use stduser (or another account) with added privileges, to enable the user to create databases (with username_ as prefix), and we give all privileges to this user on this database. Maybe also a control mecanism to specify: - which users can use site management - maximum number of databases per user :) And because the user has grant access to his dbs, he could use some features of our user management panel to allow access to other users. This control mecanism could be implemented in the 'server config in database' feature. Marc

2 7

[Phpmyadmin-devel] Re: Ready for 2.2.4? - TS?
by Loïc 24 Feb '02

24 Feb '02

Hi Oli! >well, if the field is not empty, what about ignoring the >checkbox? This way the field would have priority over the >checkbox, and I would see it as quite logical... And you? :) Well as I just tell you in my previous post ;), it seems to me neither more, neither less logical since we can't know what is the last user action. Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

3 2

[Phpmyadmin-devel] Kanji encoding featured (for only japanese)
by luc 24 Feb '02

24 Feb '02

Hi, list I appended japanese kanji encoding conversion feature. New ./libraries/encoding.lib.php3 appended. The requirements are PHP"4" and mbstrings configured install. This patch and new ./lang/japanese-*.inc.php3. attach on.

1 0

[Phpmyadmin-devel] Re: Ready for 2.2.4? - TS?
by Loïc 24 Feb '02

24 Feb '02

Hi Olivier and List! Olivier, I'll have a look at the "NOW()" problem in the afternoon. >And other thing: if the field is not empty, shouldn't the >NULL Checkbox be ignored ? (in tbl_replace directely). If the browser does not support javascript, there is no way to know what is the last action the end user did : checking the "NULL" box or filling the field? Then, IMHO, both way to do (the current one or the one you suggested) are equivalent. Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

2 1

Re: [Phpmyadmin-devel] Re: [Patch] Parse error with 3.0.12
by Loïc 22 Feb '02

22 Feb '02

Hi again! Joshua I've commited your patch to the CVS tree. Could you test the script please ? Thanks, Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

1 0

[Phpmyadmin-devel] Re: [PATCH] Better InnoDB info.
by Loïc 22 Feb '02

22 Feb '02

Hi Joshua and List! Thanks for your patch, Joshua. I've just commited it to the CVS tree :) Please all, it would be nice to fully test it now (more than I can do myself). Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif

1 0

[Phpmyadmin-devel] [PATCH] Better InnoDB info.
by Joshua Nye 21 Feb '02

21 Feb '02

This patch rewrites the handling of row count and table size in db_details to more accurately deal with different table types such as InnoDB. It also re-enables the valid fields of size usage and row stats in tbl_properties for InnoDB tables. -Josh diff -r -u phpMyAdmin-2.2.4/db_details.php phpMyAdmin-devel/db_details.php --- phpMyAdmin-2.2.4/db_details.php Tue Feb 19 18:35:40 2002 +++ phpMyAdmin-devel/db_details.php Thu Feb 21 12:00:00 2002 @@ -237,51 +237,43 @@ </td> <?php echo "\n"; - $mergetable = FALSE; - $nonisam = FALSE; - if (isset($sts_data['Type'])) { - if ($sts_data['Type'] == 'MRG_MyISAM') { - $mergetable = TRUE; - } else if (!eregi('ISAM|HEAP', $sts_data['Type'])) { - $nonisam = TRUE; + + if(isset($sts_data['Rows'])) { + # MyISAM, ISAM or Heap table: Row count, data size and index size is accurate. + if(isset($sts_data['Type']) && ereg('^(MyISAM|ISAM|HEAP)$', $sts_data['Type'])) { + $tblsize = $sts_data['Data_length'] + $sts_data['Index_length']; + $sum_size += $tblsize; + list($formated_size, $unit) = PMA_formatByteDown($tblsize, 3, $tblsize > 0 ? 1 : 0); + $sum_entries += $sts_data['Rows']; + $display_rows = number_format($sts_data['Rows'], 0, $number_decimal_separator, $number_thousands_separator); } - } - if (isset($sts_data['Rows'])) { - if ($mergetable == FALSE) { - if ($cfgShowStats && $nonisam == FALSE) { - $tblsize = $sts_data['Data_length'] + $sts_data['Index_length']; - $sum_size += $tblsize; - if ($tblsize > 0) { - list($formated_size, $unit) = PMA_formatByteDown($tblsize, 3, 1); - } else { - list($formated_size, $unit) = PMA_formatByteDown($tblsize, 3, 0); - } - } else if ($cfgShowStats) { - $formated_size = ' - '; - $unit = ''; - } - $sum_entries += $sts_data['Rows']; + # InnoDB table: Row count is not accurate but data and index sizes are. + elseif(isset($sts_data['Type']) && $sts_data['Type'] == "InnoDB") { + $tblsize = $sts_data['Data_length'] + $sts_data['Index_length']; + $sum_size += $tblsize; + list($formated_size, $unit) = PMA_formatByteDown($tblsize, 3, $tblsize > 0 ? 1 : 0); + $display_rows = ' - '; } - // MyISAM MERGE Table - else if ($cfgShowStats && $mergetable == TRUE) { + + # Merge or BerkleyDB table: Only row count is accurate. + elseif(isset($sts_data['Type']) && ereg('^(MRG_MyISAM|BerkeleyDB)$', $sts_data['Type'])) { $formated_size = ' - '; - $unit = ''; + $unit = ''; + $sum_entries += $sts_data['Rows']; + $display_rows = number_format($sts_data['Rows'], 0, $number_decimal_separator, $number_thousands_separator); } - else if ($cfgShowStats) { + + # Unknown table type. + else { $formated_size = 'unknown'; - $unit = ''; + $unit = ''; + $display_rows = 'unknown'; } + ?> <td align="right" bgcolor="<?php echo $bgcolor; ?>"> - <?php - echo "\n" . ' '; - if ($mergetable == TRUE) { - echo '<i>' . number_format($sts_data['Rows'], 0, $number_decimal_separator, $number_thousands_separator) . '</i>' . "\n"; - } else { - echo number_format($sts_data['Rows'], 0, $number_decimal_separator, $number_thousands_separator) . "\n"; - } - ?> + <?php echo $display_rows . "\n"; ?> </td> <td bgcolor="<?php echo $bgcolor; ?>" nowrap="nowrap">  <?php echo (isset($sts_data['Type']) ? $sts_data['Type'] : ' '); ?>  @@ -291,24 +283,21 @@ echo "\n"; ?> <td align="right" bgcolor="<?php echo $bgcolor; ?>" nowrap="nowrap"> -    - <a href="tbl_properties.php?<?php echo $url_query; ?>#showusage"><?php echo $formated_size . ' ' . $unit; ?></a> +   <a href="tbl_properties.php?<?php echo $url_query; ?>#showusage"><?php echo $formated_size . ' ' . $unit; ?></a> </td> <?php - echo "\n"; - } // end if - } else { + } + } + else { ?> - <td colspan="3" align="center" bgcolor="<?php echo $bgcolor; ?>"> - <?php echo $strInUse . "\n"; ?> - </td> +<td colspan="3" align="center" bgcolor="<?php echo $bgcolor; ?>"><?php echo $strInUse . "\n"; ?></td> <?php } echo "\n"; ?> </tr> <?php - } + } // Show Summary if ($cfgShowStats) { list($sum_formated, $unit) = PMA_formatByteDown($sum_size, 3, 1); diff -r -u phpMyAdmin-2.2.4/tbl_properties.php phpMyAdmin-devel/tbl_properties.php --- phpMyAdmin-2.2.4/tbl_properties.php Tue Feb 19 18:35:42 2002 +++ phpMyAdmin-devel/tbl_properties.php Thu Feb 21 11:58:15 2002 @@ -484,10 +484,11 @@ // BEGIN - Calc Table Space - staybyte - 9 June 2001 if ($cfgShowStats) { $nonisam = FALSE; + $innodb = $showtable['Type'] == "InnoDB"; if (isset($showtable['Type']) && !eregi('ISAM|HEAP', $showtable['Type'])) { $nonisam = TRUE; } - if (PMA_MYSQL_INT_VERSION >= 32303 && $nonisam == FALSE) { + if (PMA_MYSQL_INT_VERSION >= 32303 && ($nonisam == FALSE || $innodb)) { // Gets some sizes $mergetable = FALSE; if (isset($showtable['Type']) && $showtable['Type'] == 'MRG_MyISAM') { @@ -613,7 +614,7 @@ </tr> <?php } - if (isset($showtable['Rows'])) { + if (!$innodb && isset($showtable['Rows'])) { $bgcolor = ((++$i%2) ? $cfgBgcolorTwo : $cfgBgcolorOne); echo "\n"; ?> @@ -625,7 +626,7 @@ </tr> <?php } - if (isset($showtable['Avg_row_length']) && $showtable['Avg_row_length'] > 0) { + if (!$innodb && isset($showtable['Avg_row_length']) && $showtable['Avg_row_length'] > 0) { $bgcolor = ((++$i%2) ? $cfgBgcolorTwo : $cfgBgcolorOne); echo "\n"; ?> @@ -637,7 +638,7 @@ </tr> <?php } - if (isset($showtable['Data_length']) && $showtable['Rows'] > 0 && $mergetable == FALSE) { + if (!$innodb && isset($showtable['Data_length']) && $showtable['Rows'] > 0 && $mergetable == FALSE) { $bgcolor = ((++$i%2) ? $cfgBgcolorTwo : $cfgBgcolorOne); echo "\n"; ?>

1 0

[Phpmyadmin-devel] [Patch] Parse error with 3.0.12
by Joshua Nye 21 Feb '02

21 Feb '02

Fixes a parse error with PHP 3. I'm using 3.0.12. Might happen in other versions. -Josh --- ../../phpMyAdmin-2.2.4/libraries/display_tbl.lib.php3 Sun Feb 10 04:29:50 2002 +++ display_tbl.lib.php3 Thu Feb 21 09:57:40 2002 @@ -662,7 +662,8 @@ * * @see PMA_displayTable() */ - function PMA_displayTableBody(&$dt_result, &$is_display, $map = array()) + + function PMA_displayTableBody($dt_result, $is_display, $map) { global $lang, $server, $db, $table; global $goto;

1 1

[Phpmyadmin-devel] Re: [PATCH] Fix incorrect row count in db_details.php
by Joshua Nye 21 Feb '02

21 Feb '02

This removes from the total sum of rows the incorrect row counts from any tables that aren't ISAM/MyISAM/Heap. -Josh [root@lars htdocs]# diff -u phpMyAdmin/db_details.php phpMyAdmin-new/db_details.php --- phpMyAdmin/db_details.php Wed Feb 20 16:40:22 2002 +++ phpMyAdmin-new/db_details.php Thu Feb 21 08:09:55 2002 @@ -257,11 +257,11 @@ } else { list($formated_size, $unit) = PMA_formatByteDown($tblsize, 3, 0); } + $sum_entries += $sts_data['Rows']; } else if ($cfgShowStats) { $formated_size = ' - '; $unit = ''; } - $sum_entries += $sts_data['Rows']; } // MyISAM MERGE Table else if ($cfgShowStats && $mergetable == TRUE) { ----- Original Message ----- From: Joshua Nye To: phpmyadmin-devel(a)lists.sourceforge.net Sent: Wednesday, February 20, 2002 4:40 PM Subject: [PATCH] Fix incorrect row count in db_details.php I noticed that my row count displayed was incorrect for InnoDB tables as opposed to a SELECT COUNT(*). --Josh --- ../phpMyAdmin/db_details.php Tue Feb 19 18:35:40 2002 +++ db_details.php Wed Feb 20 16:37:13 2002 @@ -278,8 +278,10 @@ echo "\n" . ' '; if ($mergetable == TRUE) { echo '<i>' . number_format($sts_data['Rows'], 0, $number_decimal_separator, $number_thousands_separator) . '</i>' . "\n"; - } else { + } elseif($nonisam == FALSE) { echo number_format($sts_data['Rows'], 0, $number_decimal_separator, $number_thousands_separator) . "\n"; + } else { + echo "-"; } ?> </td>

1 0