Hi devs,
As discussed during the last team meeting, I did some profiling to evaluate
the performance of 4.4 series against 3.5 series. I used xdebug for
profiling and for each of the pages evaluated, I averaged among three
reading to overcome any errors.
The values are in milliseconds and contains profiling overhead as well.
However, this should not be a problem to compare between two versions.
Page 3.5 branch 4.4 branch 4.4 / 3.5 Table browse
5230.67 24548.67 4.69 Table structure 2974.67 8060.67 2.71 Table SQL
760.33 1770.33 2.33 Table operations 2564.33 7626.33 2.97 Row edit 2012
10980.67 5.46 Row insert 2387.67 11553 4.84 Database structure 6280.33
5076.33 0.81 Database SQL 1511.67 1570 1.04 Database operations 3115.33
2750.67 0.88 Server databases 2108 3068.67 1.46 Navigation refresh 626
4092.33 6.54
While I got mixed results where for certain pages 3.5 was faster and for
others 4.4 was faster, for most of the pages 3.5 was much faster.
I am attaching the results in csv format as well as output files from
profiling. With KCacheGrind or WinCacheGrind you should be able to further
analyze the profiling results.
--
Thanks and Regards,
Madhura Jayaratne
Hi, recently I've been seeing a lot of Scrutinizer failures such as[0].
It fails at stage
> Waiting for External Code Coverage
With error message:
> The code coverage data was not received within the specified time.
> Please make sure your third-party service is configured to send code
> coverage data.
And additional information:
> Code coverage data is not yet available.
> Code Coverage was not sent to Scrutinizer.
> Make sure that you have set-up your external service correctly.
> You can find more information on this in the documentation:
>
> https://scrutinizer-ci.com/docs/tools/external-code-coverage/
>
> If you need help you can also email support(a)scrutinizer-ci.com.
Does anyone have any idea about this? I couldn't really find any
information about this particular message online.
0 -
https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/inspections/1a2ea9a8-fcf…
Hi,
Deven has done nice work on the print view[0] pull request but we've hit
a bit of a grey area with regards to what to do with a view count. In
the database structure page, in the standard "screen-based interface" we
provide an approximate row count for a view and the user can click on
the row count to get an exact number.
With print view, we could handle this in a couple of ways, each of which
has a tradeoff. I think these are the two that I find most appealing.
1) We could only provide an approximate count. This is programmatically
easiest and provides instant results, but might frustrate some users.
2) We could provide an exact count, computed when the user presses the
print button. We should probably display a dialog during the counting
such as "Getting an exact count for views, the print dialog will appear
once the MySQL server is done counting." A shortcoming is that the count
would only be triggered by the "Print View" link, not when they use
their print function of the browser. Users with many complex views may
not care about an exact count and may want a quick print dialog, so we
might need to provide yet another configuration directive about this.
How does the rest of the team feel about this?
0 - https://github.com/phpmyadmin/phpmyadmin/pull/1708
Hi GSoC students,
I just fixed the last of failing tests in
PMA_Tracker_Test::testChangeTrackingData. Curiously, this did not fail
on my machine but Travis complained about it in a lot of pull requests.
Anyway, you can rebase your feature branches to current master, if the
only failing test in your pull request was this one.
--
Marc Delisle | phpMyAdmin
I'm curious about this line:
if (PMA_MYSQL_INT_VERSION >= 20120130)
from libraries/Types.class.php [0], initially added with this commit [1].
That version number doesn't make sense to me. This code snippet deals
with Drizzle, which apparently [2] had versions like this at one point,
but I'm not sure whether those are production releases or development
versions. Regardless, they use more standard version numbers now, such
as 7.1. I wonder if this code should be updated.
Any thoughts about this?
0 -
https://github.com/phpmyadmin/phpmyadmin/blob/3ada00030f7b1f045422a4e80a1fd…
1 - d3b1b9f9a2776748dbfe0dd57c77e5ee1b0455fc Support for Drizzle IPV6
column type in Fremont Added SCHEMA function (synonym for DATABASE)
2 - https://www.google.com/search?q=drizzle%2020120130&gws_rd=ssl
I'm having a little trouble testing for a particular version.
It's easy to test for MySQL:
> if (PMA_MYSQL_INT_VERSION < 50603) {
But I also need to test for MariaDB version 10.0.12. I don't see a
constant PMA_MARIADB like there is PMA_DRIZZLE so I'm stuck on how to
test for a specific MariaDB version. Any hints?
See <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/9695/changes>
Changes:
[Madhura Jayaratne] bug #4872 Drop table doesn't remove the table name from navigation bar
------------------------------------------
Started by GitHub push by madhuracj
[EnvInject] - Loading node environment variables.
Building in workspace <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url git://github.com/phpmyadmin/phpmyadmin.git # timeout=10
Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git
> git --version # timeout=10
> git -c core.askpass=true fetch --tags --progress git://github.com/phpmyadmin/phpmyadmin.git +refs/heads/*:refs/remotes/origin/*
> git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 8fa3680da8484face44ffb028049322c4247d53f (origin/master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 8fa3680da8484face44ffb028049322c4247d53f
> git rev-list 478a3b47842af7de64e74adc9002c814a430781b # timeout=10
> git tag -a -f -m Jenkins Build #9695 jenkins-phpMyAdmin-continuous-9695 # timeout=10
[EnvInject] - Executing scripts and injecting environment variables after the SCM step.
[EnvInject] - Injecting as environment variables the properties content
TESTSUITE_SERVER=localhost
TESTSUITE_USER=pmatest
TESTSUITE_DATABASE=pmatest
TESTSUITE_URL=http://ci-live.phpmyadmin.net/phpMyAdmin-continuous/workspace/
XTESTSUITE_BROWSERSTACK_USER=michaliha
[EnvInject] - Variables injected successfully.
[workspace] $ /bin/sh -xe /tmp/hudson4664836610025028786.sh
+ composer install --dev --no-interaction
You are using the deprecated option "dev". Dev packages are installed by default now.
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files
[workspace] $ ant ******** ******** clean locales phpunit-nocoverage phpcpd phpcs phploc jshint jshint-checkstyle
Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-7-openjdk-amd64/lib/tools.jar
Buildfile: <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml>
clean:
[delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api>
[delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser>
[delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage>
[delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs>
[delete] Deleting directory <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend>
[mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api>
[mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser>
[mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage>
[mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs>
[mkdir] Created dir: <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend>
locales:
[exec] po/ro.po:706: a format specification for argument 1 doesn't exist in 'msgstr'
[exec] msgfmt: found 1 fatal error
[exec] tput: No value for $TERM and no -T specified
[exec] Error when compiling po/ro.po
[exec] tput: No value for $TERM and no -T specified
BUILD FAILED
<https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml>:148: exec returned: 1
Total time: 8 seconds
Build step 'Invoke Ant' marked build as failure
[CHECKSTYLE] Skipping publisher since build result is FAILURE
[JSLINT] Skipping publisher since build result is FAILURE
[DRY] Collecting duplicate code analysis files...
[DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml
[DRY] Computing warning deltas based on reference build #9692
[TASKS] Skipping publisher since build result is FAILURE
[ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #9692
Recording plot data
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing PHPUnit-3.x (default)
[xUnit] [INFO] - [PHPUnit-3.x (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.x (default)'?
[xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?.
[xUnit] [INFO] - Failing BUILD.
[xUnit] [INFO] - There are errors when processing test results.
[xUnit] [INFO] - Skipping tests recording.
[xUnit] [INFO] - Stop build.
Hi,
RFE #701 proposes that we should replace the 'Print View' and 'Print View
(with Full Texts)' with a 'Print View' Option which should print out the
CSS of the page only (i.e. whatever exactly is currently displayed on the
page itself).
*I had something in mind about the implementation, but am not able to
figure some details. Any help in this regard would be appreciated. *
*Details of implementation:*
On clicking the 'Print View' link, it will call a click-handler JQuery
function which will get the HTML for the table from the current page,
traverse through the HTML.
Then, make a JSON of relevant information such as SQL Query, No. of Rows,
Column Heads and then arrays of values in each row *for SQL results* and
information such as Table Name, Rows, Type, Collation, Size, Overhead,
Comment for *db_structure.php and tbl_structure.php*.
Now, send a POST Request to a PHP file and get the $response (PMA_Response)
after making a output with good-looking table and other details and the
'Print' Button.
The main problem I am facing here is that, how should I output the
$response ?
I thought of a very-unlike-PMA way:
Open a new tab with JS and add HTML to it as
var w = window.open();
$(w.document.body).html($html);
But here I guess there will be difficulty to use PMA_Response with its
headers(and do I actually need to use PMA_Response or can I just print the
$html_output recieved from PHP file).
or Can I somehow use 'target="print_view" ' and get the $response to be
shown onto it ?
Also, please suggest any flaws/ possible problems that I may have missed or
if you would suggest a different way.
Thanks.
--
*Regards,Deven G. Bansod*
* <f2012316(a)pilani.bits-pilani.ac.in>*