On 24 Mei 2011, at 18:56, Piotr Przybylski <piotr.prz(a)gmail.com> wrote:
> 2011/5/24 Aris Feryanto <aris_feryanto(a)yahoo.com>:
> Remember that when storing data per table you will have to set some
> upper limit, or you may have data in which half of the tables don't
> exist. Limiting eg. to 100 takes care of dealing with removed tables -
> after some time you will just "forget" about them (they get pushed out
> of saved table list).
Thank you for the good suggestion, Piotr. I will limit the records if I store them per table.
pmahomme currently has misaligned checkboxes in fieldsets (i can see
this in opera, chrome and ie):
Can we fix this? The best solution I can think of is to remove the
float of '.formelement' Elements, and instead add 'display:inline'.
For correct text-reading-direction however, we would need to put a
<div> element around such form element groups then that contain the
'float: <?php echo $left; ?>;'. For the SQL Query page we could reuse
Unfortunately it would require changes in quite a bunch of files
(which I don't know what they do yet).
The result would be:
I started coding for GSoC yesterday, since I need Monday off for a
college exam. I pushed the changes that I did to my repo , and they
are available for you to try on my demo server  (There are some
routines and triggers in the sakila db, but you'll have to add your own
events). Well, first of all I'd appreciate any feedback from you guys
regarding what I did. Which was: adding tabs for routines, triggers,
events; moving there the functionality that was already available;
getting export and drop options to work properly. However I have a
problem with the "Drop" option that doesn't redirect the user back to
where he came from after deleting the requested object. I tried adding a
"goto" variable to $urlquery, but by the time that the user is taken to
sql.php, "goto" simply disappears. I'm not sure what I'm missing. Any
Since I always have a love for details, here's 3 small suggestions
that maybe can be merged into the master branch. They are all pushed
to my fork (http://repo.or.cz/w/phpmyadmin/tyronm.git):
- Commit a0302c666c1bf9f9715364a6301238b474aedac1
Removes timepicker.js. It is already included with the jquery ui. The
file was included only in tbl_change.php and tbl_select.php
- Commit b161f43ec9089e0d2d5fb8a619056e6f9577a380
When reloading (flushing) privileges on the privileges tab you get a 5
second long success message. This commit omits the success message and
removes the loading message as soon as the ajax request is done. This
behavior seems more consistent with my patch in April that removes
messages once the ajax request is completed.
- Commit 99775c9bad552aac8b904996d673f1023821ab13
Removes the initials table on the privileges tab if there is 20 or
less privileges to show. With 1-20 privileges you can easily see all
host names and don't need any filtering by initials imo. I would even
increase that limit to 30 or so.
I'd like to merge some of the server pages, so that we have a smaller
menu and less links ending up in the 'More' tab.
What I have done already is put the processes table into the status
page as it fits very well into the server traffic (jquery-)tab.
And secondly I would merge together Engines, Charsets, Replication and
Variables into a (jquery-)tab-separated page named "Configuration"
Since an average user rarely requires the information supplied on
those pages I think it is a good idea to free up the space in the menu
bar. Any objections on this? :)
I started working on improving the "*Add a new user in db-> privileges*" by
providing a dialog such as in "*Add a new user in Server->privilege*"
In that case I'm going to reuse the code in "(#fieldset_add_user).click"
action in server_privileges.js file. The only modification I had to do is
add the class="ajax" to link on db->privileges and now it pops up the dialog
The next part is, after adding a new user we have to add that user to the
list table in db->privileges and then sort it according to the alphabetical
order of user names. In server->privileges, "*appendNewUser() in
server_privileges.js" *method has used and it is sorting the rows be
selecting the first character in the label and then according to that. It is
okay because server->privileges table has same type of rows. But in "*
db->privileges*" table it has used two type of rows where one shows columns
related to "global" privileges and other is to database specific privileges
corresponding to each user. So I cannot use the same "*appendNewUser() in
server_privileges.js"* method to add and sort the table. I came up with some
approaches to overcome this problem.
1. Change the table structure where do not use two rows but use same row
and line break to get them down. In this case I'll be able to reuse the same
method where I think more appropriate in this case.
2. Do a refresh to the "*db->privileges*" page so it reloads the table.
3. Keep the table as it is in current and develop a method to sort it.
I'm confused with what method to use. So please can you clarify me on this
problem. Thank you.
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog : http://coders-view.blogspot.com/
In commit add6c6325c , you dropped MySQL from the collation and
Both strings seem a bit confusing now, I would replace 'MySQL' to
'Server' or 'Database', or make the 'MySQL' prefix conditional (and
replace it by 'Drizzle' in case of Drizzle), like you did with the
heading of the server info section.
I've added now a first version of my planned realtime charting on the
status page in the 'Query statistics'-Tab (click on "Realtime chart").
You can check it out at http://demo.phpmyadmin.net/gsoc-tyron
Currently it aggregates the average queries per second by making an
ajax request every 2-2.5 seconds (2 seconds + time for one ajax
request). Since it is using the differential of the status var
'questions' it takes some seconds to display a line.
For the chart I'm currently using Highcharts because it allows
realtime data, animates beautifully, is really small (1 file, 77kb
minified) and has a export to png/pdf/jpg plugin (6.4kb minified)
which however uses a highcharts.com server for the conversion.
Some radical suggestion in this regard: What about removing the
included pChart and instead using a client-side charting library? I
know for some part its bad since a student wrote a whole lot of code
for it just last year, but looking at some requirements for phpmyadmin
(no file storage, limited possibilities for data recording,
panning/zooming, realtime updates) a server-side charting library
offers much less possibilities compared to a client side-one. And if
we'd use highcharts it would save us like 16 files and 750kb (well
most of it is that dejavu font).
I think it would be pretty easy to replace actually. Instead of the
graph, the server-code would just need to send the already generated
chart data hidden in the document and then we add a bit of js code to
display the chart. Some code from chart.lib.php is probably reusable.
Please let me know what you think and whether I should continue
working in this direction. Thanks! :)
My first task is to have an interface for input criteria. We discussed
earlier to make use of table search page or multi-table query generator for
this. I was hoping for some comments regarding this.
The aim is to let the user select *exactly two* columns(along with some
criteria) from a table. I prefer the table search page, it is less
complicated ( simple form, advanced options ). Also we do not need to
consider columns from multiple table so table search page will be more
focused. But the selection also depends on where all we want to put the
option of "Zoom search" in phpMyAdmin. So should this feature be a separate
component or should it be available on table search page/ multi-table query
generator (or both) ?