As you may recall from the last IRC meeting, I'm working on testing and
documentation around issue #6137  by removing some
features/plugins/libraries and testing/documenting my success.
So far I've had good luck with removing some things (for instance
tcpdf), but I've discovered two noteworthy problems.
1) When js/jqplot/ is removed, "Status -> Query statistics" does not
fail gracefully, it instead offers to submit a report to the error
2) when libraries/gis/ is removed, "Visulize GIS data" does not fail
gravefully, instead it gets stuck on saying "Loading..."
In comparison, something that degrades very well is the removal of
tcpdf; if the pdf library is missing the export dialog simply doesn't
show PDF as an export type.
So my question is what you think we should do about this -- this is
clearly beyond the scope of what is normally expected; it's not normal
for a user to remove libraries and code, but in order for this feature
request to be improved I think the code should handle this better.
Should we spend time on this?
0 - https://github.com/phpmyadmin/phpmyadmin/issues/6137
Hi Madhura and Atul,
I was looking at indexAction() in DatabaseStructureController.class.php,
which is 566 lines. I find it too long to be manageable, and PMD agrees .
Do you consider this method a work in progress? Does MVC mandate that
indexAction() should remain that size?
Marc Delisle | phpMyAdmin
after reading https://github.com/phpmyadmin/phpmyadmin/issues/11597 and
looking at PMA_checkRequiredPrivilgesForAdjust() I am convinced that
this function needs caching.
Can you have a look at PMA_analyseShowGrant() and see how we use these
Marc Delisle | phpMyAdmin
Mine is different from #6068 and #6207 . It is not related to a navigating
around the tables or changing ctrl + enter for query execution.
Mine works like as follows :
Ctrl + d-- takes you to databases.
Ctrl + s-- opens the console
Ctrl + u -- opens users
Ctrl + e -- export database
.... and so on.
And there will be another key that will enable or disable the shortcuts.
Say "ctrl + k". So that any time user want to disable the shortcut can
switch back and forth to the feature.
On Oct 17, 2015 4:40 PM, "Deven Bansod" <devenbansod.bits(a)gmail.com> wrote:
> Hi Abhishek,
> On Sat, Oct 17, 2015 at 3:34 PM, Abhishek Kanojia <
> abhishekka3193(a)gmail.com> wrote:
>> Hi ,
>> I have an idea of implementing shortcut keys to phpmyadmin, which is
>> what i am currently working on.
>> Benefits of shortcut keys:
>> 1. Ease of access
>> 2. Keyboard shortcut allows to work faster then simple navigating
>> through the link.
>> 3. Improves User Interaction with the application.
>> Need some suggestions on this .
> phpMyAdmin already has some of the shortcuts like Ctrl/Alt + Arrow keys
> moving across the editable table cells (grid edit) (implemented for issue
> #6068 <https://github.com/phpmyadmin/phpmyadmin/issues/6068>)
> or 'Ctrl + Enter' for submitting the 'Insert Row' (on tbl_change.php)
> Another recent issue that was implemented for usability improvement was :
> #6207 <https://github.com/phpmyadmin/phpmyadmin/issues/6207>
> Though these ones are already closed, you can take a look at these for
> or even find some more in the issue tracker.
> Anyways, what type of keyboard shortcuts do you have in mind ?
> Could you give an example?
> Deven Bansod
> * <f2012316(a)pilani.bits-pilani.ac.in>*
> Developers mailing list
I have an idea of implementing shortcut keys to phpmyadmin, which is
what i am currently working on.
Benefits of shortcut keys:
1. Ease of access
2. Keyboard shortcut allows to work faster then simple navigating
through the link.
3. Improves User Interaction with the application.
Need some suggestions on this .
Q.1 Is there any specific function defined for redirection of link
using ajax ? Just working on a new feature stuck at point where
redirection is to be made .I would like to know the name of function
and its usage already defined for ajax redirection from one link to
Q.2 For redirecting from one page to another say (from index.php to
db_sql.php) , the parameters passed in url are "db","table", "server"
and "token". I am able to access token parameter from session. how to
access other parameters ?
Q.3 How to display dismissible alert (the one that is used to display
a change in row) ?
included in each and every page ? I am using common.js file for this
The following PR is trying to use namespaces and autoloading for pMA:
This PR seems to be quite stable now. As almost all PHP files had been
updated, this is a huge work to test all cases, all configurations, all
features. Would it be possible to have some testers please?
Thanks to Marc and Isaac who already did a lot of tests.
And thanks to new testers.
Have a nice day,