Hi,
What would you think about using the "nesting level" sniff please?
This sniff permits to detect when there are too much nested levels like:
if (...) {
if (...) {
if (...) {
if (...) {
if (...) {
....
}
}
}
}
}
This kind of syntax often means that a refactoring is needed or a rewrite.
I can add it myself if you agree.
Thanks,
Hugues.
Hi,
I'm working on a bug [0]. The solution I'm trying is:
- use display:none on the throbber
- temporarily replace the navi reload image with the throbber image
My problem is that the reloading operation is so fast (less than one
second) that I cannot see the throbber image. When I add an alert just
before putting back the reload image, I have the proof that the throbber
image is there.
So, how can I ensure that the throbber image stays there at least, say,
one or two seconds? I tried with setTimeout() to no avail.
[0] https://sourceforge.net/p/phpmyadmin/bugs/3920/
--
Marc Delisle
http://infomarc.info | http://phpmyadmin.net
Hi,
My name is Mohit Goyal and I am a 3rd year undergraduate in BITS Pilani
K.K. Birla Goa Campus. I am new to the open-source community and thought I
would start with PHPMyAdmin as I have used it in projects before.
To start understanding the codebase, I thought I would start with one of
the bugs listed. The bug I started with was *Bug #4184 Switch to Wrong Page
After Adding Index* : https://sourceforge.net/p/phpmyadmin/bugs/4184/
While trying to figure out the issue, I did the following :
In libraries/structure.lib.php, in lines 1835 - 1845 ( in function -
PMA_getHtmlForActionRowInStructureTable() )
Removed line : ($hasLinkClass ? 'class="ajax add_primary_key_anchor" ' : '')
Added Line : 'class="ajax" '
As a result, I am getting a javascript function that enables editing of
the index ( adding names and comments etc. ). I have also attached a
screenshot for the same. The indexes are being added and the original issue
of switching back to the wrong page is solved.
However, I think that this particular functionality had been disabled
initially as the function had been pre-written. Can anybody please shed
some light on this ?
Thanks
Warm Regards,
Mohit Goyal | +918600046760
BITS-Pilani Goa Campus
Hi,
I wrote a few Selenium tests during my GSoC this year and I would like to help integrate it with our continuous integration server. Michal told me a new CI server was being set up. Can we have some inputs on how do we go about it, i.e, running Selenium tests on BrowserStack with our CI builds?
Thanks!
--
Ayush Chaudhary