I don't find a winning solution so I'm seeking for advice. In this bug
report , we see that it's annoying to have incorrect page navigation
(page selector and arrows) for InnoDB.
However, when I apply my proposed patch (which forces an exact count in
sql.php), I see delays for larger InnoDB tables.
For example, on MySQL 5.5.31, the first time I browse a table having one
million rows, I wait for 9 seconds. I tried with 0.5 million and it was
about 5 seconds. A few minutes afterwards, even after closing the
browser, my big table starts to display in two seconds.
I tend to find these delays acceptable and I propose to apply my patch.
Currently all variables that store proxy credentials have the prefix
'VersionCheck' assuming because this was the only part of phpmyadmin
that uses these variables. However I also require those variables in
my error reporting code and I did not want to use the same variable
names since it is a misnomer at that point.
I renamed the variables and removed all the VersionCheck prefixes so
they became ProxyUrl, ProxyUser and ProxyPass. I made the changes in
the version_check.php code and in the docs.
I just wanted to inform you of this change since this may affect
others once the error reporting system is merged with master
I don't understand why I have different results when running phpunit on
the ayushchd/unit_testing branch (5 failures) and on the master branch
(with Michal's merge 10 minutes ago), which gives me 16 failures.
I have been doing some tests to find places to improve my error
collection strategy. It seems that all the browsers get confused as to
where the error occurs, when the file containing the error is loaded
using ajax navigation. The same error if it occurs in files loaded
normally by the browser shows a proper stacktrace, however if it
occurs in files that are loaded by the AJAX class it shows a useless
stacktrace missing the actual part of the code where the error occurs.
This occurs not due to my error reporting code since I removed it
entirely during testing and it occurs consistently across browsers. I
am not sure what is the best course of action here it seems that the
problem occurs due to problems in how the browser handles stacktraces
I'm reviewing Kasun's pull request for the search and replace
functionality and realize I'm not sure what the procedure is for
adding new images.
The wiki documentation  is pretty thorough except for one question;
when do we actually run the script? My understanding is that any time
a new icon is added, the developer would run the generate-sprites
script and commit the resulting sprite file. Is that correct?
1 - http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage
I was setting up some unit tests when I came across the function PMA_Util::sqlAddSlashes() Isn't it supposed to add slashes to single quotes? Because I tested this:
And the output was pma_''db
Is this the correct behaviour?