August 2012 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] tbl_operations refactoring
by Marc Delisle 08 Aug '12

08 Aug '12

Thilina, Please create bug artifacts (this was tested with 4645c5a342c419165c5f5ec96942069cdfcd4c3b): - Using the "Alter table order by" dialog and clicking on Go, the confirmation message is very weird - After trying to change the storage engine, the engine is not changed and I see this weird text 'checked="checked" checked="checked"' -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] FAO: Alex - warnings in plugin interface
by Michal Čihař 07 Aug '12

07 Aug '12

Hi Alex whenever going to export page, I get dozen of warnings like: Notice in ./libraries/plugin_interface.lib.php#249 Undefined variable: properties Maybe you don't have enabled displaying of errors as documented at: http://wiki.phpmyadmin.net/pma/Developer_guidelines http://wiki.phpmyadmin.net/pma/Config#Error_Handler -- ` Michal Čihař | http://cihar.com | http://blog.cihar.com

2 2

[Phpmyadmin-devel] db_operations refactoring: copying a db having a view
by Marc Delisle 05 Aug '12

05 Aug '12

Hi Thilina, please create this bug artifact: in Thilina's tree, it's not possible to copy a database having a view. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] Thilina's refactoring
by Marc Delisle 05 Aug '12

05 Aug '12

Thilina, with commit 8625fc6edd06fdfa5a8bb79e2bc7a78aa7cdc921, on the db operations page, I get 3 problems. Notice in ./libraries/plugins/export/ExportSql.class.php#180 Undefined index: export_type Backtrace ./libraries/plugins/export/ExportSql.class.php#29: ExportSql->setProperties() ./libraries/plugin_interface.lib.php#34: ExportSql->__construct() ./db_operations.php#78: PMA_getPlugin( string export, string sql, string libraries/plugins/export/, array, ) Notice in ./libraries/plugins/export/ExportSql.class.php#222 Undefined index: export_type Backtrace ./libraries/plugins/export/ExportSql.class.php#29: ExportSql->setProperties() ./libraries/plugin_interface.lib.php#34: ExportSql->__construct() ./db_operations.php#78: PMA_getPlugin( string export, string sql, string libraries/plugins/export/, array, ) Warning in ./libraries/operations.lib.php#390 Missing argument 3 for PMA_getViewsAndCreateSqlViewStandIn(), called in /opt/pma-git/phpmyadmin/db_operations.php on line 86 -- Marc Delisle http://infomarc.info

2 2

[Phpmyadmin-devel] FAO: Thilina. Bad ajax response when adding a user without a host
by Rouslan Placella 04 Aug '12

04 Aug '12

Hi Thilina, In the master branch, if you add a user without specifying a host, an invalid ajax response is generated. This causes a bug, where you cannot stright away delete that user without refreshing the page (and in the displayed table the host part is missing). I don't know how the mechanism for adding users works, but the attached patch fixed the issue for me. Bye, Rouslan

3 6

[Phpmyadmin-devel] Duplicate forms
by Rouslan Placella 04 Aug '12

04 Aug '12

Hi all, Quick question: why do we have two forms for renaming a table on tbl_operations.php? Can one be dropped? Please see attached screenshot for the location of forms. Bye, Rouslan

4 12

[Phpmyadmin-devel] FAO: Alex. Internal server error on db import
by Rouslan Placella 04 Aug '12

04 Aug '12

Hi Alex, In current master, I'm getting an error 500 when attempting to open the db import page. I'm directing this message at you because git-bisect tells me that the first bad commit is authored by you: > 9458f9d06263822558d39e2a52fabafe40259bf1 is the first bad commit > commit 9458f9d06263822558d39e2a52fabafe40259bf1 > Author: Alex Marin <alex.ukf(a)gmail.com> > Date: Tue Jul 17 13:32:13 2012 +0300 > > oop: integrate the properties system for ExportXml > > :100644 100644 d638f218d68eb724c7e2c41988362e5c1f7bc38a abe366d99f7495de01b9dbab5a49bfd2b09dca73 M export.php > :040000 040000 e07908b1daaf9513c33fb15e4b41898082e82aad a06b315383a331b71d18cb673d3aba5cd63554a4 M libraries Also, please see the attached screenshot. Bye, Rouslan

3 4

[Phpmyadmin-devel] phpMyAdmin 3.5.2.1 is released
by Marc Delisle 03 Aug '12

03 Aug '12

Welcome to phpMyAdmin 3.5.2.1, a minor security release. Please refer to the upcoming PMASA-2012-3 announcement on http://www.phpmyadmin.net/home_page/security. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Allow specifying mime types and transformations in queries
by Chanaka Dharmarathna 02 Aug '12

02 Aug '12

Hi Michal, I'm trying to implement titled feature. [0] In current PMA, mime type transformations sometimes not working properly if the query is selecting only field with transformation. Sometime means, if the row data string is more lengthy, data is not transformed as expected. (data with string length > 1000) Due to that, where clause for linking a image (as example) is not setting. (comparison data is too heavy) If I use manually where clause, this will display properly. So as I think this can fix for only tables with primary key/unique key other than the field with transform. So that there may be a possibility to create where clause by executing sql (which related to display only field with transformation) with modification for retrieve both primary/unique key field and the relevant field and display only the relevant field with setting where clause properly. Any thoughts on this ? [0] : http://sourceforge.net/tracker/index.php?func=detail&aid=3112137&group_id=2… Regards ! *Chanaka*

1 1

[Phpmyadmin-devel] FAO: Michal. Dealing with merge conflicts in po files
by Rouslan Placella 02 Aug '12

02 Aug '12

Hi Michal, I just had a conflict while merging QA_3_5 into master and I wasn't sure how to resolve it. The problem was the po file for Catalan language that was heavily modified in d72f329301c28d222facce53e3da67deeb41b782. So, the first question is: why didn't Weblate merge QA_3_5 into master after committing? And if it didn't merge because of the conflicts, then why did it commit and push something that cannot be automatically merged in the first place? And the second question is: what is the correct thing to do when something like that happens? What I did was discard all the changes in that l10n file from the QA_3_5 branch, although I'm not sure if this might have any implications (losing some translated strings?)... Bye, Rouslan

2 2