Developers January 2014

developers@phpmyadmin.net

18 participants
38 discussions

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #5089
by michal＠cihar.com 06 Jan '14

06 Jan '14

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/5089/changes> Changes: [marc] bug #4217 Current value not highlighted when browsing foreign values ------------------------------------------ [...truncated 95 lines...] [exec] This test has not been implemented yet. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Conf…>:956 [exec] [exec] 2) PMA_DisplayResults_Test::testGetTableNavigation with data set #0 (21, 41, '123', false, '310') [exec] Not yet implemented! [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Disp…>:438 [exec] [exec] 3) PMA_AuthenticationCookie_Test::testBlowfishDecrypt [exec] Not testing mcrypt support [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/a…>:1104 [exec] [exec] 4) PMA_WhichCrlf_Test::testWhichCrlf [exec] Cannot redefine constant [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/common…>:41 [exec] [exec] 5) PMA_TblColumnsDefinitionFormTest::testGetFormParamsForOldColumn [exec] Not yet implemented! [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_tb…>:1101 [exec] [exec] 6) Environment_Test::testSession [exec] No session testing [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/Environment_test…>:83 [exec] [exec] -- [exec] [exec] [exec] There were 38 skipped tests: [exec] [exec] 1) PMA_FormDisplay_Test::testSetComments [exec] Cannot redefine constant [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/config/P…>:405 [exec] [exec] 2) PMA_DBI_Mysql_Test::testMysqlDBI [exec] Cannot redefine function [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/dbi/DBIM…>:85 [exec] [exec] 3) PMA_DBI_Mysqli_Test::testMysqliDBI [exec] Cannot redefine function [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/dbi/DBIM…>:84 [exec] [exec] 4) PMA_AuthenticationCookie_Test::testAuthHeader [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/a…>:441 [exec] [exec] 5) PMA_AuthenticationCookie_Test::testAuthCheckWithConstants [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/a…>:643 [exec] [exec] 6) PMA_AuthenticationCookie_Test::testAuthSetUserWithHeaders [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/a…>:862 [exec] [exec] 7) PMA_AuthenticationCookie_Test::testAuthFails [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/a…>:932 [exec] [exec] 8) PMA_AuthenticationHttp_Test::testAuth [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/a…>:63 [exec] [exec] 9) PMA_AuthenticationSignon_Test::testAuth [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/a…>:60 [exec] [exec] 10) PMA_ExportSql_Test::testSetPropertiesWithDrizzle [exec] Cannot redefine constant. Missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/e…>:340 [exec] [exec] 11) PMA_ExportSql_Test::testExportDBFooterWithOlderMySQLVersion [exec] Cannot redefine constant. Missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/e…>:948 [exec] [exec] 12) PMA_ExportSql_Test::testGetTableDefWithDrizzle [exec] Cannot redefine constant. Missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/e…>:1291 [exec] [exec] 13) PMA_ExportXml_Test::testExportHeaderWithDrizzle [exec] Cannot redefine constant. Missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/plugin/e…>:472 [exec] [exec] 14) PMA_HeaderLocation_Test::testSendHeaderLocationWithSidUrlWithQuestionMark [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:130 [exec] [exec] 15) PMA_HeaderLocation_Test::testSendHeaderLocationWithSidUrlWithoutQuestionMark [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:150 [exec] [exec] 16) PMA_HeaderLocation_Test::testSendHeaderLocationWithoutSidWithIis [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:176 [exec] [exec] 17) PMA_HeaderLocation_Test::testSendHeaderLocationWithoutSidWithoutIis [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:192 [exec] [exec] 18) PMA_HeaderLocation_Test::testSendHeaderLocationIisLongUri [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:204 [exec] [exec] 19) PMA_Pow_Test::testGmppow [exec] function gmp_pow() does not exist [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/common…>:45 [exec] [exec] 20) PMA_Pow_Test::testNegativeExpGmppow [exec] function gmp_pow() does not exist [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/common…>:89 [exec] [exec] 21) PMA_FormDisplay_Tpl_Test::testDisplayInput [exec] Cannot modify constant [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Fo…>:198 [exec] [exec] 22) PMA_FormDisplay_Tpl_Test::testDisplayGroupHeader [exec] Cannot modify constant [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Fo…>:537 [exec] [exec] 23) PMA_FormDisplay_Tpl_Test::testDisplayFieldsetBottom [exec] Cannot modify constant [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Fo…>:618 [exec] [exec] 24) PMA_From_Processing_Test::testProcessFormSet [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Fo…>:35 [exec] [exec] 25) PMA_SetupIndex_Test::testPMACheckConfigRw [exec] Cannot redefine constant [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Se…>:328 [exec] [exec] 26) PMA_Tracker_Test::testGetLogComment [exec] Cannot override internal function date() [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Tr…>:273 [exec] [exec] 27) PMA_Tracker_Test::testCreateVersion [exec] Cannot override internal function date() [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Tr…>:296 [exec] [exec] 28) PMA_Tracker_Test::testCreateDatabaseVersion [exec] Cannot override internal function date() [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Tr…>:465 [exec] [exec] 29) PMA_Tracker_Test::testChangeTrackingData [exec] Cannot override internal function date() [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Tr…>:586 [exec] [exec] 30) PMA_Tracker_Test::testGetVersion [exec] Cannot redefine constant [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Tr…>:697 [exec] [exec] 31) PMA_Tracker_Test::testTransformTrackingSet [exec] Cannot redefine constant [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_Tr…>:1078 [exec] [exec] 32) PMA_MySQL_Charsets_Test::testGenerateCharsetQueryPart with data set #0 (false, 'a_b_c_d', ' CHARACTER SET a COLLATE a_b_c_d') [exec] Cannot redefine constant - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_my…>:39 [exec] [exec] 33) PMA_MySQL_Charsets_Test::testGenerateCharsetQueryPart with data set #1 (false, 'a_', ' CHARACTER SET a COLLATE a_') [exec] Cannot redefine constant - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_my…>:39 [exec] [exec] 34) PMA_MySQL_Charsets_Test::testGenerateCharsetQueryPart with data set #2 (false, 'a', ' CHARACTER SET a') [exec] Cannot redefine constant - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_my…>:39 [exec] [exec] 35) PMA_MySQL_Charsets_Test::testGenerateCharsetQueryPart with data set #3 (true, 'a_b_c_d', ' COLLATE a_b_c_d') [exec] Cannot redefine constant - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_my…>:39 [exec] [exec] 36) PMA_MySQL_Charsets_Test::testGetDbCollation [exec] Cannot redefine constant - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_my…>:91 [exec] [exec] 37) PMA_User_Preferences_Test::testUserprefsRedirect [exec] Cannot redefine constant/function - missing runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_us…>:355 [exec] [exec] 38) Environment_Test::testMySQL [exec] Error: SQLSTATE[HY000] [2002] Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/Environment_test…>:62 [exec] [exec] [37;41m[2KFAILURES! [exec] [0m[37;41m[2KTests: 2206, Assertions: 5198, Failures: 1, Incomplete: 6, Skipped: 38. [exec] [0m[2K BUILD FAILED <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml>:30: exec returned: 1 Total time: 15 seconds Build step 'Invoke Ant' marked build as failure [CHECKSTYLE] Skipping publisher since build result is FAILURE [JSLINT] Skipping publisher since build result is FAILURE [PMD] Skipping publisher since build result is FAILURE [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Computing warning deltas based on reference build #5088 [TASKS] Skipping publisher since build result is FAILURE [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #5088 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [INFO] - Check 'Failed Tests' threshold. [xUnit] [INFO] - Check 'Skipped Tests' threshold. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 0

[Phpmyadmin-devel] New PHPCS rule
by Hugues Peccatte 06 Jan '14

06 Jan '14

Hi, What would you think about using the "nesting level" sniff please? This sniff permits to detect when there are too much nested levels like: if (...) { if (...) { if (...) { if (...) { if (...) { .... } } } } } This kind of syntax often means that a refactoring is needed or a rewrite. I can add it myself if you agree. Thanks, Hugues.

4 18

[Phpmyadmin-devel] Newbie, Contribute ot phpMyAdmin
by Jayesh Lahori 05 Jan '14

05 Jan '14

Hi, My name is Jayesh Lahori, I'm a 3rd year Computer Science Student at International Institute of Information Technology, Hyderabad (India) .I'm interested in contributing to Open Source Projects of phpMyAdmin, Any pointers on how should I go about it? My Technical skill-set: *C/C++ , Python , Web Technologies(HTML,CSS,Javascript,PHP,web2py,OpenERP , MySQL).* *OS: GNU/Linux* -- Regards, Jayesh Lahori IIIT-Hyderabad

2 2

[Phpmyadmin-devel] js breakpoints
by Marc Delisle 04 Jan '14

04 Jan '14

Hi, does someone know how to use [0], now that errors are trapped by the error reporting system? I tried setting to "never send error reports" but I cannot trigger an error in the console. [0] https://wiki.phpmyadmin.net/pma/JS_Debugging -- Marc Delisle http://infomarc.info | http://phpmyadmin.net

3 5

[Phpmyadmin-devel] git model
by Isaac Bennetch 03 Jan '14

03 Jan '14

I've been communicating with Sheressa about how we use Git and how Github works in to the phpMyAdmin development workflow. I thought a portion of my email might be helpful to a wider audience. > Sounds like you're a bit confused about the way git and github work > -- which is pretty normal when beginning. I'm still not an expert. > > In general, any Git repository has the complete commit history, so > any time you `git clone` you get a complete independent copy. So in > github, when you forked the phpmyadmin repository, github did a git > clone of the official phpmyadmin repository (somewhat confusingly > called phpmyadmin/phpmyadmin.git, the first phpmyadmin is the > username and the second is the repository name). Within github, then, > you had the sheressa/phpmyadmin.git repository (often github leaves > off the .git porition when referring to a repository path). So that's > your repository/clone/fork of the phpmyadmin -- and at that moment, > you have the complete phpMyAdmin source code duplicated in your > sheressa github account. > > At that point, you would have done a `git clone` of your repository, > checking out the sheressa/phpmyadmin.git repository to your local > computer. Github's instructions provide a way to continue to get > updates from the phpmyadmin/phpmyadmin.git repository, so you'll > continue to get new commits added to your local computer when you > update. So technically, there are three different repositories in > effect: phpmyadmin on github, sheressa on github, and the local > clone. Since this all gets a bit confusing, Git allows you to give > nicknames to these sources; on my system (which I believe I > configured based on the Github documentation) the phpmyadmin one is > 'upstream' and the ibennetch one is 'origin' (so I can `git fetch > upstream` and `git push origin`). So basically you'll be making > changes locally and pushing them to sheressa/phpmyadmin.git, then > from there using the Github interface to submit a pull request to the > phpmyadmin/phpmyadmin.git repository. Hope this makes sense so far. > > So far I've just talked about repositories; there's a whole other > aspect which is the branches. In phpMyAdmin, development happens on > the 'master' branch and we create a branch at each release, so we > have for instance MAINT_4_1_3 and QA_4_1. When you do development > work, it's generally best to do that in a new branch (which doesn't > affect the phpmyadmin/phpmyadmin.git repository at all and only goes > to sheressa/phpmyadmin.git if you push it there). So we do new > development in 'master' but since branching is so easy with git, we > generally develop something in a temporary branch and then merge it > to master from there. > > Hope that helps a bit.

3 2

[Phpmyadmin-devel] Fixed Bug #4184
by Lakshit Arora 02 Jan '14

02 Jan '14

Hello, I have fixed the bug #4181 [1]. Below are the pull requests: 1. Pull request with base on master https://github.com/phpmyadmin/phpmyadmin/pull/817 2. Pull request rebased on QA_4_1 https://github.com/phpmyadmin/phpmyadmin/pull/818 Thanks, Lakshit Arora Undergrad, IIIT Hyderabad-IN [1] : http://sourceforge.net/p/phpmyadmin/bugs/4184/

1 0

[Phpmyadmin-devel] Navigation Tree help
by Chanaka Dharmarathna 01 Jan '14

01 Jan '14

Hi, I'm working on the feature request [0] and having some troubles with adding table comments as tool tip in the navigation tree. Tool tip can be display by adding title attribute to line [1] in NavigationTree class. But I'm not sure how to access table meta data (table comment) at that point with $node object. Is it possible to do that ? link Or can we set table comment in the constructor of Node_Table class by setting another array element to $links associative array [2] ? Is there any other approaches. Appreciate any help. [0] : https://sourceforge.net/p/phpmyadmin/feature-requests/1462/ [1] : https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/navigation/N… [2] : https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/navigation/N… Regards ! -- Chanaka Dharmarathna *Virtusa (Pvt) Ltd. | **Sri Lanka*

2 3

[Phpmyadmin-devel] Many, many pull requests
by Isaac Bennetch 01 Jan '14

01 Jan '14

Hi Sheressa, I don't really understand your recent pull requests. I think there must be some mistake or misunderstanding, but when creating a pull request through the github web interface it sort of shows what you're about to do before actually doing it, so I'm not sure whether this is intentional or mistakes or what's going on. Anyway, there are now seven pull requests which seem to be reapplying old version increases. If you're trying to create a pull request for some code you've developed, something's gone wrong. Perhaps you can clarify what you're trying to accomplish and what you've tried so we can help walk you through it. Kind regards, ~isaac

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers January 2014