Hi,
What would you think about using the "nesting level" sniff please?
This sniff permits to detect when there are too much nested levels like:
if (...) {
if (...) {
if (...) {
if (...) {
if (...) {
....
}
}
}
}
}
This kind of syntax often means that a refactoring is needed or a rewrite.
I can add it myself if you agree.
Thanks,
Hugues.
Hi,
My name is Jayesh Lahori, I'm a 3rd year Computer Science Student at
International Institute of Information Technology, Hyderabad (India) .I'm
interested in contributing to Open Source Projects of phpMyAdmin, Any
pointers on how should I go about it?
My Technical skill-set:
*C/C++ , Python , Web Technologies(HTML,CSS,Javascript,PHP,web2py,OpenERP ,
MySQL).*
*OS: GNU/Linux*
--
Regards,
Jayesh Lahori
IIIT-Hyderabad
I've been communicating with Sheressa about how we use Git and how
Github works in to the phpMyAdmin development workflow. I thought a
portion of my email might be helpful to a wider audience.
> Sounds like you're a bit confused about the way git and github work
> -- which is pretty normal when beginning. I'm still not an expert.
>
> In general, any Git repository has the complete commit history, so
> any time you `git clone` you get a complete independent copy. So in
> github, when you forked the phpmyadmin repository, github did a git
> clone of the official phpmyadmin repository (somewhat confusingly
> called phpmyadmin/phpmyadmin.git, the first phpmyadmin is the
> username and the second is the repository name). Within github, then,
> you had the sheressa/phpmyadmin.git repository (often github leaves
> off the .git porition when referring to a repository path). So that's
> your repository/clone/fork of the phpmyadmin -- and at that moment,
> you have the complete phpMyAdmin source code duplicated in your
> sheressa github account.
>
> At that point, you would have done a `git clone` of your repository,
> checking out the sheressa/phpmyadmin.git repository to your local
> computer. Github's instructions provide a way to continue to get
> updates from the phpmyadmin/phpmyadmin.git repository, so you'll
> continue to get new commits added to your local computer when you
> update. So technically, there are three different repositories in
> effect: phpmyadmin on github, sheressa on github, and the local
> clone. Since this all gets a bit confusing, Git allows you to give
> nicknames to these sources; on my system (which I believe I
> configured based on the Github documentation) the phpmyadmin one is
> 'upstream' and the ibennetch one is 'origin' (so I can `git fetch
> upstream` and `git push origin`). So basically you'll be making
> changes locally and pushing them to sheressa/phpmyadmin.git, then
> from there using the Github interface to submit a pull request to the
> phpmyadmin/phpmyadmin.git repository. Hope this makes sense so far.
>
> So far I've just talked about repositories; there's a whole other
> aspect which is the branches. In phpMyAdmin, development happens on
> the 'master' branch and we create a branch at each release, so we
> have for instance MAINT_4_1_3 and QA_4_1. When you do development
> work, it's generally best to do that in a new branch (which doesn't
> affect the phpmyadmin/phpmyadmin.git repository at all and only goes
> to sheressa/phpmyadmin.git if you push it there). So we do new
> development in 'master' but since branching is so easy with git, we
> generally develop something in a temporary branch and then merge it
> to master from there.
>
> Hope that helps a bit.
Hi Sheressa, I don't really understand your recent pull requests. I
think there must be some mistake or misunderstanding, but when creating
a pull request through the github web interface it sort of shows what
you're about to do before actually doing it, so I'm not sure whether
this is intentional or mistakes or what's going on. Anyway, there are
now seven pull requests which seem to be reapplying old version
increases. If you're trying to create a pull request for some code
you've developed, something's gone wrong. Perhaps you can clarify what
you're trying to accomplish and what you've tried so we can help walk
you through it.
Kind regards,
~isaac