See <https://ci.phpmyadmin.net/job/phpMyAdmin/2207/display/redirect?page=changes>
Changes:
[Michal Čihař] Run Selenium tests on PHP 7.2
[Michal Čihař] Avoid usage of soon deprecated $php_errormsg
[weblate] Translated using Weblate (Indonesian)
[weblate] Translated using Weblate (Indonesian)
[weblate] Translated using Weblate (Lithuanian)
[weblate] Translated using Weblate (Punjabi)
[Michal Čihař] Excude Twig cache from coverage reports
[weblate] Translated using Weblate (Indonesian)
[Michal Čihař] Use actual value for cache...
[Michal Čihař] Exclude tmp from all checks
[devenbansod.bits] Fix error introduced in f36ed72 (#13602)
[devenbansod.bits] Refactor methods in selenium tests
[devenbansod.bits] Replace usleep with sleep calls
[devenbansod.bits] Add navigateDatabase method to prevent navigation errors
------------------------------------------
[...truncated 31.38 KB...]
phpcpd:
[exec] phpcpd 2.0.2 by Sebastian Bergmann.
[exec]
[exec] Found 6 exact clones with 400 duplicated lines in 8 files:
[exec]
[exec] - <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/dbi/dbi_dummy.inc.php>:295-403
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/dbi/dbi_dummy.inc.php>:401-509
[exec]
[exec] - <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Schem…>:104-154
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Schem…>:92-142
[exec]
[exec] - <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Expor…>:234-275
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Expor…>:391-432
[exec]
[exec] - <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Expor…>:356-422
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Expor…>:596-662
[exec]
[exec] - <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Expor…>:105-172
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Expor…>:129-196
[exec]
[exec] - <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Expor…>:173-241
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Plugins/Expor…>:200-268
[exec]
[exec] 0.25% duplicated lines out of 162429 total lines of code.
[exec]
[exec] Time: 5.4 seconds, Memory: 105.00Mb
[exec] Result: 1
phpcs-config:
[exec] Config value "installed_paths" updated successfully; old value was "/var/lib/jenkins/jobs/phpMyAdmin-continuous/workspace/vendor/phpmyadmin/coding-standard"
phpcs:
[exec] Time: 17.24 secs; Memory: 52Mb
[exec]
[exec] Result: 1
phploc:
[exec] phploc 3.0.0 by Sebastian Bergmann.
[exec]
[exec] PHP Notice: Undefined index: ccn in /var/lib/jenkins/.composer/vendor/phploc/phploc/src/Analyser.php on line 507
[exec] Directories 49
[exec] Files 478
[exec]
[exec] Size
[exec] Lines of Code (LOC) 162429
[exec] Comment Lines of Code (CLOC) 42315 (26.05%)
[exec] Non-Comment Lines of Code (NCLOC) 120114 (73.95%)
[exec] Logical Lines of Code (LLOC) 35548 (21.89%)
[exec] Classes 21152 (59.50%)
[exec] Average Class Length 75
[exec] Minimum Class Length 0
[exec] Maximum Class Length 1096
[exec] Average Method Length 8
[exec] Minimum Method Length 0
[exec] Maximum Method Length 537
[exec] Functions 7104 (19.98%)
[exec] Average Function Length 15
[exec] Not in classes or functions 7292 (20.51%)
[exec]
[exec] Cyclomatic Complexity
[exec] Average Complexity per LLOC 0.36
[exec] Average Complexity per Class 31.32
[exec] Minimum Class Complexity 1.00
[exec] Maximum Class Complexity 575.00
[exec] Average Complexity per Method 4.41
[exec] Minimum Method Complexity 1.00
[exec] Maximum Method Complexity 130.00
[exec]
[exec] Dependencies
[exec] Global Accesses 7348
[exec] Global Constants 84 (1.14%)
[exec] Global Variables 4718 (64.21%)
[exec] Super-Global Variables 2546 (34.65%)
[exec] Attribute Accesses 4647
[exec] Non-Static 4524 (97.35%)
[exec] Static 123 (2.65%)
[exec] Method Calls 11157
[exec] Non-Static 7097 (63.61%)
[exec] Static 4060 (36.39%)
[exec]
[exec] Structure
[exec] Namespaces 36
[exec] Interfaces 4
[exec] Traits 0
[exec] Classes 278
[exec] Abstract Classes 40 (14.39%)
[exec] Concrete Classes 238 (85.61%)
[exec] Methods 2538
[exec] Scope
[exec] Non-Static Methods 1814 (71.47%)
[exec] Static Methods 724 (28.53%)
[exec] Visibility
[exec] Public Methods 2055 (80.97%)
[exec] Non-Public Methods 483 (19.03%)
[exec] Functions 465
[exec] Named Functions 434 (93.33%)
[exec] Anonymous Functions 31 (6.67%)
[exec] Constants 135
[exec] Global Constants 64 (47.41%)
[exec] Class Constants 71 (52.59%)
jshint:
[apply] Result: 2
jshint-checkstyle:
[apply] Result: 2
lint:
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Config/Valida…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/libraries/classes/Tracking.php>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumCreate…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumCreate…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumDbEven…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumDbOper…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumDbProc…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumDbStru…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumDbTrig…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumExport…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumImport…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumQueryB…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumServer…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumSqlQue…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumTableB…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumTableC…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumTableI…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumTableS…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumTracki…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/PmaSeleniumXssTes…>
[apply] No syntax errors detected in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/test/selenium/TestBase.php>
BUILD SUCCESSFUL
Total time: 6 minutes 7 seconds
[CHECKSTYLE] Collecting checkstyle analysis files...
[CHECKSTYLE] Searching for all files in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/> that match the pattern build/logs/checkstyle.xml
[CHECKSTYLE] Parsing 1 file in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/>
[CHECKSTYLE] Successfully parsed file <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/build/logs/checkstyle.xml> with 783 unique warnings and 0 duplicates.
[CHECKSTYLE] Computing warning deltas based on reference build #2205
[JSLINT] Collecting JSLint analysis files...
[JSLINT] Searching for all files in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/> that match the pattern build/logs/jshint-checkstyle.xml
[JSLINT] Parsing 1 file in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/>
[JSLINT] Successfully parsed file <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/build/logs/jshint-checkstyle.xml> with 189 unique warnings and 0 duplicates.
[JSLINT] Computing warning deltas based on reference build #2205
[PMD] Collecting PMD analysis files...
[PMD] Searching for all files in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/> that match the pattern build/logs/pmd.xml
[PMD] Parsing 1 file in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/>
[PMD] Successfully parsed file <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/build/logs/pmd.xml> with 2033 unique warnings and 0 duplicates.
<Git Blamer> Using GitBlamer to create author and commit information for all warnings.
<Git Blamer> GIT_COMMIT=8256945ec2f79155f8dae765118efe1201d1436c, workspace=<https://ci.phpmyadmin.net/job/phpMyAdmin/ws/>
> git rev-parse 8256945ec2f79155f8dae765118efe1201d1436c^{commit} # timeout=10
ERROR: Build step failed with exception
java.lang.OutOfMemoryError: Java heap space
at org.eclipse.jgit.internal.storage.file.PackFile.load(PackFile.java:878)
at org.eclipse.jgit.internal.storage.file.PackFile.get(PackFile.java:273)
at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedObject(ObjectDirectory.java:421)
at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedFromSelfOrAlternate(ObjectDirectory.java:390)
at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedFromSelfOrAlternate(ObjectDirectory.java:394)
at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openObject(ObjectDirectory.java:382)
at org.eclipse.jgit.internal.storage.file.WindowCursor.open(WindowCursor.java:154)
at org.eclipse.jgit.treewalk.CanonicalTreeParser.reset(CanonicalTreeParser.java:214)
at org.eclipse.jgit.treewalk.TreeWalk.reset(TreeWalk.java:645)
at org.eclipse.jgit.blame.BlameGenerator.find(BlameGenerator.java:954)
at org.eclipse.jgit.blame.BlameGenerator.processOne(BlameGenerator.java:603)
at org.eclipse.jgit.blame.BlameGenerator.next(BlameGenerator.java:496)
at org.eclipse.jgit.blame.BlameResult.computeAll(BlameResult.java:239)
at org.eclipse.jgit.blame.BlameGenerator.computeBlameResult(BlameGenerator.java:450)
at org.eclipse.jgit.api.BlameCommand.call(BlameCommand.java:230)
at hudson.plugins.analysis.util.GitBlamer$BlameCallback.invoke(GitBlamer.java:130)
at hudson.plugins.analysis.util.GitBlamer$BlameCallback.invoke(GitBlamer.java:104)
at org.jenkinsci.plugins.gitclient.AbstractGitAPIImpl.withRepository(AbstractGitAPIImpl.java:29)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.withRepository(CliGitAPIImpl.java:71)
at hudson.plugins.analysis.util.GitBlamer.loadBlameResultsForFiles(GitBlamer.java:61)
at hudson.plugins.analysis.util.GitBlamer.blame(GitBlamer.java:54)
at hudson.plugins.analysis.util.AbstractBlamer$1.invoke(AbstractBlamer.java:62)
at hudson.plugins.analysis.util.AbstractBlamer$1.invoke(AbstractBlamer.java:59)
at hudson.FilePath.act(FilePath.java:998)
at hudson.FilePath.act(FilePath.java:976)
at hudson.plugins.analysis.util.AbstractBlamer.invokeBlamer(AbstractBlamer.java:59)
at hudson.plugins.analysis.util.AbstractBlamer.blame(AbstractBlamer.java:45)
at hudson.plugins.analysis.core.HealthAwarePublisher.blame(HealthAwarePublisher.java:109)
at hudson.plugins.pmd.PmdPublisher.perform(PmdPublisher.java:79)
at hudson.plugins.analysis.core.HealthAwarePublisher.perform(HealthAwarePublisher.java:69)
at hudson.plugins.analysis.core.HealthAwareRecorder.perform(HealthAwareRecorder.java:298)
at hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
Caused: org.eclipse.jgit.errors.LargeObjectException$OutOfMemory: Out of memory loading unknown object
at org.eclipse.jgit.internal.storage.file.PackFile.load(PackFile.java:881)
at org.eclipse.jgit.internal.storage.file.PackFile.get(PackFile.java:273)
at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedObject(ObjectDirectory.java:421)
at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedFromSelfOrAlternate(ObjectDirectory.java:390)
at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedFromSelfOrAlternate(ObjectDirectory.java:394)
at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openObject(ObjectDirectory.java:382)
at org.eclipse.jgit.internal.storage.file.WindowCursor.open(WindowCursor.java:154)
at org.eclipse.jgit.treewalk.CanonicalTreeParser.reset(CanonicalTreeParser.java:214)
at org.eclipse.jgit.treewalk.TreeWalk.reset(TreeWalk.java:645)
at org.eclipse.jgit.blame.BlameGenerator.find(BlameGenerator.java:954)
at org.eclipse.jgit.blame.BlameGenerator.processOne(BlameGenerator.java:603)
at org.eclipse.jgit.blame.BlameGenerator.next(BlameGenerator.java:496)
at org.eclipse.jgit.blame.BlameResult.computeAll(BlameResult.java:239)
at org.eclipse.jgit.blame.BlameGenerator.computeBlameResult(BlameGenerator.java:450)
at org.eclipse.jgit.api.BlameCommand.call(BlameCommand.java:230)
at hudson.plugins.analysis.util.GitBlamer$BlameCallback.invoke(GitBlamer.java:130)
at hudson.plugins.analysis.util.GitBlamer$BlameCallback.invoke(GitBlamer.java:104)
at org.jenkinsci.plugins.gitclient.AbstractGitAPIImpl.withRepository(AbstractGitAPIImpl.java:29)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.withRepository(CliGitAPIImpl.java:71)
at hudson.plugins.analysis.util.GitBlamer.loadBlameResultsForFiles(GitBlamer.java:61)
at hudson.plugins.analysis.util.GitBlamer.blame(GitBlamer.java:54)
at hudson.plugins.analysis.util.AbstractBlamer$1.invoke(AbstractBlamer.java:62)
at hudson.plugins.analysis.util.AbstractBlamer$1.invoke(AbstractBlamer.java:59)
at hudson.FilePath.act(FilePath.java:998)
at hudson.FilePath.act(FilePath.java:976)
at hudson.plugins.analysis.util.AbstractBlamer.invokeBlamer(AbstractBlamer.java:59)
at hudson.plugins.analysis.util.AbstractBlamer.blame(AbstractBlamer.java:45)
at hudson.plugins.analysis.core.HealthAwarePublisher.blame(HealthAwarePublisher.java:109)
at hudson.plugins.pmd.PmdPublisher.perform(PmdPublisher.java:79)
at hudson.plugins.analysis.core.HealthAwarePublisher.perform(HealthAwarePublisher.java:69)
at hudson.plugins.analysis.core.HealthAwareRecorder.perform(HealthAwareRecorder.java:298)
at hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:81)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:736)
at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:682)
at hudson.model.Build$BuildExecution.post2(Build.java:186)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:627)
at hudson.model.Run.execute(Run.java:1764)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:419)
Build step 'Publish PMD analysis results' marked build as failure
[DRY] Collecting duplicate code analysis files...
[DRY] Searching for all files in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/> that match the pattern build/logs/pmd-cpd.xml
[DRY] Parsing 1 file in <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/>
[DRY] Successfully parsed file <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/build/logs/pmd-cpd.xml> with 12 unique warnings and 0 duplicates.
<Git Blamer> Using GitBlamer to create author and commit information for all warnings.
<Git Blamer> GIT_COMMIT=8256945ec2f79155f8dae765118efe1201d1436c, workspace=<https://ci.phpmyadmin.net/job/phpMyAdmin/ws/>
> git rev-parse 8256945ec2f79155f8dae765118efe1201d1436c^{commit} # timeout=10
[DRY] Computing warning deltas based on reference build #2205
[TASKS] Skipping publisher since build result is FAILURE
[ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #2205
Recording plot data
Publishing Clover coverage report...
Clover xml file does not exist in: <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/> called: build/logs/clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin/builds/2207/cloverphp/clover.xml
Could not find 'build/coverage/build/logs/clover.xml'. Did you generate the XML report for Clover?
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing PHPUnit-3.x (default)
[xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<https://ci.phpmyadmin.net/job/phpMyAdmin/ws/'> for the testing framework 'PHPUnit-3.x (default)'.
[xUnit] [INFO] - Check 'Failed Tests' threshold.
[xUnit] [INFO] - Check 'Skipped Tests' threshold.
[xUnit] [INFO] - Setting the build status to FAILURE
[xUnit] [INFO] - Stopping recording.
[JDepend] JDepend plugin is ready
[JDepend] Couldn't generate JDepend file at 'build/logs/jdepend.xml'java.nio.file.NoSuchFileException: <https://ci.phpmyadmin.net/job/phpMyAdmin/ws/build/logs/jdepend.xml>
Hi all
[Resending as apparently it didn't reach most of you due to Gmail
rejecting my mails.]
For quite some time we're using Jenkins for CI. We've also added Travis
during next the years. Do you think it's reasonable to still have both
of them?
Own Jenkins server requires some maintenance and currently doesn't
integrate that well with GitHub as Travis. This could be probably
addressed, but the questions is whether it's worth of it.
My personal opinion is that Jenkins does not really have any benefits,
so maybe it's time to drop it from our infrastructure.
PS: I've disabled error-reporting-server tests there as they are
apparently failing due to some timezone errors.
--
Michal Čihař | https://cihar.com/ | https://weblate.org/
We're scheduled to release 4.7.4 next week, but looking at the list of
fixes[1] I don't see anything particularly urgent and there aren't a
lot. Now granted, we are still over a week away from then, and a lot
more improvements could be done by then, but I'm just planning ahead
based on what we have right now.
Do you think we should release on schedule anyway?
1 - https://github.com/phpmyadmin/phpmyadmin/issues?utf8=%E2%9C%93&q=%20milesto…
Hi everyone,
I am working on improving setup script [1]. I encountered a few bugs after
starting to work on it. I fixed a few of them. Now I am facing another
issue. After modifying/setting values and applaying them. The setup doesn't
retain those options. It shows basic configuration file when I try to
display them using display option. It will be great if someone can help me
fix it. You can checkout my branch from Github [2].
[1] https://github.com/phpmyadmin/phpmyadmin/issues/12844
[2] https://github.com/Achilles-96/phpmyadmin/tree/Setup-Improvements
Regards,
Raghuram
I'm having trouble manually running phpcs on my system, has anyone
else tried lately? I haven't run it locally in some time and now I get
an error.
All the Google results I've found for this error are for software
using phpcs that wasn't compatible with version 3, so it's tough for
me to tell offhand if this is something wrong with my system directly
or a version incompatibility.
PHP Fatal error: Interface 'PHP_CodeSniffer_Sniff' not found in
/var/www/pma-dev/coding-standard/PMAStandard/Sniffs/Commenting/FunctionCommentSniff.php
on line 29
PHP Stack trace:
PHP 1. {main}() /usr/bin/phpcs:0
PHP 2. PHP_CodeSniffer\Runner->runPHPCS() /usr/bin/phpcs:18
PHP 3. PHP_CodeSniffer\Runner->init()
/usr/share/php/PHP/CodeSniffer/src/Runner.php:70
PHP 4. PHP_CodeSniffer\Ruleset->__construct()
/usr/share/php/PHP/CodeSniffer/src/Runner.php:294
PHP 5. PHP_CodeSniffer\Ruleset->registerSniffs()
/usr/share/php/PHP/CodeSniffer/src/Ruleset.php:206
PHP 6. PHP_CodeSniffer\Autoload::loadFile()
/usr/share/php/PHP/CodeSniffer/src/Ruleset.php:1094
PHP 7. include() /usr/share/php/PHP/CodeSniffer/autoload.php:167
Hi,
Every now and then, an error occurs where the red/pink message pops up
at the bottom of the screen. It used to be that I could press the
details button and copy the error for including in an issue. Recently,
clicking that button has had no effect. It's not clear to me whether
that's because the error that occurred broke the error handler or
because something has changed in phpMyAdmin to break this
functionality.
My configuration setting is the default, $cfg['SendErrorReports'] = 'ask';
Has anyone else seem this behavior lately?
Hi,
I was looking at some of the JavaScript function names, in particular
in js/pma/move.js and the names are a mess; we have many different
variations of naming technique. That led me to look for any coding
style guides; I know we have one for PHP files[1] but it's not clear
if we use the same standards for JavaScript files. We can improve our
documentation about this (unless I just missed some documentation that
already exists). Any input about what we should use here? Most of the
rest of the JS files seem to use PEAR-standard function names, at
least based on a quick look I just did. If we all agree on that, we
can just add a bit to the wiki telling people to use those same
standards for JS files.
Any thoughts?
1 - https://github.com/phpmyadmin/phpmyadmin/wiki/Developer_guidelines#coding-s…
