Hi all,
Although we have chosen PEAR coding standards[1] as the coding standard for
phpMyAdmin[2], there are quite a number of occasions where the standard is
being violated, especially the line length recommendation. For example in
display_tbl.lib.php I can see lines with 282 character while
the recommended limit is 75-85[3].
However, I feel that this limit is bit too restrictive given that some lines
have indentation of about 32 spaces. So I think it's better to set the limit
bit leniently (at least for those files) and adhering to it rather than
ignoring the line length limit altogether. Any thoughts?
With things clarified all the GSoCers would be able to produce quality code
during this summer.
--
Thanks and Regards,
Madhura Jayaratne
[1] http://pear.php.net/manual/en/standards.php
[2] http://wiki.phpmyadmin.net/pma/Coding_guidelines
[3] http://pear.php.net/manual/en/standards.indenting.php
Hi all,
I've pushed commits improving the "recently used tables" in my repo and would like to ask for comments before I proceed further.
The demo have been updated, so you can try it through [0]. What I've done so far:
- Added configuration 'LeftRecentTable' ("Settings" -> "Navigation frame" -> "Navigation frame" tab -> "Recently used tables")
- Added a new class ./libraries/RecentTable.class.php for managing recent tables
- Added configuration ['Servers'][$i]['recent'], table in pma database for "persistent" recent tables
- Added SQL commands to create 'pma_recent' table in scripts/create_tables.sql
others:
- Added 'recent' feature in ./libraries/relation.lib.php
- Modified some CSS to prettify navigation frame
What next to be done:
- Write documentation about configuration LeftRecentTable
- Write documentation about table pma_recent in Documentation.html
[0] http://demo.phpmyadmin.net/gsoc-aris/
Regards,
--
Aris Feryanto
Hi,
I find it difficult to read error messages (white text on "pink"
background).
Text color red would be fine, IMO.
--
Marc Delisle
http://infomarc.info
Hi
Dne Thu, 5 May 2011 13:50:57 +0200
Tyron Madlener <tyronx(a)gmail.com> napsal(a):
> By the way, I just saw that with themes that don't have the chart
> colors defined the charts display will be broken. Should I put some
> default values into pma_pchart_chart.php?
I've fixed all themes supporting 3.4, so that should be okay.
PS: Keep the discussion on the list, it's usually better.
--
Michal ÄŒihaÅ™ | http://cihar.com | http://phpmyadmin.cz
Hi,
Some can disagree but looking at the bug tracker, I don't find bugs
major enough to block the 3.4.0 release.
I suggest to open the QA_3_4 and MAINT_3_4_0 branches and merge there
only the fixes about which we are sure, with the goal of preparing
3.4.0-rc3 which should be the last candidate.
--
Marc Delisle
http://infomarc.info
I thought its a good idea to make the charts adjust to the current
theme colors, so I wrote a patch for it:
http://www.tyron.at/tmp/chart_colors.patch
I also wrote a short blog entry about it, showing screenshots of the
new changed charts:
http://tyronx.blogspot.com/2011/04/some-better-colors-for-charts.html
I tried to pull it to my repos on repo.or.cz but it doesn't accept my
user name and password. Set I set up a push account for me though, and
typed in my public key. The (Windows)-git-commit-tool-gui shows me the
same public key.
After I checked out the code, I've added my repos with the command
'git remote add tyronm ssh://repo.or.cz/srv/git/phpmyadmin/tyronm.git'
then trying to pull via 'git pull tyronm'. Anyone know what I'm doing
wrong?
Thanks in advance.
In phpMyAdmin 3.3 most of the export settings were visible in one page
without scrolling, hence requiring only very few clicks to export what
you need. But in 3.4 when I try to export the table structure I first
need to click '(o) custom' then scroll down and search through all the
text where in order to find where I select '(o) structure'. It feels
very unintuitive for me.
What about:
a) We put all the settings in jquery tabs
b) On the first tab will be the most used options: Format, Output type
(File / as Text) and what to dump (2 checkboxes for each data and
structure)
Here's a demo of the tabs: http://jqueryui.com/demos/tabs/
Also, all the pma demos on the server seem to have troubles:
Warning in ./libraries/dbi/mysqli.dbi.lib.php#111
mysqli_real_connect(): (28000/1045): Access denied for user
'root'@'localhost' (using password: NO)
Hi all,
Rouslan, in his comment on tracker item [1] pointed out that with the new
layout in DB Operations page, the page looks weird in both Firefox and
Opera. He is using the screen resolution of 1280 x 1024.
I would like to know whether the new layout looks okay/weird in other
resolutions as well.
I initially checked with 1366 x 768 and the page looks okay with that
resolution.
--
Thanks and Regards,
Madhura Jayaratne
[1]
https://sourceforge.net/tracker/index.php?func=detail&aid=3292121&group_id=…