Marc Delisle a écrit :
Aris Feryanto a écrit :
Hi,
Just realized my previous email seem not delivered successfully to phpMyAdmin-devel list. I've previously sent an email telling that I will work on merging the tooltip as suggested by Rouslan. I'm still working and testing on this and will add the 'Click to mark'.
I am also fixing the previous code, as it hasn't checked whether we are under Browse tab, before calling the column-order remembering function.
I wonder if there is any existing exact way to check if we are under Browse tab? Current code do the checking using requested url pattern and analyzed SQL query (you may see function PMA_isBrowsing in file libraries/display_tbl.lib.php in my git repo). But, this is not enough for handling load from AJAX request under other tabs (e.g. AJAX request to sql.php caused by pagination of results under SQL tab)
Yes, this is difficult to solve with current code; maybe it's time for a new tbl_browse.php that could set some constant, then require sql.php. Further down the code, either the constant is checked directly or is used to generate a hidden span with some id that can be checked at the js level.
By the way, I'm not sure why you strictly want to do some verifications while under the Browse tab. Some actions, for example Search, will generate results in which in a user might want to reorder the columns.