Re: [Phpmyadmin-devel] GSoC question

Le 2013-04-30 17:07, Mohamed Ashraf a écrit :

...

well, it's up to students to come up with a design.

well ofcourse but you chose it as one of the ideas for gsoc because you feel that there are problems in the code design. other than the fact that it is using echo rather than the new method for outputting html what else do you think should be changed.

Here are a few ideas about sql.php:

- script is too long, contains long segments of code that need to be moved to functions; compare it with tbl_select.php which has been refactored last year)

- the way other scripts are calling sql.php should be improved, maybe avoiding the use of include statements

I wish you have a look at sql.php by yourself.