Re: [Phpmyadmin-devel] Regarding Bug #4302

2014-03-01 13:03 GMT+01:00 Marc Delisle marc@infomarc.info:

Le 2014-03-01 07:01, Hugues Peccatte a écrit :

...

Hi,

2014-03-01 12:49 GMT+01:00 Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info>:

Le 2014-02-28 09:42, Omer Jer a écrit :
> Hi,
> Refreshing the Table Export page causes this bug.
> After looking at the code I got that the bug is due to the missing

of

...

> this parameter '$_REQUEST['single_table']' in the
display_export.inc.php
>
> The only way to fix it is (as I suppose) to append the
> single_table='true' in the url when the users first come to the

Table

...

> Export page.

But single_table is already set to true on the table Export menu

link.

...

But the fact is that he seems to be right... After refreshing the page, the single_table input is no longer in the form... His fix is working for me.

Thanks. Feel free to merge it then.

There is one thing that I can't evaluate. That's the impact on the whole project because the fix is in a common function... And I don't know how to be sure about this...

...

> my doubts are :
> 1. Does it even counted as a bug ? (in case if we don't expect the
user
> to refresh the page)

Yes it counts as a minor bug

> 2. Is editing the URL ok ? or if you have some other solution in

your

...

> mind please do tell.

Hugues.