Robin Johnson wrote:
Hi List,
Nearly completed the merge of the parser, but I have some questions/notes. Notes:
- The Analyzer is _NOT_ working
Questions:
- Do we need the analyzer right away to get table/column/alias data for
the 2.3.0 release? If not, it can wait for 2.3.1 to replace the existing data extracters in the code.
I think that the analyser can wait for 2.3.1. IMHO, bugs 573212, 574852 and 584411 are not show-stoppers.
- For the display of the formatted queries, I need to put in a batch of
stylesheet rules. Where is the best place to include my dynamically generated <style>...</style> data? The only requirement that I have for it is that the functions have all be defined and that $cfg data is available. Our login and error pages provide it, but nowhere in the main code can I find it.
TODO:
- Add CSS stuff in the correct place
- Update PMA_format_sql() function to use the new formatter
- See if everybody likes the output format ;-)
I do :)
- Update Documentation.html
We don't need UseSyntaxColoring anymore, I think?
- Update function documentation
Other Notes: Many thanks to my boss for letting me work on this for all of today (and still get paid for my job)
Thanks you boss! and also Robin :)
It's 5PM now, so I'm heading home. I'll be there in 90 minutes or so, hopefully somebody has suggestions on the questions about the CSS stuff, so that I can have the SQL Parser active by tommorow morning.