Hi
Dne Thu, 16 Jul 2009 17:02:21 +0200 Herman van Rink rink@initfour.nl napsal(a):
Michal Čihař wrote:
Hi
Dne Wed, 15 Jul 2009 05:05:46 +0200 Herman van Rink rink@initfour.nl napsal(a):
The PMA_formatNumberByteDown_test test still fails for me on a conversion.... does this pass on other systems?
Six tests do fail for me:
- testEncrypt(PMA_blowfish_test)
- testDecrypt(PMA_blowfish_test)
These have never failed me. Could you look into this?
Unfortunately I lack time to look at them now, here are the failures I got:
1) testEncrypt(PMA_blowfish_test) Failed asserting that two strings are equal. expected string <kO/kc4j/nyk=> difference <xxxxxxxxxxx> got string <Oa6nX6ayG9U=> /home/nijel/work/phpmyadmin/trunk/phpMyAdmin/test/PMA_blowfish_test.php:48
2) testDecrypt(PMA_blowfish_test) Failed asserting that two strings are equal. expected string <12345678> difference <xxxxxxxx> got string <N`��z�> /home/nijel/work/phpmyadmin/trunk/phpMyAdmin/test/PMA_blowfish_test.php:56
- testFormatNumber(PMA_formatNumberByteDown_test) with data set #4
- testFormatNumber(PMA_formatNumberByteDown_test) with data set #5
- testFormatNumber(PMA_formatNumberByteDown_test) with data set #6
These 3 fail me as well, using the data: array(0.00003, 3, 2, '0,03 m'), array(0.003, 3, 3, '0,003 '), array(-0.003, 6, 0, '-3 m'),
Could someone with intimate formatting knowledge take a look at this to determine if PMA_formatNumber() needs fixing, or the testcase?
It looks to me like PMA_formatNumber() is broken (it tends to return zero instead of exact number):
3) testFormatNumber(PMA_formatNumberByteDown_test) with data set #4 (3.0E-5, 3, 2, '0,03 m') Failed asserting that two strings are equal. expected string <0,03 m> difference < xxx> got string <0,00 k> /home/nijel/work/phpmyadmin/trunk/phpMyAdmin/test/PMA_formatNumberByteDown_test.php:86
4) testFormatNumber(PMA_formatNumberByteDown_test) with data set #5 (0.003, 3, 3, '0,003 ') Failed asserting that two strings are equal. expected string <0,003 > difference < xxx> got string <0,000 k> /home/nijel/work/phpmyadmin/trunk/phpMyAdmin/test/PMA_formatNumberByteDown_test.php:86
5) testFormatNumber(PMA_formatNumberByteDown_test) with data set #6 (-0.003, 6, 0, '-3 m') Failed asserting that two strings are equal. expected string <-3 m> difference < xxx> got string <-0 k> /home/nijel/work/phpmyadmin/trunk/phpMyAdmin/test/PMA_formatNumberByteDown_test.php:86
- testWriteReloadNavigation(PMA_headerLocation_test)
Should be fixed now.
Yes it is, thanks!