Hi
Dne Fri, 22 Jul 2011 22:34:55 +0530
Madhura Jayaratne <madhura.cj(a)gmail.com> napsal(a):
Looking at the CheckStyle reports from the CI, all the
export files show
very high counts of indentation rule violations.
The code in the 'else' block of 'if (isset($plugin_list))' condition is
wrongly indented in all of these files.
There are two possible ways to correct this.
1) Correctly indent the 'else' block
2) Add 'return' statement to the end of 'if' block and remove 'else
{' part.
Which one if preferred?
I don't think 2 will work, so out of these 1 is only solution. Rewrite
it so that same functions are not defined in all plugins (using classes
instead) would be preferable solution, though it is much more complex
than reindenting :-).
--
Michal Čihař |
http://cihar.com |
http://phpmyadmin.cz