2 Aug
2011
2 Aug
'11
3:17 p.m.
Hi
Dne Fri, 22 Jul 2011 22:34:55 +0530 Madhura Jayaratne madhura.cj@gmail.com napsal(a):
Looking at the CheckStyle reports from the CI, all the export files show very high counts of indentation rule violations. The code in the 'else' block of 'if (isset($plugin_list))' condition is wrongly indented in all of these files.
There are two possible ways to correct this.
- Correctly indent the 'else' block
- Add 'return' statement to the end of 'if' block and remove 'else {' part.
Which one if preferred?
I'm not sure if return won't break something else, if you think it's safe, go for 2, otherwise 1.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com