9 Jul
2011
9 Jul
'11
11:17 p.m.
Hi Piotr,
----- Original Message -----
From: Piotr Przybylski <piotr.prz(a)gmail.com>
Hi,
I have two issues with this feature:
1. I see the tooltip "Click the drop-down arrow..." even when arrow
isn't visible (when I have only one column in result set)
Fixed in my git [0].
2. Clickable area with column name may not span correctly in available
space if columns have short names [1]. It may not look too bad in
English, but in Polish "Show all" translates to much longer
"Pokaż
wszystkie". Maybe checkboxes should be inside <label>s with
display:block instead of using table for layout? Or styled <dl>, but
this would require much more CSS to make it look right.
[1] http://img829.imageshack.us/img829/1531/hidecolumns.png
Fixed in my git [1]. For the fix, I use nested div, instead of table for layout.
Thank you for your feedback. :)
[0] commit dbf06b6a1ba2ea901351718aad8c1f92de286daa
[1] commit 7c4e0114e9d88120b6446eef88b3b9ad2203622c (but when merged to master, it caused
merge conflict, which is solved by commit 991deb415ba369d87b2a816feb0180660329b332)
--
Aris Feryanto
