2011/8/1 Michal Čihař <michal@cihar.com>:
Hi
Dne Fri, 22 Jul 2011 22:34:55 +0530 Madhura Jayaratne <madhura.cj@gmail.com> napsal(a):
Looking at the CheckStyle reports from the CI, all the export files show very high counts of indentation rule violations. The code in the 'else' block of 'if (isset($plugin_list))' condition is wrongly indented in all of these files.
There are two possible ways to correct this. 1) Correctly indent the 'else' block 2) Add 'return' statement to the end of 'if' block and remove 'else {' part.
Which one if preferred?
I don't think 2 will work, so out of these 1 is only solution. Rewrite it so that same functions are not defined in all plugins (using classes instead) would be preferable solution, though it is much more complex than reindenting :-).
Transforming the ilmport/export modules to Classes would be a nice GSoC project. ;) But probably not sufficient to fill 12 weeks, bu it can be part of a bigger OOP project.
-- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
------------------------------------------------------------------------------ Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Groetjes, Dieter Adriaenssens