28 Dec
2015
28 Dec
'15
10:57 a.m.
Hi all
while looking at our code, I've noticed quite inconsistent behavior for mbstring library.
- We require it. - We provide stubs to replace it in cases it's not there [1]. - We use it unconditionally in other places [2].
I think we should settle down to something more consistent :-). Given that requiring it didn't seem to cause much troubles, I'd simply chose this way, but I really don't have strong opinion on this.
[1]: in libraries/stringNative.lib.php [2]: eg. mb_detect_encoding in libraries/Util.class.php
--
Michal Čihař | http://cihar.com | http://blog.cihar.com