Hi,
we have a problem on our (new) demo on sf.net, because of the call to
session_name('phpMyAdmin') in libraries/session.inc.php. This is not supported
on sf.net.
Do we really need this in the code? Or can we detect in advance this problem?
Marc
Hi all
it's time to cleanup translations ;-). Following messages seems not to
be used anywhere in our code. Any objections to remove them?
strBinaryLogCache
strBookmarkOptions
strCarriage
strEngineDisabled
strIfYouWish
strInsertBookmarkTitle
strInsertTextfiles
strInstructions
strLineFeed
strLoadExplanation
strLoadMethod
strMoreStatusVars
strMustSelectFile
strNeedPrimaryKey
strNoQuery
strOftenQuotation
strOptionalControls
strOptionally
strPHP
strPos
strPrivDescAlterDb
strReplace
strRoutines
strSearchOption
strSearchOption
strSearchOption
strSearchOption
strTheContents
strTheContent
strTheTerminator
--
Michal Čihař | http://cihar.com
Garvin Hicking wrote:
> Hi!
>
>>> https://sourceforge.net/tracker/index.php?func=detail&aid=1312571&group_id=…
>>> 067&atid=377410
>>>
>> i would like to commit this into CVS, if no one is against.
>>
>> Marc? Michal?
>
> I think this portion:
>
> +foreach( $_GET as $key => $val ) {
> + if ( ! in_array( $key, $drops ) ) {
> + $url_querys[] = $key . '=' . $val;
> + }
>
> allows for XSS attacks to index.php which outputs remote input HTML/JS code.
uuh, sorry fixed this with
$url_querys[] = urlencode( $key ) . '=' . urlencode( $val );
> Added to that, it seems your patch kills the $cfg['LeftFrameTableSeparator']
> functionality of nested table groups in non-light mode. It seems you removed all
> the PMA_nestedSet() functionality without proper replacement of its content?
did you tried? or took you just a look at the code?
$cfg['LeftFrameTableSeparator'] is respected and should be properly
displayed - if not pls give me an example of your settings, what you
expect and what you got
thnx
--
Sebastian Mendel
www.sebastianmendel.dewww.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
Hi
as I'm constantly being spammed by those messages "I'm idiot and don't
read anything" from translators.html, I'd like to see some better
solution for this.
First problem comes from people not understanding English, so they just
write bellow our message Czech request for translation. This could be
solved either by translating message for each language in html file or
converting to php and using similar translation system as in rest of
phpMyAdmin.
However the majority of messages are just plain copies of our one. I
have no idea why people are so stupid and I actually do not see way how
to make sending feedback possible, but more restrictively saying that
there should really written something.
Anyway I thing we need to localise these messages, this should lower a
bit this spam rate. Comments?
--
Michal Čihař | http://cihar.com
