Hi all
I've made some changes at ci.phpmyadmin.net to make continuous
integration smoother:
- Coverage reports are generated only for daily tests, not for
continuous ones. They need to much time and I don't think they are
more useful in daily snapshots anyway. This reduces test run for
almost 20 minutes (we're now around 3.5 minute).
- The builds are now initiated by notifications from GitHub rather than
by polling, this should reduce delays when test is started.
I hope these changes will make usage more comfortable and will help
with creating good testsuite.
--
Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi Rouslan,
it seems that since the removal of header.inc.php, the display of PDF
relational schema no longer works.
--
Marc Delisle
http://infomarc.info
Hi Thilina,
Two days ago, I wrote to phpmyadmin-devel about this new bug:
---------
Thilina,
here is another bug to add (and work on): In the list of users (when
there are enough users), the initials of user names are displayed but in
your tree, clicking on an initial button does not bring the list of
users having this initial.
-------
and got no feedback on this list.
Please proceed with entering this new bug on the tracker.
If you start to refactor another section (for example Operations)
without fixing these bugs in the Privileges section, you'll have to
create another branch in your repo to work on the new refactoring
section. The reason is, it would be difficult to merge your new stuff
without merging the problematic Privileges refactoring done so far.
Your proposal mentions that August 6th – August 12th is for fixing all
remaining bugs, so I expect this will be done...
--
Marc Delisle
http://infomarc.info
Hi Thilina,
in your blog you wrote "I’m managing a Google Doc to track my remaining
bugs which are reported by mentor when he doing the commit reviews. So
there are three remaining bugs for privileges section."
It's ok to use a Google Doc for yourself, but please enter all bugs in
phpMyAdmin bug tracker too.
By the way, "three remaining bugs" are not for privileges section but
for Edit/insert, right?
And please enter these bugs in the tracker:
- already reported in github code review [0]: "when I edit a user's
privileges and add one global privilege to him, the list of global
privileges is not updated afterwards in the list of users"
- new bug seen today: When trying to copy a user (create a new user with
the same privileges and keep the old one), an invalid SQL query is
generated.
[0]
https://github.com/thilinaa/phpmyadmin/commit/1074f56e7b97d73bd731adceeda7b…
--
Marc Delisle
http://infomarc.info
Hi all,
As I am currently reviewing the configuration directives that are
related to the navigation system, I'd like to share what I've done so
far and also seek some advice.
So far, I've dropped the following 3 directives, as they won't really
make any sense in pma 4:
* AllowThirdPartyFraming
* LeftFrameLight
* DisplayDatabasesList
However I have a dilemma about some other directives. For example, the
old navigation system used the MaxDbList and MaxTableList directives to
decide how many items to render on a page. These directives are also
used by other code to display lists of dbs and tables in the main frame.
Anyway, I'd like to lower the default values for these directives from
100 and 250 respectively to 25. This is because the new navigation
system has excellent pagination and filtering capabilities, and
therefore I think that it would be better to save some vertical space.
That said, I think that it would be better to introduce a new directive
that will be only used in the navigation without affecting the display
of items in the main frame. For example: $cfg['NavigationItemsPerPage'].
I also found the following two directives: ShowTooltipAliasDB and
ShowTooltipAliasTB. These are currently unused in my branch as I'm not
even sure what they do. Could someone please enlighten me on their purpose?
And as a last question: Many configuration directives that relate to the
navigation start with "LeftFrame*", but as frames are being dropped is
it better to rename them to "Navigation*"?
Bye,
Rouslan
Hi All,
I have a doubt of using *@see* tag in Docblock comments for functions.
In the comments of functions PMA_getTable() and PMA_getTableBody() in
display_tbl.lib.php file, @see tag is used for different purposes.
As I feel PMA_getTableBody() used that corrrectly.
What should be the actual behavior ?
Regards !
--
____________________________________
Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________
Hi Rouslan,
While going through your commits I didn't notice any updates of the
Changelog so far. Are you keeping a list of changes, in particular a
list of config options you are dropping (like
'AllowThirdPartyFraming')?
--
Kind regards,
Dieter Adriaenssens