Developers July 2012

developers@phpmyadmin.net

11 participants
38 discussions

[Phpmyadmin-devel] ci.phpmyadmin.net changes
by Michal Čihař 23 Jul '12

23 Jul '12

Hi all I've made some changes at ci.phpmyadmin.net to make continuous integration smoother: - Coverage reports are generated only for daily tests, not for continuous ones. They need to much time and I don't think they are more useful in daily snapshots anyway. This reduces test run for almost 20 minutes (we're now around 3.5 minute). - The builds are now initiated by notifications from GitHub rather than by polling, this should reduce delays when test is started. I hope these changes will make usage more comfortable and will help with creating good testsuite. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

2 3

[Phpmyadmin-devel] Inline JPEG transformation fails
by Marc Delisle 22 Jul '12

22 Jul '12

Hi Alex, please have a look at [0]. [0] https://sourceforge.net/tracker/?func=detail&aid=3538666&group_id=23067&ati… -- Marc Delisle http://infomarc.info

3 17

[Phpmyadmin-devel] PMA_Header class and PDF display
by Marc Delisle 22 Jul '12

22 Jul '12

Hi Rouslan, it seems that since the removal of header.inc.php, the display of PDF relational schema no longer works. -- Marc Delisle http://infomarc.info

3 10

[Phpmyadmin-devel] about my message to phpmyadmin-devel
by Marc Delisle 21 Jul '12

21 Jul '12

Hi Thilina, Two days ago, I wrote to phpmyadmin-devel about this new bug: --------- Thilina, here is another bug to add (and work on): In the list of users (when there are enough users), the initials of user names are displayed but in your tree, clicking on an initial button does not bring the list of users having this initial. ------- and got no feedback on this list. Please proceed with entering this new bug on the tracker. If you start to refactor another section (for example Operations) without fixing these bugs in the Privileges section, you'll have to create another branch in your repo to work on the new refactoring section. The reason is, it would be difficult to merge your new stuff without merging the problematic Privileges refactoring done so far. Your proposal mentions that August 6th – August 12th is for fixing all remaining bugs, so I expect this will be done... -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] Thilina's remaining bugs
by Marc Delisle 19 Jul '12

19 Jul '12

Hi Thilina, in your blog you wrote "I’m managing a Google Doc to track my remaining bugs which are reported by mentor when he doing the commit reviews. So there are three remaining bugs for privileges section." It's ok to use a Google Doc for yourself, but please enter all bugs in phpMyAdmin bug tracker too. By the way, "three remaining bugs" are not for privileges section but for Edit/insert, right? And please enter these bugs in the tracker: - already reported in github code review [0]: "when I edit a user's privileges and add one global privilege to him, the list of global privileges is not updated afterwards in the list of users" - new bug seen today: When trying to copy a user (create a new user with the same privileges and keep the old one), an invalid SQL query is generated. [0] https://github.com/thilinaa/phpmyadmin/commit/1074f56e7b97d73bd731adceeda7b… -- Marc Delisle http://infomarc.info

2 7

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1701
by michal＠cihar.com 18 Jul '12

18 Jul '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1701/changes> Changes: [mcihar] Fix expected output [mcihar] Enable this test [mcihar] Add rule to test without coverage reports ------------------------------------------ [...truncated 168 lines...] [exec] +PHP VER,OS: 5.4.4-2 Linux [exec] +LANG: en [exec] +SQL: SELECT * from `aaa`</pre> [exec] +----END RAW----<br /> [exec] +' [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_SQ…>:20 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_SQ…>:168 [exec] /usr/bin/phpunit:46 [exec] [exec] 12) PMA_bookmark_test::testPMA_Bookmark_getParams [exec] false does not match expected type "array". [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_bo…>:62 [exec] /usr/bin/phpunit:46 [exec] [exec] 13) PMA_bookmark_test::testPMA_Bookmark_getList [exec] Failed asserting that two arrays are equal. [exec] --- Expected [exec] +++ Actual [exec] @@ @@ [exec] Array ( [exec] - 'id' => 'id (shared)' [exec] - 'label' => 'label (shared)' [exec] ) [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_bo…>:75 [exec] /usr/bin/phpunit:46 [exec] [exec] 14) PMA_bookmark_test::testPMA_Bookmark_get [exec] Failed asserting that two strings are equal. [exec] --- Expected [exec] +++ Actual [exec] @@ @@ [exec] -'SELECT query FROM `phpmyadmin`.`pma_bookmark` WHERE dbase = 'phpmyadmin' AND (user = 'root' OR user = '') AND `id` = 1' [exec] +'' [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_bo…>:91 [exec] /usr/bin/phpunit:46 [exec] [exec] 15) PMA_bookmark_test::testPMA_Bookmark_save [exec] Failed asserting that false is true. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_bo…>:111 [exec] /usr/bin/phpunit:46 [exec] [exec] 16) PMA_bookmark_test::testPMA_Bookmark_delete [exec] Failed asserting that false is true. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_bo…>:126 [exec] /usr/bin/phpunit:46 [exec] [exec] 17) PMA_build_html_for_db_test::testPMA_buildHtmlForDb with data set #0 (array('pma'), true, '', 'target=main.php', array('pma', 1, 'byte', 'onClick'), array('pma'), array(array('true', array('pma'))), array(array('pma', 1, 'byte', 'onClick'), '<td class="tool"><input type="checkbox" name="selected_dbs[]" class="checkall" title="pma" value="pma" /></td><td class="name"> <a onclick="if (window.parent.openDb && window.parent.openDb(\'pma\')) return false;" href="index.php?target=main.php&db=pma" title="Jump to database" target="_parent"> pma</a></td><td class="value"><dfn title="">pma</dfn></td><td class="tool" style="text-align: center;"><span class="nowrap"><img src="s_cancel.png" title="Not replicated" alt="Not replicated" /></span></td><td class="tool"><a onclick="if (window.parent.setDb) window.parent.setDb(\'`pma`\');" href="server_privileges.php?target=main.php&checkprivs=pma" title="Check privileges for database "pma"."> <span class="nowrap"><img src="s_rights.png" title="Check Privileges" alt="Check Privileges" /></span></a></td>')) [exec] Failed asserting that two arrays are equal. [exec] --- Expected [exec] +++ Actual [exec] @@ @@ [exec] Array ( [exec] 0 => Array (...) [exec] - 1 => '<td class="tool"><input type="checkbox" name="selected_dbs[]" class="checkall" title="pma" value="pma" /></td><td class="name"> <a onclick="if (window.parent.openDb && window.parent.openDb('pma')) return false;" href="index.php?target=main.php&db=pma" title="Jump to database" target="_parent"> pma</a></td><td class="value">pma</td><td class="tool" style="text-align: center;"><span class="nowrap"><img src="s_cancel.png" title="Not replicated" alt="Not replicated" /></span></td>' [exec] + 1 => '<td class="tool"><input type="checkbox" name="selected_dbs[]" class="checkall" title="pma" value="pma" /></td><td class="name"> <a onclick="if (window.parent.openDb && window.parent.openDb('pma')) return false;" href="index.php?target=main.php&db=pma" title="Jump to database" target="_parent"> pma</a></td><td class="value"><dfn title="">pma</dfn></td><td class="tool" style="text-align: center;"><span class="nowrap"><img src="s_cancel.png" title="Not replicated" alt="Not replicated" /></span></td><td class="tool"><a onclick="if (window.parent.setDb) window.parent.setDb('`pma`');" href="server_privileges.php?target=main.php&checkprivs=pma" title="Check privileges for database "pma"."> <span class="nowrap"><img src="s_rights.png" title="Check Privileges" alt="Check Privileges" /></span></a></td>' [exec] ) [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_bu…>:118 [exec] /usr/bin/phpunit:46 [exec] [exec] -- [exec] [exec] [exec] There were 4 incomplete tests: [exec] [exec] 1) PMA_ConfigTest::testCheckIsHttps [exec] This test has not been implemented yet. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Conf…>:598 [exec] /usr/bin/phpunit:46 [exec] [exec] 2) PMA_ConfigTest::testGetThemeUniqueValue [exec] This test has not been implemented yet. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Conf…>:705 [exec] /usr/bin/phpunit:46 [exec] [exec] 3) PMA_ConfigTest::testCheckPermissions [exec] This test has not been implemented yet. [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Conf…>:718 [exec] /usr/bin/phpunit:46 [exec] [exec] 4) PMA_whichCrlf_test::testWhichCrlf [exec] Cannot redefine constant [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/common…>:42 [exec] /usr/bin/phpunit:46 [exec] [exec] -- [exec] [exec] [exec] There were 5 skipped tests: [exec] [exec] 1) PMA_headerLocation_test::testSendHeaderLocationWithSidUrlWithQuestionMark [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:177 [exec] /usr/bin/phpunit:46 [exec] [exec] 2) PMA_headerLocation_test::testSendHeaderLocationWithSidUrlWithoutQuestionMark [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:197 [exec] /usr/bin/phpunit:46 [exec] [exec] 3) PMA_headerLocation_test::testSendHeaderLocationWithoutSidWithIis [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:218 [exec] /usr/bin/phpunit:46 [exec] [exec] 4) PMA_headerLocation_test::testSendHeaderLocationWithoutSidWithoutIis [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:234 [exec] /usr/bin/phpunit:46 [exec] [exec] 5) PMA_headerLocation_test::testSendHeaderLocationIisLongUri [exec] Cannot redefine constant/function - missing APD or/and runkit extension [exec] [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/core/P…>:246 [exec] /usr/bin/phpunit:46 [exec] [exec] FAILURES! [exec] Tests: 977, Assertions: 1725, Failures: 17, Incomplete: 4, Skipped: 5. [exec] Result: 1 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 11 exact clones with 364 duplicated lines in 9 files: [exec] [exec] - /libraries/plugins/export/ExportLatex.class.php:130-143 [exec] /libraries/plugins/export/ExportOdt.class.php:85-98 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:629-655 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:678-704 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:425-446 [exec] /libraries/schema/Svg_Relation_Schema.class.php:392-413 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:473-482 [exec] /libraries/schema/Svg_Relation_Schema.class.php:442-451 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:608-658 [exec] /libraries/schema/Svg_Relation_Schema.class.php:589-639 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:425-446 [exec] /libraries/schema/Visio_Relation_Schema.class.php:223-244 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:608-664 [exec] /libraries/schema/Visio_Relation_Schema.class.php:376-432 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:753-774 [exec] /libraries/schema/Visio_Relation_Schema.class.php:578-599 [exec] [exec] - /themes/original/css/common.css.php:1271-1292 [exec] /themes/original/css/common.css.php:1275-1296 [exec] [exec] - /themes/original/css/common.css.php:1215-1323 [exec] /themes/pmahomme/css/common.css.php:1574-1682 [exec] [exec] 0.27% duplicated lines out of 133068 total lines of code. [exec] [exec] Time: 7 seconds, Memory: 108.75Mb [exec] Result: 1 phpcs: [exec] Time: 02:20, Memory: 178.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 26 [exec] Files: 350 [exec] [exec] Lines of Code (LOC): 133068 [exec] Cyclomatic Complexity / Lines of Code: 0.14 [exec] Comment Lines of Code (CLOC): 40511 [exec] Non-Comment Lines of Code (NCLOC): 92557 [exec] [exec] Namespaces: 0 [exec] Interfaces: 2 [exec] Classes: 156 [exec] Abstract: 20 (12.82%) [exec] Concrete: 136 (87.18%) [exec] Average Class Length (NCLOC): 243 [exec] Methods: 1442 [exec] Scope: [exec] Non-Static: 1268 (87.93%) [exec] Static: 174 (12.07%) [exec] Visibility: [exec] Public: 1058 (73.37%) [exec] Non-Public: 384 (26.63%) [exec] Average Method Length (NCLOC): 26 [exec] Cyclomatic Complexity / Number of Methods: 4.20 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 545 [exec] [exec] Constants: 154 [exec] Global constants: 102 [exec] Class constants: 52 BUILD SUCCESSFUL Total time: 2 minutes 50 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 8039 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1700 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 21 warnings. [DRY] Computing warning deltas based on reference build #1700 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 469 files to scan for tasks [TASKS] Found 200 open tasks. [TASKS] Computing warning deltas based on reference build #1700 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1700 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-07-18_15-11-22/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage'> exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [INFO] - Check 'Failed Tests' threshold. [xUnit] [INFO] - Check 'Skipped Tests' threshold. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 1

[Phpmyadmin-devel] Configuration directives for the navigation
by Rouslan Placella 16 Jul '12

16 Jul '12

Hi all, As I am currently reviewing the configuration directives that are related to the navigation system, I'd like to share what I've done so far and also seek some advice. So far, I've dropped the following 3 directives, as they won't really make any sense in pma 4: * AllowThirdPartyFraming * LeftFrameLight * DisplayDatabasesList However I have a dilemma about some other directives. For example, the old navigation system used the MaxDbList and MaxTableList directives to decide how many items to render on a page. These directives are also used by other code to display lists of dbs and tables in the main frame. Anyway, I'd like to lower the default values for these directives from 100 and 250 respectively to 25. This is because the new navigation system has excellent pagination and filtering capabilities, and therefore I think that it would be better to save some vertical space. That said, I think that it would be better to introduce a new directive that will be only used in the navigation without affecting the display of items in the main frame. For example: $cfg['NavigationItemsPerPage']. I also found the following two directives: ShowTooltipAliasDB and ShowTooltipAliasTB. These are currently unused in my branch as I'm not even sure what they do. Could someone please enlighten me on their purpose? And as a last question: Many configuration directives that relate to the navigation start with "LeftFrame*", but as frames are being dropped is it better to rename them to "Navigation*"? Bye, Rouslan

4 9

[Phpmyadmin-devel] Failing test
by Michal Čihař 15 Jul '12

15 Jul '12

Hi all (and especially Yasitha) I've merged some new test cases, but we're getting more and more failures: http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/lastCompletedBuild/testR… Most of them being caused by not properly set up environment - they silently expect some parameters are unset while they are set by other testcase (usually things like server, db or token). -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

4 16

[Phpmyadmin-devel] Refactoring: Displaying query results
by Chanaka Dharmarathna 14 Jul '12

14 Jul '12

Hi All, I have a doubt of using *@see* tag in Docblock comments for functions. In the comments of functions PMA_getTable() and PMA_getTableBody() in display_tbl.lib.php file, @see tag is used for different purposes. As I feel PMA_getTableBody() used that corrrectly. What should be the actual behavior ? Regards ! -- ____________________________________ Chanaka Indrajith Bsc.Computer Engineering Undergraduate Faculty of Engineering University of Peradeniya Sri Lanka ____________________________________

8 48

[Phpmyadmin-devel] Changelog and list of dropped config options
by Dieter Adriaenssens 13 Jul '12

13 Jul '12

Hi Rouslan, While going through your commits I didn't notice any updates of the Changelog so far. Are you keeping a list of changes, in particular a list of config options you are dropping (like 'AllowThirdPartyFraming')? -- Kind regards, Dieter Adriaenssens

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers July 2012