Hi,
I just made a suggestion to Thilina but I want to validate it with
everyone.
I see a lot of
$common_functions = PMA_CommonFunctions::getInstance()
inside many functions of the same library. If we know that this library
is always called from one script, I believe it would be more efficient
to do this instead, inside the functions:
global $common_functions;
and ensure that $common_functions has been defined in the global scope
of the calling script.
--
Marc Delisle
http://infomarc.info
Hi
as you've probably noticed from incoming mails, the testsuite was
pretty much broken in last days. It turned out to be caused by
testLoadCss, which produces quite a lot of output and probably breaks
something inside phpunit (I gave up at this point you're welcome to
investigate more).
So right now the testsuite is again running and you're welcome to
investigate failing tests, especially if they appear in code you were
recently touching:
http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/lastCompletedBuild/testR…
--
Michal Čihař | http://cihar.com | http://phpmyadmin.cz
Hi Atul and Thilina,
please watch for the recent changes that were merged to upstream master
regarding the new PMA_CommonFunctions class.
You'll have to be extra careful with the code that exists only in your
repo, when merging upstream master into your repo. Have a look at [0] to
see what needs to be done to solve the conflicts.
[0]
https://github.com/phpmyadmin/phpmyadmin/commit/2d055c8190117cf962f6c43d401…
--
Marc Delisle
http://infomarc.info
Hi Chanaka,
Just spotted the below error when clicking on "Create Version" after
selecting the "Tracking" tab at table level.
Fatal error: Call to undefined function PMA_getPlugin() in
/home/www/pma/libraries/Tracker.class.php on line 270
I'm surprised that you didn't grep for every function that you have
renamed to ensure that there are no more occurrences of the old function
names before merging with upstream o_O
Bye,
Rouslan
Hi Marc,
There are two hard coded values in server_privileges.lib.php script which
username and hostname lengths. (line 849). Can we define those values in a
config file and access using $GLOBAL['cfg']['username_length'] and
$GLOBAL['cfg']['hostname_length'], Then it'll maintainable.
--
Regards.
Thilina Abeyrathna
Gtalk : thilinaabeyrathna
skype: thilinabuddika88
thilinaa.wordpress.com
Hi Thilina,
I prefer that you fix bugs in your previous refactoring before starting
a new sub-project (you have started work on server_privileges.php)
Please compile a list of these bugs, open artefacts on our bug tracker
and reply here references to these bugs, in one post. I will then verify
to ensure we did not miss anything.
--
Marc Delisle
http://infomarc.info