Developers July 2012

developers@phpmyadmin.net

11 participants
38 discussions

[Phpmyadmin-devel] about $common_functions
by Marc Delisle 03 Jul '12

03 Jul '12

Hi, I just made a suggestion to Thilina but I want to validate it with everyone. I see a lot of $common_functions = PMA_CommonFunctions::getInstance() inside many functions of the same library. If we know that this library is always called from one script, I believe it would be more efficient to do this instead, inside the functions: global $common_functions; and ensure that $common_functions has been defined in the global scope of the calling script. -- Marc Delisle http://infomarc.info

3 10

[Phpmyadmin-devel] Tests breakage
by Michal Čihař 03 Jul '12

03 Jul '12

Hi as you've probably noticed from incoming mails, the testsuite was pretty much broken in last days. It turned out to be caused by testLoadCss, which produces quite a lot of output and probably breaks something inside phpunit (I gave up at this point you're welcome to investigate more). So right now the testsuite is again running and you're welcome to investigate failing tests, especially if they appear in code you were recently touching: http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/lastCompletedBuild/testR… -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

1 0

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #1635
by michal＠cihar.com 03 Jul '12

03 Jul '12

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1635/changes> Changes: [yasitha4] Test cases for Error.class.php [yasitha4] Test cases for Error_Handler.php ------------------------------------------ Started by an SCM change Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@38f18cc3 Using strategy: Default Last Built Revision: Revision 0953df2fe4de6eb353b9fa19519955b81d37c7fe (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from git://github.com/phpmyadmin/phpmyadmin.git Commencing build of Revision 366b83e97a954ddf9789f48974adab820a6fa925 (origin/master) Checking out Revision 366b83e97a954ddf9789f48974adab820a6fa925 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson5687313977266396228.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit phpcpd phpcs phploc Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit: [exec] PHPUnit 3.6.10 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.dist> [exec] [exec] ..........Compile Error [exec] ................................FI........II......... 63 / 834 ( 7%) [exec] ...FF...............F.......................................... 126 / 834 ( 15%) [exec] .................................F..F.......syntax_indent0 {margin-left: 0em;} [exec] .syntax_indent1 {margin-left: 1em;} [exec] .syntax_indent2 {margin-left: 2em;} [exec] .syntax_indent3 {margin-left: 3em;} [exec] .syntax_indent4 {margin-left: 4em;} [exec] .syntax_indent5 {margin-left: 5em;} [exec] .syntax_indent6 {margin-left: 6em;} [exec] .syntax_indent7 {margin-left: 7em;} [exec] [exec] /* FILE: common.css.php */ [exec] /******************************************************************************/ [exec] [exec] /* general tags */ [exec] html { [exec] font-size: PHP Fatal error: Call to a member function get() on a non-object in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/Theme.class…> on line 488 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:130 [exec] PHP 4. PHPUnit_TextUI_TestRunner->doRun() /usr/share/php/PHPUnit/TextUI/Command.php:192 [exec] PHP 5. PHPUnit_Framework_TestSuite->run() /usr/share/php/PHPUnit/TextUI/TestRunner.php:325 [exec] PHP 6. PHPUnit_Framework_TestSuite->run() /usr/share/php/PHPUnit/Framework/TestSuite.php:705 [exec] PHP 7. PHPUnit_Framework_TestSuite->run() /usr/share/php/PHPUnit/Framework/TestSuite.php:705 [exec] PHP 8. PHPUnit_Framework_TestSuite->runTest() /usr/share/php/PHPUnit/Framework/TestSuite.php:745 [exec] PHP 9. PHPUnit_Framework_TestCase->run() /usr/share/php/PHPUnit/Framework/TestSuite.php:772 [exec] PHP 10. PHPUnit_Framework_TestResult->run() /usr/share/php/PHPUnit/Framework/TestCase.php:751 [exec] PHP 11. PHP_Invoker->invoke() /usr/share/php/PHPUnit/Framework/TestResult.php:647 [exec] PHP 12. call_user_func_array() /usr/share/php/PHP/Invoker.php:93 [exec] PHP 13. PHPUnit_Framework_TestCase->runBare() /usr/share/php/PHP/Invoker.php:93 [exec] PHP 14. PHPUnit_Framework_TestCase->runTest() /usr/share/php/PHPUnit/Framework/TestCase.php:804 [exec] PHP 15. ReflectionMethod->invokeArgs() /usr/share/php/PHPUnit/Framework/TestCase.php:942 [exec] PHP 16. PMA_ThemeTest->testLoadCssWrongType() /usr/share/php/PHPUnit/Framework/TestCase.php:942 [exec] PHP 17. PMA_Theme->loadCss() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Them…>:210 [exec] PHP 18. include() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/Theme.class…>:420 [exec] PHP 19. PMA_Theme->getFontSize() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:19 [exec] Result: 255 phpcpd: [exec] phpcpd 1.3.5 by Sebastian Bergmann. [exec] [exec] Found 12 exact clones with 361 duplicated lines in 9 files: [exec] [exec] - /libraries/plugins/export/ExportLatex.class.php:130-143 [exec] /libraries/plugins/export/ExportOdt.class.php:85-98 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:628-654 [exec] /libraries/schema/Pdf_Relation_Schema.class.php:650-676 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:282-300 [exec] /libraries/schema/Svg_Relation_Schema.class.php:277-295 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Svg_Relation_Schema.class.php:391-407 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Svg_Relation_Schema.class.php:441-449 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-657 [exec] /libraries/schema/Svg_Relation_Schema.class.php:588-638 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:424-440 [exec] /libraries/schema/Visio_Relation_Schema.class.php:222-238 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:472-480 [exec] /libraries/schema/Visio_Relation_Schema.class.php:272-280 [exec] [exec] - /libraries/schema/Eps_Relation_Schema.class.php:607-663 [exec] /libraries/schema/Visio_Relation_Schema.class.php:375-431 [exec] [exec] - /libraries/schema/Dia_Relation_Schema.class.php:752-773 [exec] /libraries/schema/Visio_Relation_Schema.class.php:577-598 [exec] [exec] - /themes/original/css/common.css.php:1271-1292 [exec] /themes/original/css/common.css.php:1275-1296 [exec] [exec] - /themes/original/css/common.css.php:1215-1323 [exec] /themes/pmahomme/css/common.css.php:1574-1682 [exec] [exec] 0.28% duplicated lines out of 131085 total lines of code. [exec] [exec] Time: 7 seconds, Memory: 105.25Mb [exec] Result: 1 phpcs: [exec] Time: 02:16, Memory: 178.00Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.6.4 by Sebastian Bergmann. [exec] [exec] Directories: 26 [exec] Files: 350 [exec] [exec] Lines of Code (LOC): 131085 [exec] Cyclomatic Complexity / Lines of Code: 0.14 [exec] Comment Lines of Code (CLOC): 39988 [exec] Non-Comment Lines of Code (NCLOC): 91097 [exec] [exec] Namespaces: 0 [exec] Interfaces: 2 [exec] Classes: 154 [exec] Abstract: 20 (12.99%) [exec] Concrete: 134 (87.01%) [exec] Average Class Length (NCLOC): 219 [exec] Methods: 1331 [exec] Scope: [exec] Non-Static: 1159 (87.08%) [exec] Static: 172 (12.92%) [exec] Visibility: [exec] Public: 967 (72.65%) [exec] Non-Public: 364 (27.35%) [exec] Average Method Length (NCLOC): 25 [exec] Cyclomatic Complexity / Number of Methods: 4.07 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 620 [exec] [exec] Constants: 152 [exec] Global constants: 102 [exec] Class constants: 50 BUILD SUCCESSFUL Total time: 2 minutes 38 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 7281 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #1634 [DRY] Collecting duplicate code analysis files... [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 22 warnings. [DRY] Computing warning deltas based on reference build #1634 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 461 files to scan for tasks [TASKS] Found 201 open tasks. [TASKS] Computing warning deltas based on reference build #1634 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #1634 Recording plot data Publishing Clover coverage report... Clover xml file does not exist in: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> called: clover.xml and will not be copied to: /var/lib/jenkins/jobs/phpMyAdmin-continuous/builds/2012-07-01_11-42-01/clover.xml Could not find 'build/logs/clover.xml'. Did you generate the XML report for Clover? [htmlpublisher] Archiving HTML reports... [htmlpublisher] Archiving at PROJECT level <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> to /var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage ERROR: Directory '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage'> exists but failed copying to '/var/lib/jenkins/jobs/phpMyAdmin-continuous/htmlreports/Code_Coverage'. ERROR: This is especially strange since your build otherwise succeeded. Build step 'Publish HTML reports' changed build result to FAILURE [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.4 (default) [xUnit] [INFO] - [PHPUnit-3.4 (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.4 (default)'. [xUnit] [ERROR] - The result file '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml'> for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Setting the build status to FAILURE [xUnit] [INFO] - Stopping recording.

1 16

[Phpmyadmin-devel] Changes in upstream master for common functions
by Marc Delisle 03 Jul '12

03 Jul '12

Hi Atul and Thilina, please watch for the recent changes that were merged to upstream master regarding the new PMA_CommonFunctions class. You'll have to be extra careful with the code that exists only in your repo, when merging upstream master into your repo. Have a look at [0] to see what needs to be done to solve the conflicts. [0] https://github.com/phpmyadmin/phpmyadmin/commit/2d055c8190117cf962f6c43d401… -- Marc Delisle http://infomarc.info

3 2

[Phpmyadmin-devel] FAO Chanaka: Error in master
by Rouslan Placella 03 Jul '12

03 Jul '12

Hi Chanaka, Just spotted the below error when clicking on "Create Version" after selecting the "Tracking" tab at table level. Fatal error: Call to undefined function PMA_getPlugin() in /home/www/pma/libraries/Tracker.class.php on line 270 I'm surprised that you didn't grep for every function that you have renamed to ensure that there are no more occurrences of the old function names before merging with upstream o_O Bye, Rouslan

4 5

[Phpmyadmin-devel] Thilina's refactoring and unit testing
by Marc Delisle 01 Jul '12

01 Jul '12

Hi Thilina, have you written "some unit tests" for insert/edit, as per your proposal? -- Marc Delisle http://infomarc.info

3 3

[Phpmyadmin-devel] server_privileges refactoring
by Thilina Buddika Abeyrathna 01 Jul '12

01 Jul '12

Hi Marc, There are two hard coded values in server_privileges.lib.php script which username and hostname lengths. (line 849). Can we define those values in a config file and access using $GLOBAL['cfg']['username_length'] and $GLOBAL['cfg']['hostname_length'], Then it'll maintainable. -- Regards. Thilina Abeyrathna Gtalk : thilinaabeyrathna skype: thilinabuddika88 thilinaa.wordpress.com

2 6

[Phpmyadmin-devel] about Thilina's schedule
by Marc Delisle 30 Jun '12

30 Jun '12

Hi Thilina, I prefer that you fix bugs in your previous refactoring before starting a new sub-project (you have started work on server_privileges.php) Please compile a list of these bugs, open artefacts on our bug tracker and reply here references to these bugs, in one post. I will then verify to ensure we did not miss anything. -- Marc Delisle http://infomarc.info

2 9

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers July 2012