Hi,
The favorite tables feature is now in master. The expected place to
store favorite tables is in pmadb and this is what it does. However it
can also store them in the session if pmadb is not ready for this feature.
I am not sure of the purpose of storing this in the session; on the
contrary, it can make the user believe that the favorite tables have
been stored, only to see them gone at the next login.
Comments?
--
Marc Delisle
See <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/5882/changes>
Changes:
[Michal Čihař] Set browserstack.local flag for Travis builds
[Michal Čihař] Use hardcoded port
[Michal Čihař] Set build identifier for local builds
[Michal Čihař] Wait for load
[Michal Čihař] Enable BrowserStack debugging
------------------------------------------
[...truncated 157 lines...]
[exec] 16) PMA_SeleniumExportTest::testServerImport with data set #1 ('SQL', array('CREATE TABLE IF NOT EXISTS `test_table`', 'INSERT INTO `test_table` (`id`, `val`) VALUES', '(1, 2);'))
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 17) PMA_SeleniumExportTest::testServerImport with data set #2 ('JSON', array('[{"id":"1","val":"2"}]'))
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 18) PMA_SeleniumExportTest::testDbExport with data set #0 ('CSV', array('"1","2"'))
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 19) PMA_SeleniumExportTest::testDbExport with data set #1 ('SQL', array('CREATE TABLE IF NOT EXISTS `test_table`', 'INSERT INTO `test_table` (`id`, `val`) VALUES', '(1, 2);'))
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 20) PMA_SeleniumExportTest::testDbExport with data set #2 ('JSON', array('[{"id":"1","val":"2"}]'))
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 21) PMA_SeleniumExportTest::testTableExport with data set #0 ('CSV', array('"1","2"'))
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 22) PMA_SeleniumExportTest::testTableExport with data set #1 ('SQL', array('CREATE TABLE IF NOT EXISTS `test_table`', 'INSERT INTO `test_table` (`id`, `val`) VALUES', '(1, 2);'))
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 23) PMA_SeleniumExportTest::testTableExport with data set #2 ('JSON', array('[{"id":"1","val":"2"}]'))
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 24) PMA_SeleniumImportTest::testServerImport
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 25) PMA_SeleniumImportTest::testDbImport
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 26) PMA_SeleniumImportTest::testTableImport
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 27) PMA_SeleniumLoginTest::testSuccessfulLogin
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 28) PMA_SeleniumLoginTest::testLoginWithWrongPassword
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 29) PMA_SeleniumPrivilegesTest::testChangePassword
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 30) PMA_SeleniumSettingsTest::testHideDatabase
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 31) PMA_SeleniumSettingsTest::testSettingsTabsAreDisplayed
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 32) PMA_SeleniumSettingsTest::testHideLogo
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 33) PMA_SeleniumTableBrowseTest::testSortRecords
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 34) PMA_SeleniumTableBrowseTest::testChangeRecords
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 35) PMA_SeleniumTableBrowseTest::testChangeRecordsByDoubleClick
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 36) PMA_SeleniumTableBrowseTest::testCopyRecords
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 37) PMA_SeleniumTableBrowseTest::testSearchRecords
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 38) PMA_SeleniumTableBrowseTest::testDeleteRecords
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 39) PMA_SeleniumTableCreateTest::testCreateTable
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 40) PMA_SeleniumTableInsertTest::testAddData
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 41) PMA_SeleniumTableOperationsTest::testChangeTableOrder
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 42) PMA_SeleniumTableOperationsTest::testMoveTable
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 43) PMA_SeleniumTableOperationsTest::testRenameTable
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 44) PMA_SeleniumTableOperationsTest::testCopyTable
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 45) PMA_SeleniumTableOperationsTest::testTruncateTable
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 46) PMA_SeleniumTableOperationsTest::testDropTable
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 47) PMA_SeleniumTableStructureTest::testAddColumn
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 48) PMA_SeleniumTableStructureTest::testChangeColumn
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 49) PMA_SeleniumTableStructureTest::testDropColumns
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 50) PMA_SeleniumTrackingTest::testTrackingData
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 51) PMA_SeleniumTrackingTest::testDeactivateTracking
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 52) PMA_SeleniumTrackingTest::testDropTracking
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 53) PMA_SeleniumTrackingTest::testStructureSnapshot
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] 54) PMA_SeleniumXSSTest::testQueryTabWithNullValue
[exec] PHPUnit_Extensions_Selenium2TestCase_WebDriverException: [browserstack.local] is set to true but local testing through BrowserStack is not connected.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:153
[exec]
[exec] --
[exec]
[exec] There were 2 incomplete tests:
[exec]
[exec] 1) PMA_DisplayResults_Test::testGetTableNavigation with data set #0 (21, 41, '123', false, '310')
[exec] Not yet implemented!
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/classes/PMA_Dis…>:439
[exec]
[exec] 2) PMA_TblColumnsDefinitionFormTest::testGetFormParamsForOldColumn
[exec] Not yet implemented!
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_t…>:1110
[exec]
[exec] --
[exec]
[exec] There were 2 skipped tests:
[exec]
[exec] 1) PMA_SeleniumCreateDropDatabaseTest::testCreateDropDatabase
[exec] Test user is not a superuser.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:223
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:30
[exec]
[exec] 2) PMA_SeleniumCreateRemoveUserTest::testCreateRemoveUser
[exec] Test user is not a superuser.
[exec]
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/TestBa…>:223
[exec] <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/selenium/PmaSel…>:45
[exec] [37;41m [0m
[exec] [37;41mFAILURES! [0m
[exec] [37;41mTests: 2257, Assertions: 5201, Errors: 54, Incomplete: 2, Skipped: 2.[0m
BUILD FAILED
<https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml>:33: exec returned: 2
Total time: 43 seconds
Build step 'Invoke Ant' marked build as failure
[CHECKSTYLE] Skipping publisher since build result is FAILURE
[JSLINT] Skipping publisher since build result is FAILURE
[PMD] Skipping publisher since build result is FAILURE
[DRY] Collecting duplicate code analysis files...
[DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml
[DRY] Computing warning deltas based on reference build #5881
[TASKS] Skipping publisher since build result is FAILURE
[ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #5881
Recording plot data
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing PHPUnit-3.x (default)
[xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'.
[xUnit] [INFO] - Check 'Failed Tests' threshold.
[xUnit] [INFO] - Check 'Skipped Tests' threshold.
[xUnit] [INFO] - Setting the build status to FAILURE
[xUnit] [INFO] - Stopping recording.
On Thu, Mar 27, 2014 at 4:26 AM, Marc Delisle <marc(a)infomarc.info> wrote:
> Hi,
>
> The favorite tables feature is now in master. The expected place to
> store favorite tables is in pmadb and this is what it does. However it
> can also store them in the session if pmadb is not ready for this feature.
>
> I am not sure of the purpose of storing this in the session; on the
> contrary, it can make the user believe that the favorite tables have
> been stored, only to see them gone at the next login.
>
> Comments?
>
> --
> Marc Delisle
>
> Hi,
I agree with you that it should not be stored in session.
--
Chirayu Chiripal