Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Is PMA_STR_binarySearchInArr needed?
by Piotr Przybylski 08 Jun '11

08 Jun '11

Hi, For some time I was curious whether PMA_STR_binarySearchInArr is needed at all, and my test showed that there are faster (sometimes much faster) alternatives. Test for 100 000 iterations on PHP 5.3.4 (Windows, i5 2,53 GHz core): PMA_STR_binarySearchInArr: 2.6606s array_search: 1.8936s isset: 0.0102s array_key_exists: 0.0934s Isset and array_key_exists require flipped array, but array_search is a drop-in replacement that works faster, even though it does a linear search. Code used to perform this test is at [1]. [1] http://pastebin.com/cJmpmCPh -- Piotr Przybylski

4 17

[Phpmyadmin-devel] 3 patch suggestions for master
by Tyron Madlener 08 Jun '11

08 Jun '11

Since I always have a love for details, here's 3 small suggestions that maybe can be merged into the master branch. They are all pushed to my fork (http://repo.or.cz/w/phpmyadmin/tyronm.git): - Commit a0302c666c1bf9f9715364a6301238b474aedac1 Removes timepicker.js. It is already included with the jquery ui. The file was included only in tbl_change.php and tbl_select.php - Commit b161f43ec9089e0d2d5fb8a619056e6f9577a380 When reloading (flushing) privileges on the privileges tab you get a 5 second long success message. This commit omits the success message and removes the loading message as soon as the ajax request is done. This behavior seems more consistent with my patch in April that removes messages once the ajax request is completed. - Commit 99775c9bad552aac8b904996d673f1023821ab13 Removes the initials table on the privileges tab if there is 20 or less privileges to show. With 1-20 privileges you can easily see all host names and don't need any filtering by initials imo. I would even increase that limit to 30 or so.

3 13

[Phpmyadmin-devel] phpMyAdmin 3.4.2 is released
by Marc Delisle 07 Jun '11

07 Jun '11

Welcome to phpMyAdmin 3.4.2, a bugfix release. Details will appear on http://phpmyadmin.net. In a hurry? you can visit http://sourceforge.net/projects/phpmyadmin to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] about strInsertTable
by Marc Delisle 07 Jun '11

07 Jun '11

Thilanka, I'm not sure where this message will appear exactly but I suggest replacing it with "Insert in table" with just the "I" of Insert in uppercase. By the way, in messages we are trying to avoid using uppercase for all words. -- Marc Delisle http://infomarc.info

1 0

[Phpmyadmin-devel] ready for 3.4.2 ?
by Marc Delisle 07 Jun '11

07 Jun '11

Seeing no negative report about the RC1, I would release today. -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] Merging server pages
by Tyron Madlener 06 Jun '11

06 Jun '11

I'd like to merge some of the server pages, so that we have a smaller menu and less links ending up in the 'More' tab. What I have done already is put the processes table into the status page as it fits very well into the server traffic (jquery-)tab. And secondly I would merge together Engines, Charsets, Replication and Variables into a (jquery-)tab-separated page named "Configuration" Since an average user rarely requires the information supplied on those pages I think it is a good idea to free up the space in the menu bar. Any objections on this? :)

5 11

[Phpmyadmin-devel] Hardcoded array sizes in sqlparser.data.php
by Piotr Przybylski 06 Jun '11

06 Jun '11

Hi, Is there any reason for hardcoding array sizes in sqlparser.data.php? count()'s complexity is O(1), it just reads item count from hash table which is used internally for storing arrays. -- Regards, Piotr Przybylski

2 2

[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Add a new user in db-> privileges
by Thilanka Kaushalya 05 Jun '11

05 Jun '11

Hi Marc, I started working on improving the "*Add a new user in db-> privileges*" by providing a dialog such as in "*Add a new user in Server->privilege*" option. In that case I'm going to reuse the code in "(#fieldset_add_user).click" action in server_privileges.js file. The only modification I had to do is add the class="ajax" to link on db->privileges and now it pops up the dialog box. The next part is, after adding a new user we have to add that user to the list table in db->privileges and then sort it according to the alphabetical order of user names. In server->privileges, "*appendNewUser() in server_privileges.js" *method has used and it is sorting the rows be selecting the first character in the label and then according to that. It is okay because server->privileges table has same type of rows. But in "* db->privileges*" table it has used two type of rows where one shows columns related to "global" privileges and other is to database specific privileges corresponding to each user. So I cannot use the same "*appendNewUser() in server_privileges.js"* method to add and sort the table. I came up with some approaches to overcome this problem. 1. Change the table structure where do not use two rows but use same row and line break to get them down. In this case I'll be able to reuse the same method where I think more appropriate in this case. 2. Do a refresh to the "*db->privileges*" page so it reloads the table. 3. Keep the table as it is in current and develop a method to sort it. I'm confused with what method to use. So please can you clarify me on this problem. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya(a)gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya(a)yahoo.com Blog : http://coders-view.blogspot.com/

3 20

[Phpmyadmin-devel] .gitignore /locale/ for external libraries
by Dieter Adriaenssens 05 Jun '11

05 Jun '11

Hi, With commit 78b6f3d6 by Michal, /locale/ gets ignored in master. For the PHPExcel library this means the /locale/ directory is no longer under sourcecontrol. I don't think we use the translations for PHPExcel, and they probably can be removed (during the planned process of stripping the parts of that library we don't use), but maybe we should keep them for now? Or not, as it probably doesn't break exporting and it only affects master and should be solved by the release of 3.5 -- Kind regards,, Dieter Adriaenssens

2 6

[Phpmyadmin-devel] GSoC Drizzle : wording on main page
by Dieter Adriaenssens 04 Jun '11

04 Jun '11

Hi Piotr, In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section. [0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce02… -- Kind regards, Dieter Adriaenssens

3 9

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers