I was looking at some of the deprecation notices we're getting from
jQuery after #12447 [1], and, while we can fix a lot of them
ourselves, some seem to be in libraries we're using.
After a quick grep of the code, I see jqplot, several jquery files,
and openlayers seem to be affected.
One of the deprecated functions is bind(). We're using jquery-migrate
right now, so how much of a concern are these issues? I suppose we
should fix the deprecated uses in our code, but should we worry about
the libraries? Is this something I should look at before 4.7 or should
we target 4.8 for these fixes, since nothing is technically broken
right now?
Isaac
1 - https://github.com/phpmyadmin/phpmyadmin/issues/12447
See <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/12618/>
------------------------------------------
Started by GitHub push by nijel
[EnvInject] - Loading node environment variables.
Building in workspace <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/phpmyadmin/phpmyadmin.git # timeout=10
Fetching upstream changes from https://github.com/phpmyadmin/phpmyadmin.git
> git --version # timeout=10
> git -c core.askpass=true fetch --tags --progress https://github.com/phpmyadmin/phpmyadmin.git +refs/heads/*:refs/remotes/origin/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from https://github.com/phpmyadmin/phpmyadmin.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:810)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1066)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1097)
at hudson.scm.SCM.checkout(SCM.java:495)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1278)
at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1729)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Caused by: hudson.plugins.git.GitException: Command "git -c core.askpass=true fetch --tags --progress https://github.com/phpmyadmin/phpmyadmin.git +refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout:
stderr: error: object file .git/objects/cd/6302804266b678e9d92f3510e4a6ed014e3971 is empty
error: object file .git/objects/cd/6302804266b678e9d92f3510e4a6ed014e3971 is empty
fatal: loose object cd6302804266b678e9d92f3510e4a6ed014e3971 (stored in .git/objects/cd/6302804266b678e9d92f3510e4a6ed014e3971) is corrupt
fatal: The remote end hung up unexpectedly
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1719)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1463)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:63)
at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:314)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:808)
... 11 more
ERROR: null
[CHECKSTYLE] Skipping publisher since build result is FAILURE
[JSLINT] Skipping publisher since build result is FAILURE
[DRY] Collecting duplicate code analysis files...
[DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml
[DRY] Parsing 1 file in <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/>
[DRY] Skipping file of module <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.x…> because it's empty.
[DRY] Computing warning deltas based on reference build #12616
[TASKS] Skipping publisher since build result is FAILURE
[ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #12616
Recording plot data
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing PHPUnit-3.x (default)
[xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'.
[xUnit] [ERROR] - Test reports were found but not all of them are new. Did all the tests run?
* <https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml> is 27 days old
[xUnit] [INFO] - Failing BUILD.
[xUnit] [INFO] - There are errors when processing test results.
[xUnit] [INFO] - Skipping tests recording.
[xUnit] [INFO] - Stop build.
ERROR: Step ‘Report Violations’ aborted due to exception:
java.io.EOFException: input contained no data
at org.xmlpull.mxp1.MXParser.fillBuf(MXParser.java:3003)
at org.xmlpull.mxp1.MXParser.more(MXParser.java:3046)
at org.xmlpull.mxp1.MXParser.parseProlog(MXParser.java:1410)
at org.xmlpull.mxp1.MXParser.nextImpl(MXParser.java:1395)
at org.xmlpull.mxp1.MXParser.next(MXParser.java:1093)
at hudson.plugins.violations.parse.AbstractParser.expectNextTag(AbstractParser.java:262)
at hudson.plugins.violations.types.checkstyle.CheckstyleParser.execute(CheckstyleParser.java:39)
at hudson.plugins.violations.parse.AbstractTypeParser.parse(AbstractTypeParser.java:57)
at hudson.plugins.violations.ViolationsCollector.doType(ViolationsCollector.java:187)
at hudson.plugins.violations.ViolationsCollector.invoke(ViolationsCollector.java:114)
at hudson.plugins.violations.ViolationsCollector.invoke(ViolationsCollector.java:25)
at hudson.FilePath.act(FilePath.java:996)
at hudson.FilePath.act(FilePath.java:974)
at hudson.plugins.violations.ViolationsPublisher.perform(ViolationsPublisher.java:74)
at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45)
at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
at hudson.model.Build$BuildExecution.post2(Build.java:185)
at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:665)
at hudson.model.Run.execute(Run.java:1754)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Hi,
I've made some commit to QA_4_6, which I wish to merge in to master. I
get a conflict on a .po file. According to [1], I can complete the
merge with a couple of different techniques depending on which
situation I'm in. Unfortunately, this portion doesn't make much sense
to me. Can I get some assistance with figuring out how to work
effectively with a conflict in the .po files?
Isaac
1 - https://github.com/phpmyadmin/phpmyadmin/wiki/Git#merging-translations
Hello team,
In about two weeks, I'll release the first alpha of 4.7.0. At that
point, we typically are in a feature freeze and only fix bugs. We have
a number of issues still pending, but most of them look like bug
fixes.
Additionally, sql-parser has a few issues which would be good to fix
before the final release, but since they're bug fixes they aren't
urgent.
Just a friendly reminder that this feature freeze is looming. If you
have any issues in mind for 4.7 (either as a feature or bug), please
add the appropriate tag in the tracker. At this point, we probably
have more issues than time before the release, so we'll have to
prioritize which issues are most important to resolve before the
release.
Regards,
Isaac
Hello all,
I have a problem with the Cookie authentication. I will try to explain
my setup and the appearing problem as good as possible. It's a bit
complicated due to the fact, that there is no error message in the
interface and in the logs.
SETUP
The system is an Ubuntu 16.04 LTS (Xenial) with PHP-FPM, Nginx and MySQL
installed from the package repositories.
I use PHP-FPM pools, where every pool, has an own chroot.
Nginx connects to PHP-FPM with Unix-Sockets.
I am using phpMyAdmin version 4.6.5.2.
PROBLEM
phpMyAdmin is installed and accessible on a subdomain. All traffic is
exchanged via HTTPS.
Actually phpMyAdmin connects to MySQL via TCP connection. The problem
is, that the Cookie authentication doesn't work. So if I set
$cfg[auth_type] = "cookie"; I can't login to phpMyAdmin. The interface
and the logs doesn't show any errors. When I change the mentioned
variable to "http" so that HTTP Auth is used, the login works without
problems.
CONFIGURATION
I use a few special PHP settings for security reasons. They are mostly
the same as in the OWASP PHP Configuration Cheat Sheet. This document
can be found here:
https://www.owasp.org/index.php/PHP_Configuration_Cheat_Sheet
As I said no error is shown, and no error goes into the PHP log of the
pool. I think all is related to the cookie or session handling, but I
don't know how I could debug this.
CHECKED THINGS
I already checked the following:
1. The mcrypt extension is installed
2. Session data can be stored correctly
3. Disable the cookie and session related settings
CONCLUSION
I have checked some things but couldn't figure it out. So I would be
happy about every type of help. If more information is needed please
tell me what exactly is necessary.
P.S. Sorry for my bad english.
Since there is nothing on the agenda for the meeting this month, I
propose that we do not have the IRC meeting on Wednesday.
We'll plan to meet again next month and happy new year!
Hi everyone,
I need some help ! When using phpunit on my clone of PMA I receive "
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried
to allocate 1048960 bytes) in
/Users/osaidrehmannasir/Desktop/phpmyadmin/vendor/tecnickcom/tcpdf/fonts/dejavusans.php
on line 14" . According to stackoverflow I should edit the php.ini
file but for some reason that doesn't work . Any suggestion ?
Hello
Don't get me wrong, but we really can not release patch release for
every bug we fix. We do that only for things like data corruption or
bugs affecting many users.
You're talking about https://github.com/phpmyadmin/phpmyadmin/issues/12
786 which was reported by you and nobody else did complain about that
issue...
On the other side, there are currently 46 issues fixed for 4.6.6, many
of them being more important and affecting more users:
https://github.com/phpmyadmin/phpmyadmin/milestone/228?closed=1
--
Michal Čihař | https://cihar.com/ | https://weblate.org/
Flavius Nopcea píše v St 04. 01. 2017 v 17:16 +0200:
> feeling disappointed...
>
> if you have a server with only a few databases then I agree with
> you...
>
>
> On 04.01.2017 17:12, Michal Čihař wrote:
> > Hi
> >
> > Flavius Nopcea píše v Út 03. 01. 2017 v 10:34 +0200:
> > > yes, but what about patch releases?
> > >
> > > you keep the search functionality not working for 2 months?
> >
> > So far we didn't consider this bug to be important enough for a
> > patch
> > release.
> >
>
>
Hi
Flavius Nopcea píše v Út 03. 01. 2017 v 10:34 +0200:
> yes, but what about patch releases?
>
> you keep the search functionality not working for 2 months?
So far we didn't consider this bug to be important enough for a patch
release.
--
Michal Čihař | https://cihar.com/ | https://weblate.org/
