14 Jun
2012
14 Jun
'12
3:14 p.m.
On 13/06/12 20:06, Dieter Adriaenssens wrote:
Hi all,
I merged some important changes to the master branch from the GSoC
project of Rouslan Placella, introducing a few new classes
(PMA_Response, PMA_Header, PMA_Footer, ..) that will handle html and
ajax responses, buffering output and generating the header, footer,
body. More information on how this works and how this impacts your
code can be found in the wiki page that Rouslan created [0].
Both Rouslan and me tested it and most bugs should be fixed now, but
don't hesitate to report any misbehaviour that might be related to the
introduction of these classes.
@ all GSoC students, if you're not doing this regularly already, this
might be a good time to update your branch with the recent changes in
the master branch (i.e. do a 'merge master' in your branch)
@ Rouslan:
There were no issues during merging.
After I merged, I noticed that the 'git revision' section on the main
page is broken. Can you have look at it?
Hi Dieter,
Not sure what's wrong here, as it works just fine for me.
About your wiki page, apart from some typo's, it
looks very good. You
explained very clearly what the different classes do and how to use
them.
I think it might be a good idea to stress that using the PMA_Response,
etc. classes is preferred and the old style is deprecated/strongly
discouraged.
It might be useful to add some examples when to use certain
functionality, like disabling headers/footers, ...
OK, I added a few lines about this.
I noticed you removed some unit tests related to
global methods that
were replaced by methods in your classes. Do you plan to reintroduce
them when you will write unit tests for your new classes?
I dropped some test cases because they don't make sense any more.
PMA_showHint() merely returns its input wrapped in a tag now, since the
footnotes are gone. PMA_ajaxResponse() doesn't exists any more, but I
will write some test cases to cover the PMA_Response class at a later
time, as it provides the equivalent functionality.
Bye,
Rouslan
[0]
http://wiki.phpmyadmin.net/pma/Generating_pages_and_ajax_responses_in_pma4
Kind regards,
Dieter Adriaenssens