Hi
You again missed reply to list, moving discussion back there :-).
Dne Tue, 12 Jul 2011 18:48:57 +0300
Tyron Madlener <tyronx(a)gmail.com> napsal(a):
On Tue, Jul 12, 2011 at 3:49 PM, Michal Čihař
<michal(a)cihar.com> wrote:
Hi
Dne Tue, 12 Jul 2011 13:08:37 +0300
Tyron Madlener <tyronx(a)gmail.com> napsal(a):
And one more suggestion:
Counting rows in big tables that use CSV as Engine (such as the
general_log) seem very slow. Maybe rows should not be counted
automatically for CSV Tables and only done upon user request.
In my test I counted 36k rows on the demo server, that takes around
250ms, so imagine the general_log running all day. Then you will have
1mil+ rows, which then requires ~6-8 seconds to count.
There is already similar logic for InnoDB or views, so only another
engine should be added here.
Do you know in which file/line this is?
It should be libraries/display_tbl.lib.php somewhere near usage of
MaxExactCount.
Next suggestion :D
Just saw in header_scripts.inc.php that codemirror.js and mysql.js is
included globally. Isn't that a bit overkill? Not every page (like my
status page) requires codemirror.
I don't think it hurts that much (browser should have that file in
cache), generally I was too lazy to figure out in which all places SQL
box needing highlighting might appear.
--
Michal Čihař |
http://cihar.com |
http://phpmyadmin.cz