2012/6/4 Dieter Adriaenssens <dieter.adriaenssens@gmail.com>:
2012/6/4 Rouslan Placella <rouslan@placella.com>:
On 03/06/12 21:39, Dieter Adriaenssens wrote:
Hi Rouslan,
I went through your latest commits in your GSoC branch, see github for the small remarks.
You did a great job on creating the different classes (PMA_Header, PMA_Footer, PMA_Response, ...) moving functionality from other library files into it, and integrating these new classes in the current code base.
I think you've come to a point where these changes are ready to be merged with master. What do you think?
Hi Dieter,
I'd love to merge, but I feel that my branch isn't quite ready. I have an issue with the error_handler class where errors are generated while displaying previous errors. The number of errors increases exponentially at every page load until eventually the session explodes. So, yeah, I wouldn’t dare merging something as bad as this into master.
Hi Rouslan,
Good thinking! :p
Let me know when you found and fixed that bug.
Hi Rouslan, I read in the weekly report of Alex Marin (another GSoC student) that he will start working on the authentication files soon. I noticed you made some changes to these files as well, so it's a good idea to discuss this before the start of the merge. @Alex Marin: have you started working on these files? When do you plan to start? It seems like a good idea that you start working on the version with the commits of Rouslan, to avoid merge problems later on. Kind regards, Dieter Adriaenssens