User could be notified earlier about an error if during export PMA would periodically (eg. each 5 secs) call server through HXR to read a session variable with current state. Then:
1. During export, after 5 secs a user sees a message "Export pending". 2a. User has JavaScript enabled and HXR fires every 5 seconds 2a1. Export failed - user sees a message "Export failed with error: {error read from session variable}" 2a2. Export succeeded - user sees a message "Export successfully completed" 2b. User has JavaScript disabled 2b1. Export failed - user sees error message on next page refresh 2b2. Export succeeded - nothing happens
When user has JavaScript disabled the behavior would be as it is now because messages would be triggered by XHR request.
Regards, Piotr
2009/4/10 Herman van Rink rink@initfour.nl:
Marc Delisle wrote:
Hi,
about this bug https://sourceforge.net/tracker/?func=detail&aid=2107746&group_id=23...
there is a way to trap this fatal error. Using register_shutdown_function() we can define a function that calls error_get_last(). Michal gave me a suggestion to keep the error message in session data and display it later. Of course it would be better to display it on the export interface but I can't find a way.
Is this only relevant when you 'Save as file' or in other cases as well?
So, would it be worthwhile to display the error message on the user's next click (assuming he does a next click in phpMyAdmin)?
On the next click is better then nothing, but still a risk.
Regards,
Herman
This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel