A few changes to PMA code
patch at http://trac.nq.pl/pma/browser/trunk/patches/pma_dev.patch ================================================================== most changes are obvious I changed only_db to an array as internally it makes no diffrence to PMA and it's easier for me to handle variables that have only one type. I think the only place where this change matters is _checkOnlyDatabase() in List_Database.class.php (fix also in patch)
import.lib.php ============== PMA_importRunQuery()
unused $timeout_passed in global $cfg mentioned two times in global
export.php ========== $onfly_compression = $GLOBALS['cfg']['CompressOnFly'] && ($compression == 'gzip' | $compression == 'bzip'); $onfly_compression = $GLOBALS['cfg']['CompressOnFly'] && ($compression == 'gzip' || $compression == 'bzip');
use the logic OR operator, there's no need for binary operations here I can't find where "on the fly" compression is enabled, is it used at all?
tbl_properties.inc.php ====================== $hint = '<p>' . sprintf($strMIME_transformation_note, '<a href="transformation_overview.php?' . PMA_generate_common_url($db, $table) . '" target="_blank">', '</a>') . '</p>';
<p> isn't allowed inside of <li>
Config.class.php ================ PMA_Config::getThemeUniqueValue() reading pma_fontsize cookie may produce a notice when it isn't set, add isset check
Piotr