Re: [Phpmyadmin-devel] legal concerns about external libraries

Dieter Adriaenssens a écrit :

library/PHPExcel and native Excel import/export was removed from QA_3_4 (ready for 3.4.5) and master. I've run into some things that seemed to be used only by Excel export/import, but haven't removed them yet :

• config option TempDir -> according to Documentation.html this was

needed for Excel export, the option is only used in File.Class.php -> checkUploadedFile()

• checkUploadedFile () -> not used anymore
• PMA_getColumnNumberFromName() -> not used

Shall I remove them as well, or will they be needed in the future?

About TempDir, there is another (optional) purpose, see FAQ 1.11. But it's been a while since I last tested this...

checkUploadedFile() has comments about being used in the open_basedir situation.

BTW : PMA_getColumnAlphaName() is still used by ods import