Marc Delisle schrieb:
Sebastian Mendel a écrit :
Sebastian Mendel schrieb:
Hi,
any odds against splitting common.lib.php into .lib.php and .inc.php?
common.lib.php
holding all functions
common.inc.php
including common.lib.php holding all procedural code
(easier testing of function)
i would also drop the
if (!defined('PMA_MINIMUM_COMMON')) {
arround the functions, as i cannot think and do not detect any speed improvements upon this
the only thing where this would help if this 'not so' common function would be in another sperate file what is include if (!defined('PMA_MINIMUM_COMMON'))
common.inc.php:
require_once 'core.lib.php'; if (! defined('PMA_MINIMUM_COMMON')) { require_once 'common.lib.php' }
Take care, I tested removing define('PMA_MINIMUM_COMMON', true);
in phpmyadmin.css.php and it messes the display.
but this 'messed display' is affected by the procedural code, not the function definitions, IMHO