Zeeshan M. a écrit :
/ I'm not sure we agreed on the list that there was a need to enable/disable each setting one by one. / Allowing sysadmins to enable/disable each setting does not make code either more complex, or trivial to write. I think that it would give them more options certainly; do they really need these options or not differs from person to person. What are your thoughts?
I favor the KISS principle, and I don't see who would need to fine-tune which parameter can be saved by user, or not.
Keeping things more simple means less documentation to write, less parameters to worry about for sysadmins, etc. Not to mention less code bloat which leads to slower performance.
/I agree with Herman's reaction, so it could be $cfg['Servers'][$i]['//userprefs']['enable'] = true|false;/
Sounds good. May be $cfg['Servers'][$i]['enable_userprefs'] would be better since enable is the only sub-array of "userprefs"?
Ok, especially if there are no other fine-tuning user prefs parameters ;)
Best regards, Zeeshan Mughal Email: zeeshanmughal@ieee.org mailto:zeeshanmughal@ieee.org Web: http://www.zixan.info
On Fri, Jul 17, 2009 at 12:58 PM, Marc Delisle <marc@infomarc.info mailto:marc@infomarc.info> wrote:
Zeeshan M. a écrit : > Hi, > > I added configuration vars for all the settings currently under > consideration. Please let me know if I am following the convention > correctly, and/or if there is anything else. > > I decided to get this done first as I would need to access these vars > for user interfaces. Zeeshan, I don't understand why you are using a syntax like $cfg['perm_storage'][$i]['font_size'] = TRUE; As you are using $i it means this is a setting per server, right? So it should be, IMO, something like $cfg['Servers'][$i]['userprefs']['font_size']; which would follow the other $cfg['Servers'][$i] settings. And perm_storage is not meaningful, again IMO. I agree with Herman's reaction, so it could be $cfg['Servers'][$i]['userprefs']['enable'] = true|false; By the way, I'm not sure we agreed on the list that there was a need to enable/disable each setting one by one. -- Marc Delisle http://infomarc.info