On Mon, 2011-08-01 at 14:24 +0200, Piotr Przybylski wrote:
2011/8/1 Rouslan Placella rouslan@placella.com:
I noticed that the JS code that handles the recent tables in the navigation frame operates under the assumption that there will only ever be one dot in the database+table string. This is not true. To reproduce the problem:
- create database 'abc.def'
- in this database create table 'ghi'
- browse this table
- now select it from the recent table dropdown
- you are dropped to main.php because PMA is looking for database 'abc'
and table 'def' (the 'ghi' part is discarded)
I'm not saying that it's sane to put dots in the database name, but it's certainly legal. So maybe the check should be for the last occurrence of a dot...
Then we will still have problems with dots in table names. From what you are saying it looks like this should be changed to get these names from some other place.
Last time I checked dots in table names were illegal, but yeah, having the db and table name already split would definitely be a win.
Rouslan