On Thu, Jun 20, 2013 at 11:32 AM, Dieter Adriaenssens dieter.adriaenssens@gmail.com wrote:
2013/6/20 Michal Čihař michal@cihar.com:
Hi
Dne Thu, 20 Jun 2013 11:01:30 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
2013/6/19 Rouslan Placella rouslan@placella.com:
Thought I'd mention that third party libraries (jquery, jquery plugins, etc) can stay minified IMO. All we really care to debug is our code. Besides, the public API of any external library will remain unmangled.
I agree, it doesn't make sense to show a stack trace of where it goes wrong in those libraries. If there would be a bug there it can be found by a developer who investigates an error report.
Mohamed, can you take a look at the release script and modify it so that our JS files are no longer minified?
The script that compresses files keeps originals in a sources directory. The release script deletes this folder. I will just remove the line that deletes this folder. I will then change the get_script.php file to get the js files from the sources directory if it exists and the error reporting setting is active. otherwise it will load the minified version.
Maybe we can simply include minified jQuery and jQuery-UI in git and do no minification on release time? These are anyway the big libraries and we don't want to touch their code anyway...
Good idea!
-- Kind regards,
Dieter Adriaenssens
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel