[Phpmyadmin-devel] SQL parser

Robin, I've just have had a look at the last version of your parser. Here is some PHP3 problems i've noticed: - function must be declared before they are called. Then, for example, you can't call "PMA_sqlParser_ArrayAdd_Timer()" in the "PMA_sqlParser_ArrayAdd()" function because the former is declared after the latter; - "include_once" and "require_once" are PHP4 functions; - "===" and "!==" are PHP4 operators. Some coding standard fixes also : - settings of function should be separated by ", " (comma plus a space character); - keywords for control structures should be separated from the condition by a space ie: if (condition) { do some stuff } else { do some stuff } - function names should not contain escaped charcters except after the "PMA" prefix ie "PMA_number_inrange()" should be "PMA_numberInRange". I've modified your "sqlparse.php3" file in order it fits PEAR coding standards (excpet comments for function) and may run with PHP3. But I can't test it before the end of the week. You'll find it attached to this message. Loïc ______________________________________________________________________________ ifrance.com, l'email gratuit le plus complet de l'Internet ! vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP... http://www.ifrance.com/_reloc/email.emailif