Re: [Phpmyadmin-devel] Help about issues reported by scrutinizer

On Tue, Jun 23, 2015 at 2:52 AM, Nisarg Jhaveri <nisargjhaveri(a)gmail.com> wrote: Appreciate that you are making an effort to fix issues reported by Scrutinizer. Regarding issue [1], you are accessing property hiddenCount in Node which is only defined in Node_Database about which the scrutinizer complains. It's true that you have done an instanceof check, but this is generally an anti pattern, and you can resolve this easily using inheritance. See [2] to how this can be resolved. Issue [3] is somewhat similar. This can be resolved by moving the related logic to Node_DatabaseChild class and by changing the semantics of the class a bit [4] (I am referring to the change in class description). If we could not change the semantics of the class, we could have added a parent class to achieve the same.

Issue [5] can be resolved by properly defining the type [6]

[1] https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/inspections/b0f631e5-657… [2] https://github.com/phpmyadmin/phpmyadmin/commit/312d1599229a615405400b20879… [3] https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/inspections/b0f631e5-657… [4] https://github.com/phpmyadmin/phpmyadmin/commit/789d9aa01885d48ca2d00d30fe2… [5] https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/inspections/b0f631e5-657… [6] https://github.com/phpmyadmin/phpmyadmin/commit/67a94c222c202b467e1b2d545e9… -- Thanks and Regards, Madhura Jayaratne