23 May
2013
23 May
'13
9:30 a.m.
Hi
Dne Thu, 23 May 2013 02:27:06 -0400 Marc Delisle marc@infomarc.info napsal(a):
Your pull request targets master and I've sent comments for it. When it's ready, do you feel that this patch belongs to 4.0?
IMHO no as it requires CodeMirror upgrade. Also I currently have no idea how to incorporate links to doc as we have them in PHP highlighter, so at current state it would mean losing functionality.
If we don't use CodeMirror for highlighting in 4.0, I suggest we remove these incorrect reserved words for 4.0, even if this will break highlighting, because getting false warnings about reserved words is worse that incorrect hightlighting.
I agree.
--
Michal Čihař | http://cihar.com | http://phpmyadmin.net