[Phpmyadmin-devel] Refactoring tbl_zoom_select.php

Hi Marc, While looking at "tbl_zoom_select.php":- Line 191-201 if (isset($inputs) && ($inputs[0] != 'pma_null' || $inputs[1] != 'pma_null')) { $flag = 2; for ($i = 0 ; $i < 4 ; $i++) { if ($inputs[$i] != 'pma_null') { $key = array_search($inputs[$i], $fields_list); $tbl_fields_type[$i] = $fields_type[$key]; $tbl_fields_collation[$i] = $fields_collation[$key]; $tbl_fields_null[$i] = $fields_null[$key]; } } } As the condition would be true in cases when post param $inputs is set and has index 0 or 1 set to some column name. It would mostly happen if a half or full filled search form is submitted, but there seems to be no further use of $tbl_fields_collation & $tbl_fields_null. Though $tbl_fields_type gets used afterwards with indexes >= 4. I think as a result after the zoom plot is displayed, clicking at "show search criteria" doesn't show any previously filled criteria. I also didn't understand the use of $flag variable. Thanks -- Atul Pratap Singh Senior Undergraduate Student Institute Of Technology, Banaras Hindu University, Varanasi, India.