Thilanka Kaushalya a écrit :
Hi Marc,
I did following changes and committed to the repository.
Could you change one thing about the js variable names? By convention, adding a $ prefix is only for jQuery objects. In your code, "$url" should be "url" because it does not refer to the jQuery object but to an attribute of it.Modified the variable names in navigation.js file.
Also, replace <script src="js/messages.php"></script> with <script type="text/javascript" src="js/messages.php"></script>Modified the navigation.php file.
Another thing: you copied chunks of code from js/functions.js into js/navigation.js. This means maintainability problems for the future. Can you refactor this code into a function which would be in functions.js and called from both places (table creation in navigation panel and table creation in main panel)?Added the code to PMA_createTableDialog function in function.js file.
Please check the repository. I'll write a blog post on the task by tomorrow. Thank you.
Regards, Thilanka.
Thilanka, it looks fine and is almost ready to be merged to origin/master!
I just saw something else that needs improvement. When using the new "Create table" button, we get a dialog with room for just one column. And the dialog to add columns, which needs to be used unless the table has only one column (not likely), is not in sight at this point.
I suggest moving the "Add x column(s) ... Go" dialog on top of the panel, next to the table name input field. This will at the same time clarify the interface because seeing Save Or Add X column(s) Go
is cluttered and unclear.