W dniu 3 czerwca 2011 11:25 użytkownik Dieter Adriaenssens dieter.adriaenssens@gmail.com napisał:
2011/6/2 Piotr Przybylski piotr.prz@gmail.com:
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Thu, 2 Jun 2011 15:30:48 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Tue, 31 May 2011 19:08:12 +0200 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
In commit add6c6325c [0], you dropped MySQL from the collation and charset description. Both strings seem a bit confusing now, I would replace 'MySQL' to 'Server' or 'Database', or make the 'MySQL' prefix conditional (and replace it by 'Drizzle' in case of Drizzle), like you did with the heading of the server info section.
[0] http://repo.or.cz/w/phpmyadmin/crack.git/commitdiff/add6c6325c238cdca23ce021...
Also please consider that we can be connected to MariaDB server, so the naming should either include it as well or be server neutral.
Then we have two options for I the conditional MySQL/Drizzle header:
- change it to 'Database server', add some information on server type in frame
I think this is better option, adding server type next to server version (anyway MySQL version 2011.03.13 sounds crazy).
I included MariaDB in texts, you can see this change on demo server [1].
You implemented option 2. ;)
I think it's better to have 'Database server' as header and then a 'Server type :' field with the kind of server. This is more consistent with the 'Web server' section below.
Done