Re: [Phpmyadmin-devel] jshint errors

Hi

Dne Tue, 16 Apr 2013 06:33:52 -0400 Marc Delisle marc@infomarc.info napsal(a):

Le 2013-04-16 03:06, Michal Čihař a écrit :

...

I think PMA_messages.strSave is shorter and looks nicer than PMA_messages['strSave'], though I don't have strong opinion on that. Also with messages (the most frequent of this warning in our case) we can be pretty sure we don't use reserved words, so the dot syntax is always safe here.

I also think the dot notation is better, and here is another reason. When seeing the string in quotes, I always wonder whether the string 'strSave' will be shown to the user.

I've made pull request for this change:

https://github.com/phpmyadmin/phpmyadmin/pull/257

Please review and eventually merge that.