19 Jul
2011
19 Jul
'11
1:36 p.m.
On Tue, 2011-07-19 at 13:02 +0300, Tyron Madlener wrote:
Rouslan, about your patch "Fix for bug #3354356 -
Timepicker does not
work in AJAX dialogs", commit 9e34ccf57cfc97c3cac6d7f9ceecd6e1cc89e10d
This fix is flawed. The z-index is calculated by the amount of opened
widgets. So as soon as there is one more widget opened, the timepicker
will appear in the background again.
One way to get it working would be using following code in the
beforeShow event in PMA_addDatepicker()/functions.js
// Fix wrong timepicker z-index, doesn't work without timeout
setTimeout(function() {
$('#ui-timepicker-div').css('z-index',$('#ui-datepicker-div').css('z-index'))
},0);
If pushed this change to my repo, so if it will be merged to master,
the bug will be fixed already.
Nice catch. I was testing on modal dialogs, no wonder I didn't catch
this problem. Did you find an area of PMA where timepickers are used on
non-modal dialogs?
Rouslan